Re: [PATCH 2/4] rockchip: rk3399-rockpro64: Hook sysreset gpio to enable full reset

[Paul Kocialkowski <paulk@sys-base.io>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

Hi,

Le Tue 05 Nov 24, 16:38, Quentin Schulz a écrit :
> Hi Paul,
> 
> On 9/26/24 8:31 PM, Paul Kocialkowski wrote:
> > From: Paul Kocialkowski <contact@paulk.fr>
> > 
> > The reset mechanism used by Linux to reset the SoC is known to only
> > partially reset the logic. A mechanism is implemented in
> > rk3399_force_power_on_reset to use a GPIO connected to the PMIC's
> > over-temperature (OTP) reset pin, which fully resets all logic.
> > 
> > Hook the associated GPIO where the function expects it to enable this
> > reset mechanism and avoid any possible side-effect of partially-reset
> > units.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> 
> Since patches 3 and 4 seems to be a bit controversial, maybe send patches 1
> and 2 in a different patch series so those can be merged separately?
> 
> You may want to have a look at https://lore.kernel.org/u-boot/20241105-rk3399-sysreset-gpio-tpl-v1-0-12caff07a4e4@cherry.de/T/#t

Sounds like a good idea. I should probably wait for your series to get-in
and respin a version of just the sysreset patches with the right bootph flags.

Cheers,

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Specialist in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]