* [U-Boot-Users] [PATCH] Use info->reset_cmd instead of FLASH_CMD_RESET
@ 2005-02-12 0:14 Zachary Landau
2005-09-25 14:42 ` Wolfgang Denk
0 siblings, 1 reply; 2+ messages in thread
From: Zachary Landau @ 2005-02-12 0:14 UTC (permalink / raw)
To: u-boot
Hello,
This patch makes cfi_flash.c use info->cmd_reset. It was being set by
flash_get_size() but not being used, which kept the Flash on my board
from properly being reset.
It looks like there are a lot of switch cases for different flash
types that could probably probably be removed by setting up some
function pointers, but that is a project for another time.
--
Zachary P. Landau <kapheine@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_reset.patch
Type: text/x-patch
Size: 1660 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050211/286d27df/attachment.bin
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot-Users] [PATCH] Use info->reset_cmd instead of FLASH_CMD_RESET
2005-02-12 0:14 [U-Boot-Users] [PATCH] Use info->reset_cmd instead of FLASH_CMD_RESET Zachary Landau
@ 2005-09-25 14:42 ` Wolfgang Denk
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2005-09-25 14:42 UTC (permalink / raw)
To: u-boot
In message <a04f56da050211161468c3982f@mail.gmail.com> you wrote:
>
> This patch makes cfi_flash.c use info->cmd_reset. It was being set by
> flash_get_size() but not being used, which kept the Flash on my board
> from properly being reset.
Added, thanks. But please provide a CHANEGLOG entry next time.
> It looks like there are a lot of switch cases for different flash
> types that could probably probably be removed by setting up some
> function pointers, but that is a project for another time.
Patches are welcome!
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
- Albert Einstein
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-25 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-12 0:14 [U-Boot-Users] [PATCH] Use info->reset_cmd instead of FLASH_CMD_RESET Zachary Landau
2005-09-25 14:42 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox