From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Adam Ford <aford173@gmail.com>, u-boot@lists.denx.de
Cc: sbabic@denx.de
Subject: Re: [PATCH] imx: imx8mm/imx8mn_beacon: Remove redundant code
Date: Mon, 21 Mar 2022 11:20:29 +0800 [thread overview]
Message-ID: <a07ed784-e30a-251f-ad67-03e30588fb55@oss.nxp.com> (raw)
In-Reply-To: <20220223135051.27707-1-aford173@gmail.com>
On 2022/2/23 21:50, Adam Ford wrote:
> The Ethernet controller and PHY use the device tree info to
> configure themselves, so it's not necessary to manually do it
> in the board file. This permits the removal of a bunch of headers
> as well.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
>
> diff --git a/board/beacon/imx8mm/imx8mm_beacon.c b/board/beacon/imx8mm/imx8mm_beacon.c
> index c228bbf777..204235a3f8 100644
> --- a/board/beacon/imx8mm/imx8mm_beacon.c
> +++ b/board/beacon/imx8mm/imx8mm_beacon.c
> @@ -1,52 +1,13 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
> - * Copyright 2020 Compass Electronics Group, LLC
> + * Copyright 2022 Logic PD, Inc. dba Beacon EmbeddedWorks
> */
>
> -#include <common.h>
> -#include <miiphy.h>
> -#include <netdev.h>
> #include <asm/global_data.h>
>
> -#include <asm/arch/clock.h>
> -#include <asm/arch/sys_proto.h>
> -#include <asm/io.h>
> -
> DECLARE_GLOBAL_DATA_PTR;
>
> -#if IS_ENABLED(CONFIG_FEC_MXC)
> -static int setup_fec(void)
> -{
> - struct iomuxc_gpr_base_regs *gpr =
> - (struct iomuxc_gpr_base_regs *)IOMUXC_GPR_BASE_ADDR;
> -
> - /* Use 125M anatop REF_CLK1 for ENET1, not from external */
> - clrsetbits_le32(&gpr->gpr[1], 0x2000, 0);
> -
> - return 0;
> -}
> -
> -int board_phy_config(struct phy_device *phydev)
> -{
> - /* enable rgmii rxc skew and phy mode select to RGMII copper */
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
> -
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
> -
> - if (phydev->drv->config)
> - phydev->drv->config(phydev);
> - return 0;
> -}
> -#endif
> -
> int board_init(void)
> {
> - if (IS_ENABLED(CONFIG_FEC_MXC))
> - setup_fec();
> -
> return 0;
> }
> diff --git a/board/beacon/imx8mn/imx8mn_beacon.c b/board/beacon/imx8mn/imx8mn_beacon.c
> index 6397dac872..204235a3f8 100644
> --- a/board/beacon/imx8mn/imx8mn_beacon.c
> +++ b/board/beacon/imx8mn/imx8mn_beacon.c
> @@ -1,52 +1,13 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
> - * Copyright 2020 Compass Electronics Group, LLC
> + * Copyright 2022 Logic PD, Inc. dba Beacon EmbeddedWorks
> */
>
> -#include <common.h>
> -#include <miiphy.h>
> -#include <netdev.h>
> -
> -#include <asm/arch/clock.h>
> -#include <asm/arch/sys_proto.h>
> #include <asm/global_data.h>
> -#include <asm/io.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> -#if IS_ENABLED(CONFIG_FEC_MXC)
> -static int setup_fec(void)
> -{
> - struct iomuxc_gpr_base_regs *gpr =
> - (struct iomuxc_gpr_base_regs *)IOMUXC_GPR_BASE_ADDR;
> -
> - /* Use 125M anatop REF_CLK1 for ENET1, not from external */
> - clrsetbits_le32(&gpr->gpr[1], 0x2000, 0);
> -
> - return 0;
> -}
> -
> -int board_phy_config(struct phy_device *phydev)
> -{
> - /* enable rgmii rxc skew and phy mode select to RGMII copper */
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
> -
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
> - phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
> -
> - if (phydev->drv->config)
> - phydev->drv->config(phydev);
> - return 0;
> -}
> -#endif
> -
> int board_init(void)
> {
> - if (IS_ENABLED(CONFIG_FEC_MXC))
> - setup_fec();
> -
> return 0;
> }
>
next prev parent reply other threads:[~2022-03-21 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:50 [PATCH] imx: imx8mm/imx8mn_beacon: Remove redundant code Adam Ford
2022-02-26 13:01 ` Fabio Estevam
2022-03-21 3:20 ` Peng Fan (OSS) [this message]
2022-04-12 18:42 ` sbabic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a07ed784-e30a-251f-ad67-03e30588fb55@oss.nxp.com \
--to=peng.fan@oss.nxp.com \
--cc=aford173@gmail.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox