Re: [PATCH 3/3] arm: mvebu: helios-4: add defconfig for spi booting

[Josua Mayer <josua@solid-run.com>]

Hi Tim,

Am 13.01.24 um 18:22 schrieb Tom Rini:
> On Sat, Jan 13, 2024 at 05:36:57PM +0100, Josua Mayer wrote:
>
>> Add a new defconfig based on existing helios4_config file to support
>> booting from spi flash.
>>
>> Settings for environment location are based on vendor u-boot:
>> https://github.com/kobol-io/u-boot/blob/helios4/include/configs/helios4.h#L59
>>
>> A separate defconfig is required because the options are not
>> intuitive from menuconfig, numeric values in particular.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>  configs/helios4_spi_defconfig | 81 +++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 81 insertions(+)
> So, a super new thing that might be of interest, but please try this
> since I'd like to prove/disprove the use-case.  This could instead be:
> configs/helios4_spi_defconfig:
> #include "configs/helios4_defconfig"
> ... enable/disable options specific to the SPI boot use case ...
I will try it, I like the idea conceptually.
>
> And so now both boards will otherwise be kept in-sync for general config
> changes.  It could further be done as:
> configs/helios4_spi_defconfig:
> #include "configs/helios4_defconfig"
> #include "board/kobol/helios4/spiboot.config"
Here is potential for making it infinitely complex.
E.g. one might argue there should be an armada38x_spi.config
>
> And have board/kobol/helios4/spiboot.config contain the SPI-boot
> specific options.  This path would allow for:
> make helios4_defconfig spiboot.config
> to be a valid alternative way of configuring a build for spiboot.
>