From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0A2DC433EF for ; Thu, 13 Jan 2022 18:30:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1900D832E6; Thu, 13 Jan 2022 19:30:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="hFC/7ngx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B586F83311; Thu, 13 Jan 2022 19:30:14 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by phobos.denx.de (Postfix) with ESMTP id B832B831F0 for ; Thu, 13 Jan 2022 19:30:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dphadke@linux.microsoft.com Received: from [192.168.86.154] (unknown [50.47.106.53]) by linux.microsoft.com (Postfix) with ESMTPSA id C3ECD20B7133; Thu, 13 Jan 2022 10:30:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C3ECD20B7133 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1642098610; bh=XocArTvS+/qLCZ9IwVvbCgXMJvbVYyNRlIRAUBjmpK4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hFC/7ngx1+5elqte0vCPk1ueOAHhDnZOQJOkdcOwxZrgYNwiuahZee+wSq/QVsJUL 74vjwGuIG19L9aShZhUrpFcDZ8BnFLhUPpHqa1k3vSjqcBTQjudOe0nxuswUSsHKw1 7vl8X59gnUNq8xE4jggRkt9p+3kE4HO+jDW3sQ+Y= Message-ID: Date: Thu, 13 Jan 2022 10:30:10 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV Content-Language: en-US To: Angus Ainslie , Jagan Teki Cc: Vignesh R , u-boot@lists.denx.de, kernel@puri.sm References: <20220113171726.1669216-1-angus@akkea.ca> From: Dhananjay Phadke In-Reply-To: <20220113171726.1669216-1-angus@akkea.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/13/2022 9:17 AM, Angus Ainslie wrote: > Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with > DUAL/QUAD SPI > > Changes since v1: > > Updated the name for more suffixes > > Signed-off-by: Angus Ainslie > --- > drivers/mtd/spi/spi-nor-ids.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c > index b551ebd75e..3bd0ded443 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > }, > + { > + INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > + }, Shouldn't this be w25q16jvm, which seems to be unofficial convention for *-DTR parts? I was looking for naming convention for another Winbond part - https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/ > { > INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64, > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |