From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 25 Sep 2017 10:34:21 +0200 Subject: [U-Boot] Makefile: Update minimum dtc version to 1.4.3 In-Reply-To: References: <20170923125608.GX30205@bill-the-cat> <084593b9-236f-5c23-5f76-a08a37b01db8@gmail.com> <20170923161033.GY30205@bill-the-cat> <20170924032236.GF30205@bill-the-cat> <5c7ac34d-50fb-73d4-3495-c0e5033d9591@gmail.com> <20170924113613.GG30205@bill-the-cat> <20170924125257.GI30205@bill-the-cat> <1ea0eadf-e0ac-20b0-0a10-3b495ad04c55@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/25/2017 04:14 AM, Simon Glass wrote: > Hi Marek, > > On 24 September 2017 at 07:05, Marek Vasut wrote: >> On 09/24/2017 02:52 PM, Tom Rini wrote: >>> On Sun, Sep 24, 2017 at 02:07:27PM +0200, Marek Vasut wrote: >>>> On 09/24/2017 01:36 PM, Tom Rini wrote: >>>>> On Sun, Sep 24, 2017 at 10:28:18AM +0200, Marek Vasut wrote: >>>>>> On 09/24/2017 05:22 AM, Tom Rini wrote: >>>>>>> On Sat, Sep 23, 2017 at 09:07:02PM -0500, Robert Nelson wrote: >>>>>>>> On Sat, Sep 23, 2017 at 8:49 PM, Bin Meng wrote: >>>>>>>>> Hi Tom, >>>>>>>>> >>>>>>>>> On Sun, Sep 24, 2017 at 12:10 AM, Tom Rini wrote: >>>>>>>>>> On Sat, Sep 23, 2017 at 03:04:39PM +0200, Marek Vasut wrote: >>>>>>>>>>> On 09/23/2017 02:56 PM, Tom Rini wrote: >>>>>>>>>>>> On Sat, Sep 23, 2017 at 12:39:44PM +0200, Marek Vasut wrote: >>>>>>>>>>>>> On 09/22/2017 04:20 PM, Tom Rini wrote: >>>>>>>>>>>>>> On Fri, Sep 15, 2017 at 01:15:25PM -0400, Tom Rini wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> With support for overlays and calling the -@ flag to dtc we need to have >>>>>>>>>>>>>>> at least 1.4.3 available now. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Cc: Simon Glass >>>>>>>>>>>>>>> Reported-by: Stephen Warren >>>>>>>>>>>>>>> Signed-off-by: Tom Rini >>>>>>>>>>>>>> >>>>>>>>>>>>>> Applied to u-boot/master, thanks! >>>>>>>>>>>>> >>>>>>>>>>>>> Debian still only has 1.4.2 even in unstable, so u-boot/master no longer >>>>>>>>>>>>> builds on any debian system. >>>>>>>>>>>> >>>>>>>>>>>> Then perhaps we need to mirror the kernel and provide / build dtc, but >>>>>>>>>>>> allow for people to override it. >>>>>>>>>>> >>>>>>>>>>> What about allowing old DTC version if DTOs are not in use ? >>>>>>>>>> >>>>>>>>>> If you can re-work the logic for that, sure, thanks! >>>>>>>>>> >>>>>>>>> >>>>>>>>> Ubuntu 16.04 LTS is still at dtc v1.4.0, so it's broken there too. >>>>>>>> >>>>>>>> Maybe it's just time to embed a copy of dtc into u-boot (like the >>>>>>>> kernel, especially since we use so many features...)? >>>>>>> >>>>>>> That is my intention at this point, and I'm testing a small series to do >>>>>>> that now (the last pain point looks to have been the patch that allows >>>>>>> 'DTC' to be over-ridden for FreeBSD). >>>>>> >>>>>> cfr my comment about vendoring , I'd really hate to go down that path. >>>>>> Chrome does that and look what came out of it -- outdated patched >>>>>> packages in the chrome codebase, with debian trying hard to unbundle >>>>>> that stuff again. >>>>> >>>>> Yes, but we're going to do it all the same. We're tied to some of the >>>>> tools we need and vendors aren't keeping pace with them either. dtc >>>>> 1.4.0 (Ubuntu 16.04) is from 2013. dtc 1.4.3 is from last December. >>>> >>>> The new DTC version is only mandated by DTO support, which is not used >>>> by anyone to my knowledge at this point. Whoever wants to use DTO, >>>> should have new enough DTC and I'm fine with the build failing if they >>>> don't. >>> >>> Why yes, there is a chicken-and-egg problem with DTO support and >>> adoption. Happily, Google has picked it up as part of how things are to >>> be done with Android 8 so it should finally see wider adoption. >>> >> The most important part of my reply was deleted, so let me repost it here: >> >> This heavy-handed approach of imposing custom DTC build on everyone >> because of a feature noone uses is awful and I disagree with it. If >> there is a version check for DTC for builds with and without DTO, fine, >> I can live with that. >> >> But bundling DTC only because of unused functionality, NAK. > > Yes I suppose that is a bit painful. > > Perhaps we should add a Makefile option (like we do with BUILD_ROM) to > enable DTO (and require a certain dtc). That flag can be set with > travis, but off by default. Yes, agreed, that was my suggestion all along. > Regards, > Simon > -- Best regards, Marek Vasut