From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A60C433EF for ; Tue, 16 Nov 2021 00:44:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D07D60EC0 for ; Tue, 16 Nov 2021 00:44:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D07D60EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 45AA1837BE; Tue, 16 Nov 2021 01:43:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a0TlsFHE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1A412837BE; Tue, 16 Nov 2021 01:43:56 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 66947837B2 for ; Tue, 16 Nov 2021 01:43:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82d.google.com with SMTP id o17so17423530qtk.1 for ; Mon, 15 Nov 2021 16:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=su6eLfXJeziHh/VYIE66n9Rzut5wm9lMe8Avd1g7RGo=; b=a0TlsFHEJhQuvvd1jjukg8ZNJLNtOR1NYAvTTXwInmaisP8hR69oK6qfJPQKA8lnCu 7uL2bqAekuhkkpTu4sGB0Bw5gHScQiY8ROnL/UHHBIryJhVverSm157Z0UgQMbSxca3F Kkcwj067kWAEaGyunhBdCkXBG6ZUZ6A/Wx6P/Nu8V1dIHTDQRgY2ojiurujuEcOqxAXT Eq6cmA1pb67tk/fPU6k9fTmqgxzOhAMY5Z9yZ1bKN4RPSt3tUwP/GRnUXK0ydpMT6mMK 0LMrlT7h9WfCa38N4Dbaq4oH/06FKTV1XPrkU5EaBZIA73Nk1sW08gjy/nI/cIoJhuh8 PyEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=su6eLfXJeziHh/VYIE66n9Rzut5wm9lMe8Avd1g7RGo=; b=HOFr0Zc+5xCecNAdTHNYYFgRz7Z8j30SPReeEoes/pIFd6c/8L63Smtbenv0aqqWGc NvoyD33qbE9hq+1SHfDqlA4HtQ0hxQvufsx40xWqSIFoHXWD9aLmdsYMCsuOIx5qSISz 8X8KVYaIoRunhjw+A2NexayxBGZVyAFgMXyExVgZxmTBmIems0EgE8LVGaj5039Y2HG8 6WQdxqPJoCqURtoChxVelAuci6hUFSbLBTcrxlbJnWX8s1ipya6VsCGVNC9/urH1qA6D hTCmWdZfYHmVXEkHMxsgd5mk6fH94UR6ZD9YS6JifcGrbu22XB4O8G8qJLFuyELsa88d AfKA== X-Gm-Message-State: AOAM533R/vlM89upHV301ujDW5Ln7z5v75hNd++A5V/kGggrcgsaN8pz RarUpGbRB1OAS6gHaIAAxO0= X-Google-Smtp-Source: ABdhPJx+5yTFnc1DEcC/Y/tT1BkhZUWytL9qP0RGFkkeHUEp3ML7Vl+1xII2KfbzgiEy+3eP9r1G8Q== X-Received: by 2002:a05:622a:11d0:: with SMTP id n16mr3394318qtk.111.1637023431278; Mon, 15 Nov 2021 16:43:51 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.googlemail.com with ESMTPSA id v16sm7372841qkj.93.2021.11.15.16.43.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Nov 2021 16:43:50 -0800 (PST) Subject: Re: [PATCH] drivers: musb_gadget: Save endpoint desc to usb_ep->desc To: qianfanguijin@qq.com, u-boot@lists.denx.de Cc: lukma@denx.de, qianfan Zhao References: From: Sean Anderson Message-ID: Date: Mon, 15 Nov 2021 19:43:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11/15/21 7:30 PM, qianfanguijin@qq.com wrote: > From: qianfan Zhao > > Fix fastboot flash bug. > > If the downloading file size is equal to the partition size, "fastboot > flash" can't work, at least in sunxi platform, because used an > uninitalized point: ep->desc. > > This patch also fixed 'data abort' bug in am335x platform. > > Reproduce: fastboot flash loader1 spl/sunxi-spl.bin. > > Signed-off-by: qianfan Zhao > --- > drivers/usb/musb-new/musb_gadget.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/musb-new/musb_gadget.c b/drivers/usb/musb-new/musb_gadget.c > index 1fef00b292..7cca92b970 100644 > --- a/drivers/usb/musb-new/musb_gadget.c > +++ b/drivers/usb/musb-new/musb_gadget.c > @@ -1188,6 +1188,7 @@ static int musb_gadget_enable(struct usb_ep *ep, > } else > musb_ep->dma = NULL; > > + musb_ep->end_point.desc = desc; > musb_ep->desc = desc; > musb_ep->busy = 0; > musb_ep->wedged = 0; > @@ -1245,9 +1246,7 @@ static int musb_gadget_disable(struct usb_ep *ep) > } > > musb_ep->desc = NULL; > -#ifndef __UBOOT__ > musb_ep->end_point.desc = NULL; > -#endif > > /* abort all pending DMA and requests */ > nuke(musb_ep, -ESHUTDOWN); > Reviewed-by: Sean Anderson