From: Matthias Brugger <mbrugger@suse.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 1/2] arm: dts: bcm283x: Allow UARTs to work before relocation
Date: Thu, 14 May 2020 10:56:02 +0200 [thread overview]
Message-ID: <a487fbb6-bf81-e8f5-89a7-ed3ea3af21aa@suse.com> (raw)
In-Reply-To: <20200415195949.GG12111@bill-the-cat>
On 15/04/2020 21:59, Tom Rini wrote:
> On Tue, Apr 14, 2020 at 08:23:10PM -0600, Simon Glass wrote:
>> Hi,
>>
>> On Sun, 22 Mar 2020 at 21:16, Simon Glass <sjg@chromium.org> wrote:
>>>
>>> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
>>> the UARTs do not correctly select the pinconfig to enable the UART pins.
>>> Fix this so that the U-Boot banner is printed.
>>>
>>> This fixes serial output on rpi_3b_32b with the following config.txt
>>> options:
>>>
>>> enable_uart=1
>>> gpu_freq=250
>>>
>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>>> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
>>> ---
>>>
>>> Changes in v2:
>>> - Update commit message
>>>
>>> arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>
>> Any thoughts on this series? At present all my lab tests fail.
>
> I don't know if the problem is my firmware is too old (and so works) or
> your firmware is too old (and so fails) or if there's some
> phase-of-the-moon problem. So while I'd like to know _why_ my 3B is
> fine and yours is not, we should just take this I suppose.
>
I agree with Tom, we should try to find out what's the problem. Do you know
which version (e.g. git commit or which version of rasbian etc) of the RPi FW
you are using? If not, can you provide me with the md5sum's so that I can try to
reproduce this.
Regards,
Matthias
next prev parent reply other threads:[~2020-05-14 8:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 3:15 [PATCH v2 1/2] arm: dts: bcm283x: Allow UARTs to work before relocation Simon Glass
2020-03-23 3:15 ` [PATCH v2 2/2] arm: bcm283x: serial: Move ofdata reading to probe() method Simon Glass
2020-05-04 15:08 ` Matthias Brugger
2020-04-15 2:23 ` [PATCH v2 1/2] arm: dts: bcm283x: Allow UARTs to work before relocation Simon Glass
2020-04-15 19:59 ` Tom Rini
2020-04-29 20:11 ` Simon Glass
2020-04-30 9:37 ` Matthias Brugger
2020-05-14 8:56 ` Matthias Brugger [this message]
2020-05-14 13:49 ` Simon Glass
2020-06-02 13:46 ` Simon Glass
2020-05-04 15:08 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a487fbb6-bf81-e8f5-89a7-ed3ea3af21aa@suse.com \
--to=mbrugger@suse.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox