From: Dhananjay Phadke <dphadke@linux.microsoft.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Vignesh R <vigneshr@ti.com>,
u-boot@lists.denx.de, kernel@puri.sm
Subject: Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV
Date: Sat, 15 Jan 2022 12:45:09 -0800 [thread overview]
Message-ID: <a4df2e7c-90f7-ca86-2c00-a70afbf13b2f@linux.microsoft.com> (raw)
In-Reply-To: <02560e4c7bbc0be08f7c9d0498dab6db@akkea.ca>
On 1/14/2022 6:04 AM, Angus Ainslie wrote:
>
>>> },
>>> + {
>>> + INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32,
>>> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>> + },
>>
>> Shouldn't this be w25q16jvm, which seems to be unofficial convention for
>> *-DTR parts? I was looking for naming convention for another Winbond
>> part -
>>
>> https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/
>>
>>
>
> Would you like a v3 using this naming convention ?
Sure, let's try to follow this convention, I'm also doing same in my v2
patch.
Regards,
Dhananjay
prev parent reply other threads:[~2022-01-15 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 17:17 [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV Angus Ainslie
2022-01-13 18:30 ` Dhananjay Phadke
2022-01-14 14:04 ` Angus Ainslie
2022-01-15 20:45 ` Dhananjay Phadke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4df2e7c-90f7-ca86-2c00-a70afbf13b2f@linux.microsoft.com \
--to=dphadke@linux.microsoft.com \
--cc=angus@akkea.ca \
--cc=jagan@amarulasolutions.com \
--cc=kernel@puri.sm \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox