From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C15FDC433F5 for ; Sat, 15 Jan 2022 20:45:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C451834F0; Sat, 15 Jan 2022 21:45:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="W1PTMCDY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 45D8C83520; Sat, 15 Jan 2022 21:45:13 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by phobos.denx.de (Postfix) with ESMTP id 4A7AB83458 for ; Sat, 15 Jan 2022 21:45:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dphadke@linux.microsoft.com Received: from [192.168.86.154] (unknown [50.47.106.53]) by linux.microsoft.com (Postfix) with ESMTPSA id 4F6A820B83D8; Sat, 15 Jan 2022 12:45:09 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4F6A820B83D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1642279509; bh=9yOewovEZTao6yJZEmaSYVduu58V8odT2lDdicZnO40=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=W1PTMCDYZakb2YqufEHJhJVwNIWDpaeJpT9iCTqXbS/NnHIInj++cR05bCt1fYeC0 2BiNEEpHGB6RofwVth/ayIOFjF02u/4LVH1Fbqg2kmMKdGA1K4AU0xY3vk91RP+MBW beHIxFzOQzlUAJJX6LByLMaRlNBcvp6TFx8D90Pk= Message-ID: Date: Sat, 15 Jan 2022 12:45:09 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV Content-Language: en-US To: Angus Ainslie Cc: Jagan Teki , Vignesh R , u-boot@lists.denx.de, kernel@puri.sm References: <20220113171726.1669216-1-angus@akkea.ca> <02560e4c7bbc0be08f7c9d0498dab6db@akkea.ca> From: Dhananjay Phadke In-Reply-To: <02560e4c7bbc0be08f7c9d0498dab6db@akkea.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/14/2022 6:04 AM, Angus Ainslie wrote: > >>>       }, >>> +    { >>> +        INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024,  32, >>> +            SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | >>> +            SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) >>> +    }, >> >> Shouldn't this be w25q16jvm, which seems to be unofficial convention for >> *-DTR parts? I was looking for naming convention for another Winbond >> part - >> >> https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/ >> >> > > Would you like a v3 using this naming convention ? Sure, let's try to follow this convention, I'm also doing same in my v2 patch. Regards, Dhananjay