* [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV
@ 2022-01-13 17:17 Angus Ainslie
2022-01-13 18:30 ` Dhananjay Phadke
0 siblings, 1 reply; 4+ messages in thread
From: Angus Ainslie @ 2022-01-13 17:17 UTC (permalink / raw)
To: Jagan Teki; +Cc: Vignesh R, u-boot, kernel, Angus Ainslie
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with
DUAL/QUAD SPI
Changes since v1:
Updated the name for more suffixes
Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
drivers/mtd/spi/spi-nor-ids.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index b551ebd75e..3bd0ded443 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
},
+ {
+ INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+ },
{
INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV
2022-01-13 17:17 [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV Angus Ainslie
@ 2022-01-13 18:30 ` Dhananjay Phadke
2022-01-14 14:04 ` Angus Ainslie
0 siblings, 1 reply; 4+ messages in thread
From: Dhananjay Phadke @ 2022-01-13 18:30 UTC (permalink / raw)
To: Angus Ainslie, Jagan Teki; +Cc: Vignesh R, u-boot, kernel
On 1/13/2022 9:17 AM, Angus Ainslie wrote:
> Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with
> DUAL/QUAD SPI
>
> Changes since v1:
>
> Updated the name for more suffixes
>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
> drivers/mtd/spi/spi-nor-ids.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index b551ebd75e..3bd0ded443 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> },
> + {
> + INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + },
Shouldn't this be w25q16jvm, which seems to be unofficial convention for
*-DTR parts? I was looking for naming convention for another Winbond part -
https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/
> {
> INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV
2022-01-13 18:30 ` Dhananjay Phadke
@ 2022-01-14 14:04 ` Angus Ainslie
2022-01-15 20:45 ` Dhananjay Phadke
0 siblings, 1 reply; 4+ messages in thread
From: Angus Ainslie @ 2022-01-14 14:04 UTC (permalink / raw)
To: Dhananjay Phadke; +Cc: Jagan Teki, Vignesh R, u-boot, kernel
Hi Dhananjay , Jagan,
On 2022-01-13 10:30, Dhananjay Phadke wrote:
> On 1/13/2022 9:17 AM, Angus Ainslie wrote:
>> Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory
>> with
>> DUAL/QUAD SPI
>>
>> Changes since v1:
>>
>> Updated the name for more suffixes
>>
>> Signed-off-by: Angus Ainslie <angus@akkea.ca>
>> ---
>> drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mtd/spi/spi-nor-ids.c
>> b/drivers/mtd/spi/spi-nor-ids.c
>> index b551ebd75e..3bd0ded443 100644
>> --- a/drivers/mtd/spi/spi-nor-ids.c
>> +++ b/drivers/mtd/spi/spi-nor-ids.c
>> @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = {
>> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>> },
>> + {
>> + INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32,
>> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>> + },
>
> Shouldn't this be w25q16jvm, which seems to be unofficial convention
> for
> *-DTR parts? I was looking for naming convention for another Winbond
> part -
>
> https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/
>
Would you like a v3 using this naming convention ?
Thanks
Angus
>> {
>> INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64,
>> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV
2022-01-14 14:04 ` Angus Ainslie
@ 2022-01-15 20:45 ` Dhananjay Phadke
0 siblings, 0 replies; 4+ messages in thread
From: Dhananjay Phadke @ 2022-01-15 20:45 UTC (permalink / raw)
To: Angus Ainslie; +Cc: Jagan Teki, Vignesh R, u-boot, kernel
On 1/14/2022 6:04 AM, Angus Ainslie wrote:
>
>>> },
>>> + {
>>> + INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32,
>>> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>> + },
>>
>> Shouldn't this be w25q16jvm, which seems to be unofficial convention for
>> *-DTR parts? I was looking for naming convention for another Winbond
>> part -
>>
>> https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/
>>
>>
>
> Would you like a v3 using this naming convention ?
Sure, let's try to follow this convention, I'm also doing same in my v2
patch.
Regards,
Dhananjay
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-15 20:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-13 17:17 [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV Angus Ainslie
2022-01-13 18:30 ` Dhananjay Phadke
2022-01-14 14:04 ` Angus Ainslie
2022-01-15 20:45 ` Dhananjay Phadke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox