From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA51BC25B06 for ; Thu, 4 Aug 2022 15:43:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8077B8410C; Thu, 4 Aug 2022 17:43:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="oQlVCv74"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CFEBA84189; Thu, 4 Aug 2022 17:43:37 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by phobos.denx.de (Postfix) with ESMTP id AC40083F37 for ; Thu, 4 Aug 2022 17:43:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=dphadke@linux.microsoft.com Received: from [192.168.87.140] (unknown [50.47.106.71]) by linux.microsoft.com (Postfix) with ESMTPSA id B8AEE20FFD73; Thu, 4 Aug 2022 08:43:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B8AEE20FFD73 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659627813; bh=c029LkFY2xtUawJdYXnH3qYzFLh83jpmepeK4VdsqAg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oQlVCv74PxwYcLa05gfNp4rbKxvB1n55wor02s3ky7O+dWw38X9pmyEHgNhdwZORe /jwFkV0flHEGt5862h2gJrxFcPX/k/Y7hhMgY3z8cl6uSKge2FdUFbokACTTe8/SMS BGYhmWkygu1Juw7nLEOnWyn6Vpil4M+cvOCwk+jA= Message-ID: Date: Thu, 4 Aug 2022 08:43:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] gpio: aspeed: port Linux dt-bindings header file Content-Language: en-US To: Joel Stanley Cc: Ryan Chen , Chia-Wei Wang , Aspeed BMC SW team , Billy Tsai , u-boot@lists.denx.de References: <20220804010229.3298325-1-dphadke@linux.microsoft.com> From: Dhananjay Phadke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/3/2022 7:35 PM, Joel Stanley wrote: > On Thu, 4 Aug 2022 at 01:02, Dhananjay Phadke > wrote: >> >> Ported as is, makes it easier to add readable GPIO definitions >> in DTS files. >> >> Signed-off-by: Dhananjay Phadke >> --- >> include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h >> >> diff --git a/include/dt-bindings/gpio/aspeed-gpio.h b/include/dt-bindings/gpio/aspeed-gpio.h >> new file mode 100644 >> index 0000000000..adab2f56c2 >> --- /dev/null >> +++ b/include/dt-bindings/gpio/aspeed-gpio.h >> @@ -0,0 +1,49 @@ >> +/* SPDX-License-Identifier: GPL-2.0+ */ > > As you mention this is from the kernel, but you forgot to add the > copyright information for the file you copied. I suggest you add: > > Copyright 2022 IBM Corp. It would have been nicer to assert copyrights in kernel source itself, so that it would have been inherited instead of inserting here. For now, will send v3 with just that. Thanks, Dhananjay