Re: [PATCH v8 02/19] pinctrl: nxp: add a pin controller driver based on SCMI pin control protocol

[Marek Vasut <marex@denx.de>]

On 3/25/25 9:06 AM, Peng Fan wrote:

[...]

>>> diff --git a/include/scmi_protocols.h b/include/scmi_protocols.h
>>> index 7abb2a6f36b..279ebbad440 100644
>>> --- a/include/scmi_protocols.h
>>> +++ b/include/scmi_protocols.h
>>> @@ -24,6 +24,7 @@ enum scmi_std_protocol {
>>>    	SCMI_PROTOCOL_ID_SENSOR = 0x15,
>>>    	SCMI_PROTOCOL_ID_RESET_DOMAIN = 0x16,
>>>    	SCMI_PROTOCOL_ID_VOLTAGE_DOMAIN = 0x17,
>>> +	SCMI_PROTOCOL_ID_PINCTRL = 0x19,
>> If this is the IMX specific pinctrl protocol, please make sure to name it
>> accordingly , SCMI_PROTOCOL_ID_PINCTRL_IMX or something .
> 
> This ID is generic ID, not i.MX specific.
> 
> i.MX SCMI pinctrl follows ARM SCMI spec, but i.MX pinctrl bindings
> are different compared with ARM SCMI generic pinconf bindings, so we
> need a separate driver for i.MX.
But then, why is it using the same protocol ID ?

And I feel I asked this question multiple times now, please do include 
this information in the commit message .