public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: pro@denx.de
To: Stefano Babic <sbabic@denx.de>, u-boot@lists.denx.de
Cc: Andre Przywara <andre.przywara@arm.com>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Heiko Schocher <hs@denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Konstantin Porotchkin <kostap@marvell.com>,
	Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
	Matthias Winker <matthias.winker@de.bosch.com>,
	Michal Simek <michal.simek@xilinx.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	Navin Sankar Velliangiri <navin@linumiz.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Oleh Kravchenko <oleg@kaa.org.ua>, Simon Glass <sjg@chromium.org>,
	Sinthu Raja <sinthu.raja@ti.com>,
	"Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
Subject: Re: [PATCH v3] bosch: Add initial board support for ACC
Date: Thu, 21 Apr 2022 18:48:18 +0200	[thread overview]
Message-ID: <a855e10250cc6019032f6e29a9063bbd@denx.de> (raw)
In-Reply-To: <d12f3cda-6e08-1dfb-4a69-575192ab0bce@denx.de>

Hi Stefano,

On 2022-04-21 16:53, Stefano Babic wrote:
> Hi Philip,
> 
> Ci is still broken:
> 
> On 19.04.22 16:44, Philip Oberfichtner wrote:
>> The Bosch ACC (Air Center Control) Board is based on the i.MX6D.
>> 

[...]

>> +/* Ethernet */
>> +#ifdef CONFIG_FEC_MXC
>> +#define CONFIG_FEC_MXC_PHYADDR 0
>> +#define CONFIG_FEC_XCV_TYPE    RMII
> 
> Reason is this one.
> 
> I wonder myself why this is required - I set this a lot of time
> *before* the switch to DM, but then the connection type is set in DT
> and this is not required anymore. Are you sure you need it ?

Thanks for the hint. Will be removed in V4.

Best regards,
Philip

> 
> Regards,
> Stefano
> 
>> +#endif
>> +
>> +/* SPL */
>> +#ifdef CONFIG_SPL
>> +#include "imx6_spl.h"
>> +
>> +#ifdef CONFIG_SPL_BUILD
>> +#define CONFIG_SYS_FSL_USDHC_NUM 2
>> +
>> +#ifdef CONFIG_SYS_BOOT_EMMC
>> +
>> +/* Boot from eMMC */
>> +#define CONFIG_SYS_FSL_ESDHC_ADDR 1
>> +
>> +#else
>> +
>> +/* Boot from SD-card */
>> +#  define CONFIG_SYS_FSL_ESDHC_ADDR	0
>> +
>> +#endif
>> +
>> +#endif
>> +#endif
>> +
>> +#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
>> +#define CONFIG_MXC_USB_PORTSC            (PORT_PTS_UTMI | 
>> PORT_PTS_PTW)
>> +#define CONFIG_MXC_USB_FLAGS             0
>> +#define CONFIG_USB_MAX_CONTROLLER_COUNT  1	/* Enabled USB controller 
>> number */
>> +
>> +#endif /* __IMX6Q_ACC_H */

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-22 Fax: +49-8142-66989-80    Email: pro@denx.de
=====================================================================

      reply	other threads:[~2022-04-21 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 14:44 [PATCH v3] bosch: Add initial board support for ACC Philip Oberfichtner
2022-04-21 14:53 ` Stefano Babic
2022-04-21 16:48   ` pro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a855e10250cc6019032f6e29a9063bbd@denx.de \
    --to=pro@denx.de \
    --cc=andre.przywara@arm.com \
    --cc=christianshewitt@gmail.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=hs@denx.de \
    --cc=jagan@amarulasolutions.com \
    --cc=kostap@marvell.com \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=matthias.winker@de.bosch.com \
    --cc=michal.simek@xilinx.com \
    --cc=narmstrong@baylibre.com \
    --cc=navin@linumiz.com \
    --cc=oleg@kaa.org.ua \
    --cc=paul.liu@linaro.org \
    --cc=sbabic@denx.de \
    --cc=sinthu.raja@ti.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox