From: Marek Vasut <marex@denx.de>
To: Patrice CHOTARD <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
u-boot@lists.denx.de
Cc: U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>,
Lukasz Majewski <lukma@denx.de>
Subject: Re: [Uboot-stm32] [PATCH] dfu: Make DFU virtual backend SPL friendly
Date: Thu, 8 Dec 2022 14:55:15 +0100 [thread overview]
Message-ID: <a868016a-e9cd-e47a-ccc1-6588686ea6c5@denx.de> (raw)
In-Reply-To: <35330e71-f6d5-7a05-c1a9-51e3b9ecc488@foss.st.com>
On 12/8/22 14:53, Patrice CHOTARD wrote:
>
>
> On 12/8/22 14:27, Marek Vasut wrote:
>> On 12/8/22 09:19, Patrice CHOTARD wrote:
>>> Hi Marek
>>
>> Hello Patrice,
>>
>>> I am preparing a STM32 pull request which includes this series
>>>
>>> https://patchwork.ozlabs.org/project/uboot/patch/20221206023515.113556-1-marex@denx.de/
>>>
>>> We got a DFU compilation issue with this series :
>>>
>>> arm: + stm32mp15_dhcom_basic
>>> +/usr/lib/python3/dist-packages/setuptools/dist.py:473: UserWarning: Normalizing '2023.01' to '2023.1'
>>> + warnings.warn(
>>> +arm-linux-gnueabi-ld.bfd: drivers/dfu/dfu.o: in function `dfu_fill_entity':
>>> +drivers/dfu/dfu.c:548: undefined reference to `dfu_fill_entity_virt'
>>> +make[2]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1
>>> +make[1]: *** [Makefile:2071: spl/u-boot-spl] Error 2
>>> +make: *** [Makefile:177: sub-make] Error 2
>>> arm: + stm32mp15_dhcor_basic
>>> +/usr/lib/python3/dist-packages/setuptools/dist.py:473: UserWarning: Normalizing '2023.01' to '2023.1'
>>> + warnings.warn(
>>> +arm-linux-gnueabi-ld.bfd: drivers/dfu/dfu.o: in function `dfu_fill_entity':
>>> +drivers/dfu/dfu.c:548: undefined reference to `dfu_fill_entity_virt'
>>> +make[2]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1
>>> +make[1]: *** [Makefile:2071: spl/u-boot-spl] Error 2
>>> +make: *** [Makefile:177: sub-make] Error 2
>>>
>>>
>>> The correct fix is this patch below which is currently in your usb/master branch.
>>> I propose to take this patch in my pull request (available today or tomorrow) to make GitLab Ci tests happy.
>>>
>>> Are you OK ?
>>
>> I still have one more patch to pick/review and then I'll send USB MR.
>> I can ask Tom to pick it before the STM MR at which point it should all be fine ?
>
> Ok, perfect.
> I will put an additional information indicating the dependencies between the STM32 pull request and the USB one.
Thank you.
The USB MR is now in the CI.
prev parent reply other threads:[~2022-12-08 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 10:42 [PATCH] dfu: Make DFU virtual backend SPL friendly Patrick Delaunay
2022-12-04 18:55 ` Marek Vasut
2022-12-08 8:19 ` [Uboot-stm32] " Patrice CHOTARD
2022-12-08 13:27 ` Marek Vasut
2022-12-08 13:53 ` Patrice CHOTARD
2022-12-08 13:55 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a868016a-e9cd-e47a-ccc1-6588686ea6c5@denx.de \
--to=marex@denx.de \
--cc=lukma@denx.de \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox