public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	sbabic@denx.de, festevam@gmail.com, trini@konsulko.com
Subject: Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE
Date: Tue, 7 Jun 2022 20:26:09 +0300	[thread overview]
Message-ID: <a86ea9ea-6633-474a-88fe-9fff90c1e4eb@gmail.com> (raw)
In-Reply-To: <652ebe3d-48a3-9c70-a21a-739541a73803@denx.de>

On 06/06/2022 17:07, Marek Vasut wrote:
> On 6/3/22 09:17, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> i.MX8M use FIT image, not RAW image. And to support binman symbols,
>> u_boot_any could be optimized if RAW image is not selected, otherwise
>> there will be build failure. So not select SPL_RAW_DEVICE
> 
> Is it RAW device/image or RAM device/image ? There seem to be some 
> confusion here. It also seems this might break start of U-Boot by JTAG 
> upload, right ?

The previous patch disables SPL_RAW_IMAGE_SUPPORT for i.MX8M boards
(already disabled for this), this one disables SPL_RAM_DEVICE (was only
enabled for this). Both need to be disabled for this series in its
current form to avoid a binman symbol-related error, but this commit
message suffers from being copy-paste of the previous one.

I don't understand the SPL details much. But I see in spl/spl_ram.c that
CONFIG_SPL_RAM_DEVICE associates BOOT_DEVICE_RAM with a function, and
running 'git grep' for those doesn't turn up anything related to i.MX or
this board. So I guess RAM_DEVICE is actually unused/unusable here and
disabling it won't break anything.

  reply	other threads:[~2022-06-07 17:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  7:17 [PATCH 0/8] arm64: binman: use binman symbols for imx Peng Fan (OSS)
2022-06-03  6:37 ` Peng Fan
2022-06-03  7:17 ` [PATCH 1/8] spl: Kconfig: not select SPL_RAW_IMAGE_SUPPORT for i.MX8M Peng Fan (OSS)
2022-06-03 12:19   ` Tom Rini
2022-06-04 11:49   ` Alper Nebi Yasak
2022-06-03  7:17 ` [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE Peng Fan (OSS)
2022-06-04 11:49   ` Alper Nebi Yasak
2022-06-06 14:07   ` Marek Vasut
2022-06-07 17:26     ` Alper Nebi Yasak [this message]
2022-06-07 18:11       ` Marek Vasut
2022-06-07 20:54         ` Alper Nebi Yasak
2022-06-07 22:54           ` Marek Vasut
2022-06-10 15:51             ` Alper Nebi Yasak
2022-06-11 10:09               ` Marek Vasut
2022-06-03  7:17 ` [PATCH 3/8] arm: dts: imx8m: update binman ddr firmware node name Peng Fan (OSS)
2022-06-04 11:50   ` Alper Nebi Yasak
2022-06-03  7:17 ` [PATCH 4/8] armv8: u-boot-spl.lds: mark __image_copy_start as symbol Peng Fan (OSS)
2022-06-04 11:50   ` Alper Nebi Yasak
2022-06-03  7:17 ` [PATCH 5/8] ddr: imx8m: helper: load ddr firmware according to binman symbols Peng Fan (OSS)
2022-06-04 11:50   ` Alper Nebi Yasak
2022-06-03  7:17 ` [PATCH 6/8] arm: dts: imx8m: shrink ddr firmware size to actual file size Peng Fan (OSS)
2022-06-04 11:50   ` Alper Nebi Yasak
2022-06-03  7:17 ` [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS) Peng Fan (OSS)
2022-06-04 11:50   ` Alper Nebi Yasak
2022-06-10 16:47     ` Alper Nebi Yasak
2022-06-11 10:32       ` Peng Fan (OSS)
2022-06-11 12:44         ` Alper Nebi Yasak
2022-06-13  2:34           ` Peng Fan (OSS)
2022-06-14 21:20             ` Alper Nebi Yasak
2022-06-14 23:25               ` Peng Fan
2022-06-18 12:24                 ` Alper Nebi Yasak
2022-06-13  2:31         ` Peng Fan (OSS)
2022-06-14 21:01           ` Alper Nebi Yasak
2022-06-03  7:17 ` [PATCH 8/8] imx: imx8mm-icore: migrate to use BINMAN Peng Fan (OSS)
2022-06-04 11:50   ` Alper Nebi Yasak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a86ea9ea-6633-474a-88fe-9fff90c1e4eb@gmail.com \
    --to=alpernebiyasak@gmail.com \
    --cc=festevam@gmail.com \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox