From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3150EC43334 for ; Tue, 7 Jun 2022 17:26:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 71CB883608; Tue, 7 Jun 2022 19:26:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a9G4xrfP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EB644802F3; Tue, 7 Jun 2022 19:26:17 +0200 (CEST) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 37109802F3 for ; Tue, 7 Jun 2022 19:26:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x634.google.com with SMTP id n10so36630539ejk.5 for ; Tue, 07 Jun 2022 10:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jP2xLNsKLTZ3Nwktds9sFqMIRJahWfs2aHHpZKGqq1o=; b=a9G4xrfPmrK6els92fOWEyqfJTUE7HCuNsGe/53iG6eR+5gXYHE4yE+cL/7ipqY8qz 0JLBqIxIdvUwlmlOuGK14IqMpI1KLsRjoFo0HS7YwFg8NNcAU02m14GSlTBHgY9j/iI4 vsr14mrMzaYYNpHzWOJ4dNxyTQr2PSjDqPfgI8OTFQ0D3Db7m6D8woHsYTCaC+oXL7QA Alxf8NlX0RWDYTG5/LqQDMQDEv/FZUUOpFirjApjExppdUC4g15fSGOFptj5SIUt1J26 pLc5iYsR2wVMwBjK6jzCCjqIkODX3Ik8etpahl9+ndlrTuTnjpJ2e/EVCs+t3cDrI2x8 /Dwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jP2xLNsKLTZ3Nwktds9sFqMIRJahWfs2aHHpZKGqq1o=; b=bl1ftybjkPbUrsnZYwoRII76kKzF8zC1062YiphIU69D5ND8LmW9LWCrpD8K2oMkr1 Blvgri30eniPm3l0NRsVHkBRb6uy//WL7R/M1QuCLbUyKE+ixmwBAuHpAT9S4ITQCHBw joDnlWWJAMQ805YeigVFw9xh9eCrzFulKy7JmytaAx1s0A7KA/OMXXoda7WYJZ1ETugL ew4qrvuY1/ImPC/SPQbD8L6gbD3BaTXHA6W+N7QF0A0BFN2hvORc3MZCijehcoU1ZcgG Ifa5FQeEtC5vjcAcSSSKDa1u+7F9cWWHwEjvCZviJFNXItJDiCFQp0GF2soBeAF18pE2 SAjA== X-Gm-Message-State: AOAM533omnWWoeECYPq4mt/1eDJ6y0OTtQtvZynlWa6I+yFnchtxvOVs YuX9gw9SxC/u+tsbt0lapYA= X-Google-Smtp-Source: ABdhPJyyEQ1uIgez25iXYBy5jhM3P6bezFEKlUJGnmphfIZujQogF7Slkf//DDv8ilszgkKhHS93PA== X-Received: by 2002:a17:907:9482:b0:6f5:171d:f7f5 with SMTP id dm2-20020a170907948200b006f5171df7f5mr28632138ejc.68.1654622774667; Tue, 07 Jun 2022 10:26:14 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id fu16-20020a170907b01000b006fe8b3d8cb6sm7929029ejc.62.2022.06.07.10.26.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 10:26:13 -0700 (PDT) Message-ID: Date: Tue, 7 Jun 2022 20:26:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE Content-Language: en-US To: Marek Vasut Cc: u-boot@lists.denx.de, Peng Fan , "Peng Fan (OSS)" , sbabic@denx.de, festevam@gmail.com, trini@konsulko.com References: <20220603071715.15212-1-peng.fan@oss.nxp.com> <20220603071715.15212-3-peng.fan@oss.nxp.com> <652ebe3d-48a3-9c70-a21a-739541a73803@denx.de> From: Alper Nebi Yasak In-Reply-To: <652ebe3d-48a3-9c70-a21a-739541a73803@denx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 06/06/2022 17:07, Marek Vasut wrote: > On 6/3/22 09:17, Peng Fan (OSS) wrote: >> From: Peng Fan >> >> i.MX8M use FIT image, not RAW image. And to support binman symbols, >> u_boot_any could be optimized if RAW image is not selected, otherwise >> there will be build failure. So not select SPL_RAW_DEVICE > > Is it RAW device/image or RAM device/image ? There seem to be some > confusion here. It also seems this might break start of U-Boot by JTAG > upload, right ? The previous patch disables SPL_RAW_IMAGE_SUPPORT for i.MX8M boards (already disabled for this), this one disables SPL_RAM_DEVICE (was only enabled for this). Both need to be disabled for this series in its current form to avoid a binman symbol-related error, but this commit message suffers from being copy-paste of the previous one. I don't understand the SPL details much. But I see in spl/spl_ram.c that CONFIG_SPL_RAM_DEVICE associates BOOT_DEVICE_RAM with a function, and running 'git grep' for those doesn't turn up anything related to i.MX or this board. So I guess RAM_DEVICE is actually unused/unusable here and disabling it won't break anything.