Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS)

Alper Nebi Yasak
2022-06-11T12:47:19Z

On 11/06/2022 13:32, Peng Fan (OSS) wrote:
> 在 2022/6/11 0:47, Alper Nebi Yasak 写道:
>> I have sent a patch [1] that fixes the build error mentioned here, which
>> should be used instead of this patch. Please:
>>
>> - Rebase on top of that series [1]
>> - Maybe drop config changes in 1/8 and 2/8 (they're now unnecessary)
>> - Disable CONFIG_SPL/TPL/VPL_BINMAN_SYMBOLS for i.MX8M boards
>> - Change the if statement to if (IS_ENABLED(CONFIG_BINMAN)) in patch 5/8
>
> This not work, BINMAN has been enabled for packing images, but we have
> not generated some i.MX binman symbols
> for getting exact blob size. So I use binman symbols to get exact blob
> size in this patchset.

CONFIG_IS_ENABLED(BINMAN) doesn't work, but IS_ENABLED(CONFIG_BINMAN)
worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send you
a git branch if you want?

> Thanks,
> Peng.
>
>> - Drop this patch 7/8