Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE

Alper Nebi Yasak
2022-06-07T17:26:23Z

On 06/06/2022 17:07, Marek Vasut wrote:
> On 6/3/22 09:17, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> i.MX8M use FIT image, not RAW image. And to support binman symbols,
>> u_boot_any could be optimized if RAW image is not selected, otherwise
>> there will be build failure. So not select SPL_RAW_DEVICE
>
> Is it RAW device/image or RAM device/image ? There seem to be some
> confusion here. It also seems this might break start of U-Boot by JTAG
> upload, right ?

The previous patch disables SPL_RAW_IMAGE_SUPPORT for i.MX8M boards
(already disabled for this), this one disables SPL_RAM_DEVICE (was only
enabled for this). Both need to be disabled for this series in its
current form to avoid a binman symbol-related error, but this commit
message suffers from being copy-paste of the previous one.

I don't understand the SPL details much. But I see in spl/spl_ram.c that
CONFIG_SPL_RAM_DEVICE associates BOOT_DEVICE_RAM with a function, and
running 'git grep' for those doesn't turn up anything related to i.MX or
this board. So I guess RAM_DEVICE is actually unused/unusable here and
disabling it won't break anything.