From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Andreas_Bie=c3=9fmann?= <andreas@biessmann.org>
Date: Sun, 29 May 2016 01:04:47 +0200
Subject: [U-Boot] [PATCH v2 14/18] at91: mtd: nand: Add dev_warn() to
 correct build error in driver
In-Reply-To: <1462454902-6093-15-git-send-email-sjg@chromium.org>
References: <1462454902-6093-1-git-send-email-sjg@chromium.org>
 <1462454902-6093-15-git-send-email-sjg@chromium.org>
Message-ID: <a8795250-4765-1012-45af-3c19d0bb1e8d@biessmann.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On 05.05.16 15:28, Simon Glass wrote:
> The code does not compile if ECC is enabled.
> 
> Signed-off-by: Andre Renaud <arenaud@bluewatersys.com>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v2: None
> 
>  drivers/mtd/nand/atmel_nand.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> index 8fac824..15958cb 100644
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -20,6 +20,8 @@
>  #include <watchdog.h>
>  #include <linux/mtd/nand_ecc.h>
>  
> +#define dev_warn(dev, msg...)
> +

This change is good in general, but I think the better fix is to use
dev_err() for the uncorrectable error and dev_dbg() for the rest.

Andreas

>  #ifdef CONFIG_ATMEL_NAND_HWECC
>  
>  /* Register access macros */
>