U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <ziyao@disroot.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
	Minda Chen <minda.chen@starfivetech.com>,
	Hal Feng <hal.feng@starfivetech.com>
Cc: Sumit Garg <sumit.garg@kernel.org>, E Shattow <lucent@gmail.com>,
	Marek Vasut <marex@denx.de>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] riscv: dts: jh7110: add bootph-pre-ram for &pllclk
Date: Fri, 18 Apr 2025 13:41:13 +0000	[thread overview]
Message-ID: <aAJWeYJxo2IYwDR_@pie.lan> (raw)
In-Reply-To: <20250330162421.238483-1-heinrich.schuchardt@canonical.com>

On Sun, Mar 30, 2025 at 06:24:21PM +0200, Heinrich Schuchardt wrote:
> Since commit f98cd471f06b ("clk: clk-composite: Resolve parent clock by
> name") the StarFive VisionFive 2 board fails to boot.
> 
> Before that patch the SPL debug UART showed warnings like:
> 
>     clk_register: failed to get pll0_out device (parent of perh_root)
>     clk_register: failed to get pll0_out device (parent of qspi_ref_src)
>     clk_register: failed to get pll0_out device (parent of usb_125m)
>     clk_register: failed to get pll0_out device (parent of gmac_src)
>     clk_register: failed to get pll0_out device (parent of gmac1_gtxclk)
>     clk_register: failed to get pll0_out device (parent of gmac0_gtxclk)
> 
> The &pllclk clock needs to be enabled early.
> 
> Fixes: f98cd471f06b ("clk: clk-composite: Resolve parent clock by name")
> Suggested-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  arch/riscv/dts/jh7110-u-boot.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)

Tested-by: Yao Zi <ziyao@disroot.org>

Sadly this didn't catch up with v2025.04, in which JH7110 SoCs are
broken...

> diff --git a/arch/riscv/dts/jh7110-u-boot.dtsi b/arch/riscv/dts/jh7110-u-boot.dtsi
> index ce7d9e16961..a9e318c4a31 100644
> --- a/arch/riscv/dts/jh7110-u-boot.dtsi
> +++ b/arch/riscv/dts/jh7110-u-boot.dtsi
> @@ -102,6 +102,10 @@
>  	bootph-pre-ram;
>  };
>  
> +&pllclk {
> +	bootph-pre-ram;
> +};
> +
>  &syscrg {
>  	bootph-pre-ram;
>  };
> -- 
> 2.48.1
> 

Thanks,
Yao Zi

      parent reply	other threads:[~2025-04-18 13:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-30 16:24 [PATCH 1/1] riscv: dts: jh7110: add bootph-pre-ram for &pllclk Heinrich Schuchardt
2025-04-08 11:36 ` Leo Liang
2025-04-18 13:41 ` Yao Zi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAJWeYJxo2IYwDR_@pie.lan \
    --to=ziyao@disroot.org \
    --cc=hal.feng@starfivetech.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=lucent@gmail.com \
    --cc=marex@denx.de \
    --cc=minda.chen@starfivetech.com \
    --cc=rick@andestech.com \
    --cc=sumit.garg@kernel.org \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox