From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F95FC369C2 for ; Fri, 25 Apr 2025 08:20:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 969B5810EB; Fri, 25 Apr 2025 10:20:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1E59881E14; Fri, 25 Apr 2025 10:20:55 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 51BCD8059A for ; Fri, 25 Apr 2025 10:20:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS34.andestech.com [10.0.1.134]) by Atcsqr.andestech.com with ESMTPS id 53P8Juj7080687 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Fri, 25 Apr 2025 16:19:56 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS34.andestech.com (10.0.1.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 25 Apr 2025 16:19:56 +0800 Date: Fri, 25 Apr 2025 16:19:50 +0800 From: Leo Liang To: Yao Zi CC: Rick Chen , Tom Rini , Bin Meng , Paul Walmsley , "Palmer Dabbelt" , Anup Patel , Atish Patra , Green Wan , Minda Chen , Simon Glass , "Angelo Dureghello" , Ilias Apalodimas , Heinrich Schuchardt , Subject: Re: [PATCH v2 1/4] riscv: lib: Add a default implementation of board_fdt_blob_setup Message-ID: References: <20250307131344.43762-1-ziyao@disroot.org> <20250307131344.43762-2-ziyao@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250307131344.43762-2-ziyao@disroot.org> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-ClientProxiedBy: ATCPCS33.andestech.com (10.0.1.100) To ATCPCS34.andestech.com (10.0.1.134) X-DKIM-Results: atcpcs34.andestech.com; dkim=none; X-DNSRBL: X-MAIL: Atcsqr.andestech.com 53P8Juj7080687 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Yao, On Fri, Mar 07, 2025 at 01:13:41PM +0000, Yao Zi wrote: > It's common for S-Mode proper U-Boot to retrieve a FDT blob along with > taking control from SBI firmware. Add a weak version of > board_fdt_blob_setup to make use of it by default, avoiding copy-pasting > similar functions among boards. > > Signed-off-by: Yao Zi > Reviewed-by: Leo Yu-Chi Liang > --- > arch/riscv/lib/Makefile | 1 + > arch/riscv/lib/board.c | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > create mode 100644 arch/riscv/lib/board.c > > diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile > index 268116f3757..b33f9c646dd 100644 > --- a/arch/riscv/lib/Makefile > +++ b/arch/riscv/lib/Makefile > @@ -27,6 +27,7 @@ obj-$(CONFIG_$(XPL_)SMP) += smp.o > obj-$(CONFIG_XPL_BUILD) += spl.o > obj-y += fdt_fixup.o > obj-$(CONFIG_$(SPL)CMD_BDI) += bdinfo.o > +obj-$(CONFIG_OF_BOARD) += board.o > > # For building EFI apps > CFLAGS_NON_EFI := -fstack-protector-strong > diff --git a/arch/riscv/lib/board.c b/arch/riscv/lib/board.c > new file mode 100644 > index 00000000000..1630355b2b1 > --- /dev/null > +++ b/arch/riscv/lib/board.c > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * RISC-V-specific handling of firmware FDT > + */ > + > +#include > +#include > + > +DECLARE_GLOBAL_DATA_PTR; > + > +__weak int board_fdt_blob_setup(void **fdtp) > +{ > + if (IS_ENABLED(CONFIG_XPL_BUILD) || !gd->arch.firmware_fdt_addr) > + return -EEXIST; > + > + *fdtp = (void *)gd->arch.firmware_fdt_addr; I could fix the 'CONFIG_XPL_BUILD' check and add casting when merging. Thanks for the patch! Best regards, Leo > + > + return 0; > +}