Re: [PULL] u-boot-riscv/next

[Leo Liang <ycliang@andestech.com>]

On Sun, Jun 08, 2025 at 02:37:04AM +0000, Yao Zi wrote:
> [EXTERNAL MAIL]
> 
> On Thu, Jun 05, 2025 at 02:05:06PM -0600, Tom Rini wrote:
> > On Tue, Jun 03, 2025 at 02:45:21PM +0800, Leo Liang wrote:
> >
> > > Hi Tom,
> > >
> > > The following changes since commit d45b1d4ac94710f88902adc2173d7930700e2869:
> > >
> > >   Merge tag 'u-boot-dfu-next-20250602' of https://source.denx.de/u-boot/custodians/u-boot-dfu into next (2025-06-02 08:43:10 -0600)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://source.denx.de/u-boot/custodians/u-boot-riscv.git next
> > >
> > > for you to fetch changes up to b911af6d60d3be570469b92df751874dc376336b:
> > >
> > >   MAINTAINERS: riscv: cpu: th1520: Assign myself as maintainer (2025-06-03 14:17:46 +0800)
> > >
> > > CI result shows no issue: https://source.denx.de/u-boot/custodians/u-boot-riscv/-/pipelines/26483
> > > ----------------------------------------------------------------
> > > - board: Convert Lichee Pi 4A to use S-Mode proper U-Boot
> > > - RISC-V: configs: Raise SPL_SYS_MALLOC_SIZE to 8 MiB
> > > - driver: Add SD card support to the Beagle-V-Fire
> > > - MAINTAINERS: Add Yao Zi as maintainer for th1520
> > > ----------------------------------------------------------------
> >
> > This introduces a failure to build on microchip_mpfs_icicle currently in
> > -next.
> 
> microchip_mpfs_icicle_defconfig fails to build in u-boot-riscv/next as
> well. Reverting b73971dea9fed ("spi: coreqspi: add xfer function for
> PolarFire SoC") fixes it.
> 
> Seems the patch doesn't adapt the multiple-cs-capable definition of
> dm_slave_plat, which was introduced in commit 34da258bb04 ("spi:
> spi-uclass: Read chipselect and restrict capabilities") in the last
> year. Thus I doubt whether the patch has been built and tested against a
> recent version of U-Boot.
> 

Hi Eoin,

Your patch ("spi: coreqspi: add xfer function for PolarFire SoC")[1] does not pass CI[2].

Could you fix this issue and resend a V3?

Best regards,
Leo

[1] https://patchwork.ozlabs.org/project/uboot/patch/20250529102112.3544972-3-Eoin.Dickson@microchip.com/
[2] https://source.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/1155749#L5205
> 
> > --
> > Tom
> 
> Regards,
> Yao Zi