From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4C2EC83F27 for ; Wed, 16 Jul 2025 08:43:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5AAE2831A1; Wed, 16 Jul 2025 10:43:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A3F83831AC; Wed, 16 Jul 2025 10:43:23 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 398368313B for ; Wed, 16 Jul 2025 10:43:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS34.andestech.com [10.0.1.134]) by Atcsqr.andestech.com with ESMTPS id 56G8goSo072190 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Wed, 16 Jul 2025 16:42:50 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS34.andestech.com (10.0.1.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 16 Jul 2025 16:42:50 +0800 Date: Wed, 16 Jul 2025 16:42:47 +0800 From: Leo Liang To: Conor Dooley CC: , Conor Dooley , Cyril Jean , Tom Rini Subject: Re: [PATCH v1] board: mpfs_icicle: fix board_fit_config_name_match() Message-ID: References: <20250707121333.601067-2-conor@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250707121333.601067-2-conor@kernel.org> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-ClientProxiedBy: ATCPCS33.andestech.com (10.0.1.100) To ATCPCS34.andestech.com (10.0.1.134) X-DKIM-Results: atcpcs34.andestech.com; dkim=none; X-DNSRBL: X-MAIL: Atcsqr.andestech.com 56G8goSo072190 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Jul 07, 2025 at 01:13:33PM +0100, Conor Dooley wrote: > From: Conor Dooley > > The loop in the icicle implementation of board_fit_config_name_match() > runs strtok() to split off the vendor portion of the compatible string > using , as the delimiter. strtok() modifies a string in place, so where > the first config and compatible do not match, the compatible has been > modified by the time the loop hits the second iteration. > Since stringlists in dt land are null separated strings, the nulls > strtok() inserts to replace the delimiter increase the number of strings > in the compatible list. When the second iteration of the loop calls > fdt_stringlist_get(), it gets the vendorless portion of the first > compatible string, rather than the second compatible string. Copy each > compatible before calling strtok() to avoid this problem. > > The temporary string the compatible is copied to is statically > allocated, as attempts to dynamically allocate it at this stage of boot > were met with "alloc space exhausted" errors. > > Fixes: 7c16ebba1ed ("board: mpfs_icicle: implement board_fdt_blob_setup()/board_fit_config_name_match()") > Signed-off-by: Conor Dooley > --- > CC: Conor Dooley > CC: Cyril Jean > CC: Tom Rini > CC: Leo Yu-Chi Liang > CC: u-boot@lists.denx.de > --- > board/microchip/mpfs_icicle/mpfs_icicle.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Leo Yu-Chi Liang