public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marius Dinu <m95d+git@psihoexpert.ro>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Marius Dinu <m95d+git@psihoexpert.ro>
Subject: Re: [PATCH 2/2] timer: Mark this as incompatible with SYS_ARCH_TIMER
Date: Thu, 14 Aug 2025 19:26:47 +0300	[thread overview]
Message-ID: <aJ4OR2rhl6eFV3GE@GRAPHRT> (raw)
In-Reply-To: <20250813205511.3420638-2-trini@konsulko.com>

On Wed, 2025-08-13 14.55.11 +-0600, Tom Rini wrote:
> The timers implemented under SYS_ARCH_TIMER are not part of the TIMER
> framework and thus cannot be enabled at the same time. Express this
> dependency in Kconfig and add a note to the help of SYS_ARCH_TIMER.
> 
> Reported-by: Marius Dinu <m95d+git@psihoexpert.ro>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Marius, I ended up reworking things a bit (and also found part 1/2 of
> this series) but please let me know if you feel this should retain your
> Author and such instead. Thanks!

No need for credits.
I think you should keep the warning message in the Timer drivers menu.
It provides a quick explanation why the menu is empty.

Bugs are reported in this mailing list too?
Thanks!

> ---
>  arch/arm/Kconfig      | 1 +
>  drivers/timer/Kconfig | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 73b4aad28b50..0dba2e2c8567 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -452,6 +452,7 @@ config SYS_ARCH_TIMER
>  	  interface to a timer source on an SoC.
>  	  It is mandatory for ARMv8 implementation and widely available
>  	  on ARMv7 systems.
> +	  This timer driver is incompatible with the DM timer framework.
>  
>  config ARM_SMCCC
>  	bool "Support for ARM SMC Calling Convention (SMCCC)"
> diff --git a/drivers/timer/Kconfig b/drivers/timer/Kconfig
> index cb6fc0e7fda8..2ab4d971dffa 100644
> --- a/drivers/timer/Kconfig
> +++ b/drivers/timer/Kconfig
> @@ -2,6 +2,7 @@ menu "Timer Support"
>  
>  config TIMER
>  	bool "Enable driver model for timer drivers"
> +	depends on !SYS_ARCH_TIMER
>  	depends on DM
>  	help
>  	  Enable driver model for timer access. It uses the same API as
> -- 
> 2.43.0
> 



  reply	other threads:[~2025-08-14 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 20:55 [PATCH 1/2] arm: v7m: Allow SYS_ARCH_TIMER here Tom Rini
2025-08-13 20:55 ` [PATCH 2/2] timer: Mark this as incompatible with SYS_ARCH_TIMER Tom Rini
2025-08-14 16:26   ` Marius Dinu [this message]
2025-08-14 16:40     ` Tom Rini
2025-08-14 18:10       ` Marius Dinu
2025-10-11 18:00         ` Tom Rini
2025-10-14 12:15           ` Marius Dinu
2025-10-11 17:07 ` (subset) [PATCH 1/2] arm: v7m: Allow SYS_ARCH_TIMER here Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJ4OR2rhl6eFV3GE@GRAPHRT \
    --to=m95d+git@psihoexpert.ro \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox