From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6805DCA0EE4 for ; Thu, 14 Aug 2025 18:11:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 946318399D; Thu, 14 Aug 2025 20:10:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=psihoexpert.ro Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=psihoexpert.ro header.i=@psihoexpert.ro header.b="FWzM6F4b"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ED2068399D; Thu, 14 Aug 2025 20:10:57 +0200 (CEST) Received: from mx1.wiredblade.com (mx1.wiredblade.com [162.216.242.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 01DB48399C for ; Thu, 14 Aug 2025 20:10:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=psihoexpert.ro Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=m95d+git@psihoexpert.ro dkim-signature: v=1; a=rsa-sha256; d=psihoexpert.ro; s=dynu; c=relaxed/relaxed; q=dns/txt; h=From:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:In-Reply-To:References; bh=Z2I3aU3KaxsshGq4Chs+eRxaliDJfXGPcZB7yPfIdLc=; b=FWzM6F4bQhwE8tmzzV28nBvWKyRFTzezXOz/gupRZogCHIF76iP8jIi51b/v/WkANxXgWMOoGnqqd8PXCnr198c43VPCIp68oCgx5FUAQ/q22LoSlXS5jeXqHPcio/apZ1Ez7eSPnwOIWG2wVIOvJ36PT3NrQllLmGEmRYdB01D0DxLXLFU56v92S0759/yfksE/KuyXP9KDyblP+pfbWslCJDW5oR/tJJk7iZnG3o6p6estxQwtY60awD GfMyl9QExeURdkpibdXyxO4CJOGggyC/fgFoggiBF5hJS56eTq5XkbESmdpFWughBNV4EDOGmgrRWWJQCWAt8ei7hfHA== Received: from GRAPHRT (188-24-194-92.rdsnet.ro [188.24.194.92]) by mx1.wiredblade.com with ESMTPSA (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256) ; Thu, 14 Aug 2025 18:10:50 +0000 Date: Thu, 14 Aug 2025 21:10:49 +0300 From: Marius Dinu To: Tom Rini Cc: Marius Dinu , u-boot@lists.denx.de Subject: Re: [PATCH 2/2] timer: Mark this as incompatible with SYS_ARCH_TIMER Message-ID: References: <20250813205511.3420638-1-trini@konsulko.com> <20250813205511.3420638-2-trini@konsulko.com> <20250814164021.GM124814@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250814164021.GM124814@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, 2025-08-14 10.40.21 +-0600, Tom Rini wrote: > On Thu, Aug 14, 2025 at 07:26:47PM +0300, Marius Dinu wrote: > > On Wed, 2025-08-13 14.55.11 +-0600, Tom Rini wrote: > > > The timers implemented under SYS_ARCH_TIMER are not part of the TIMER > > > framework and thus cannot be enabled at the same time. Express this > > > dependency in Kconfig and add a note to the help of SYS_ARCH_TIMER. > > > > > > Reported-by: Marius Dinu > > > Signed-off-by: Tom Rini > > > --- > > > Marius, I ended up reworking things a bit (and also found part 1/2 of > > > this series) but please let me know if you feel this should retain your > > > Author and such instead. Thanks! > > > > No need for credits. > > OK. > > > I think you should keep the warning message in the Timer drivers menu. > > It provides a quick explanation why the menu is empty. > > I thought about it, and we don't do anything like that for other > either/or choices, and it's now in the help text itself at least. The > other thing however, is that a few platforms do allow for both, because > they play some games with CFG_SYS_TIMER* defines. So I'm not entirely > sure what to do here. > > > Bugs are reported in this mailing list too? > > Yes. > > -- > Tom With the original patch I only tried to reduce the number of compilation failures. I encounter a lot. I'm no expert and I can only try to fix little things such as this one. I belive some people (like myself) would be confused by an empty menu and would not immediately remember the SYS_ARCH_TIMER in a completely different part of menuconfig. I tried to find configs with both CONFIG_SYS_ARCH_TIMER and CONFIG_TIMER enabled amd I couldn't find any. So it's probably OK to leave the patch as it is and exceptions, if needed, can be added later. PS: I saw your other patches that add dependencies on platform type. Nice work, really needed! Marius