U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marius Dinu <marius@psihoexpert.ro>
To: u-boot@lists.denx.de
Subject: Re: [PATCH] USB OTG: make dwc2 otg driver dependent on Exynos platform
Date: Mon, 4 Aug 2025 12:56:31 +0300	[thread overview]
Message-ID: <aJCDz1uqfUaUkcbD@GRAPHRT> (raw)
In-Reply-To: <20250804094353.28658-1-m95d+git@psihoexpert.ro>

On Mon, 2025-08-04 09.43.53 ++0000, Marius Dinu wrote:
> drivers/usb/gadget/dwc2_udc_otg_phy.c uses s5p_cpu_id,
> which is only defined for Exynos CPUs.
> 
> Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
> ---
>  drivers/usb/gadget/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 46a83141481..deabcb3e51f 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -108,10 +108,11 @@ config USB_GADGET_AT91
>  
>  config USB_GADGET_DWC2_OTG
>  	bool "DesignWare USB2.0 HS OTG controller (gadget mode)"
> +	depends on ARCH_EXYNOS5
>  	select USB_GADGET_DUALSPEED
>  	help
>  	  The Designware USB2.0 high-speed gadget controller
> -	  integrated into many SoCs. Select this option if you want the
> +	  integrated into many Exynos SoCs. Select this option if you want the
>  	  driver to operate in Peripheral mode. This option requires
>  	  USB_GADGET to be enabled.
>  
> -- 
> 2.49.0
> 

PS:
This might be a bug; I can't tell.
Even so, it should be merged to avoid build errors until someone can take
a better look at the driver.


  reply	other threads:[~2025-08-04 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04  9:43 [PATCH] USB OTG: make dwc2 otg driver dependent on Exynos platform Marius Dinu
2025-08-04  9:56 ` Marius Dinu [this message]
2025-08-04 12:42 ` Jonas Karlman
2025-08-05 10:07   ` Marius Dinu
2025-08-05 11:44   ` Marius Dinu
2025-08-11 12:32     ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJCDz1uqfUaUkcbD@GRAPHRT \
    --to=marius@psihoexpert.ro \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox