From: Philip Oberfichtner <pro@denx.de>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: u-boot@lists.denx.de,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Michael Walle <michael@walle.cc>,
Quentin Schulz <quentin.schulz@cherry.de>,
Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v2 1/3] Image size checks: Remove HAS_BOARD_SIZE_LIMIT
Date: Mon, 11 Aug 2025 10:30:22 +0200 [thread overview]
Message-ID: <aJmqHtGYYhFfGNXG@antares> (raw)
In-Reply-To: <eac8672f-e90b-42e9-9efd-d94fcc8c1f17@mailbox.org>
On Thu, Aug 07, 2025 at 03:41:38PM +0200, Marek Vasut wrote:
> On 8/7/25 12:24 PM, Philip Oberfichtner wrote:
> > CONFIG_HAS_BOARD_SIZE_LIMIT is obsolete, if we interpret the value
> > "zero" as "unlimited".
>
> This sentence makes no sense. Is the variable not obsolete if its value is
> non-zero ?
>
> [...]
>
> > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> > index c2aa88f59fb..36eed766d31 100644
> > --- a/lib/efi_loader/Kconfig
> > +++ b/lib/efi_loader/Kconfig
> > @@ -74,7 +74,7 @@ config EFI_SIGNATURE_SUPPORT
> > config EFI_DEBUG_SUPPORT
> > bool "EFI Debug Support"
> > - default y if !HAS_BOARD_SIZE_LIMIT
> > + default y if BOARD_SIZE_LIMIT = 0
> This looks wrong, no board size limit does not imply EFI anything.
>
> And use some common sense and reduce the CC list.
Wouldn't the CC list naturally be large for a patch changing 43
defconfigs?
next prev parent reply other threads:[~2025-08-11 8:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 10:24 [PATCH v2 0/3] Simplify image size checks Philip Oberfichtner
2025-08-07 10:24 ` [PATCH v2 1/3] Image size checks: Remove HAS_BOARD_SIZE_LIMIT Philip Oberfichtner
2025-08-07 13:41 ` Marek Vasut
2025-08-07 16:21 ` Tom Rini
2025-08-07 19:41 ` Marek Vasut
2025-08-07 20:11 ` Tom Rini
2025-08-07 23:15 ` Marek Vasut
2025-08-07 23:24 ` Tom Rini
2025-08-11 8:50 ` Philip Oberfichtner
2025-08-18 9:29 ` Philip Oberfichtner
2025-08-25 8:59 ` Philip Oberfichtner
2025-08-28 21:44 ` Marek Vasut
2025-09-01 9:38 ` Philip Oberfichtner
2025-09-01 19:41 ` Marek Vasut
2025-08-11 8:30 ` Philip Oberfichtner [this message]
2025-08-07 10:24 ` [PATCH v2 2/3] Image size checks: Move all configs in one place Philip Oberfichtner
2025-08-07 10:24 ` [PATCH v2 3/3] Image size checks: Simplify help text Philip Oberfichtner
2025-08-07 13:41 ` Marek Vasut
2025-08-11 8:57 ` Philip Oberfichtner
2025-08-11 10:28 ` Heinrich Schuchardt
2025-08-11 14:25 ` Marek Vasut
2025-08-12 9:51 ` Philip Oberfichtner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJmqHtGYYhFfGNXG@antares \
--to=pro@denx.de \
--cc=marek.vasut@mailbox.org \
--cc=michael@walle.cc \
--cc=mkorpershoek@kernel.org \
--cc=quentin.schulz@cherry.de \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox