* [PATCH v2] pcie: starfive: Remove the redundant print of probe success
@ 2025-09-01 8:24 Hal Feng
2025-09-18 12:06 ` Leo Liang
0 siblings, 1 reply; 2+ messages in thread
From: Hal Feng @ 2025-09-01 8:24 UTC (permalink / raw)
To: Tom Rini, Leo, Simon Glass, Sumit Garg, Fabio Estevam
Cc: Minda Chen, Hal Feng, u-boot
The dev_err() is used incorrectly and we don't need the driver
to state probe success.
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---
drivers/pci/pcie_starfive_jh7110.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/pcie_starfive_jh7110.c b/drivers/pci/pcie_starfive_jh7110.c
index 51aca7359ff..0908ae16b67 100644
--- a/drivers/pci/pcie_starfive_jh7110.c
+++ b/drivers/pci/pcie_starfive_jh7110.c
@@ -292,8 +292,6 @@ static int starfive_pcie_probe(struct udevice *dev)
if (ret)
return ret;
- dev_err(dev, "Starfive PCIe bus probed.\n");
-
return 0;
}
base-commit: e4c8b32d03d7ecffd586b7d33336603ad639d7c0
--
2.43.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pcie: starfive: Remove the redundant print of probe success
2025-09-01 8:24 [PATCH v2] pcie: starfive: Remove the redundant print of probe success Hal Feng
@ 2025-09-18 12:06 ` Leo Liang
0 siblings, 0 replies; 2+ messages in thread
From: Leo Liang @ 2025-09-18 12:06 UTC (permalink / raw)
To: Hal Feng
Cc: Tom Rini, Simon Glass, Sumit Garg, Fabio Estevam, Minda Chen,
u-boot
On Mon, Sep 01, 2025 at 04:24:18PM +0800, Hal Feng wrote:
> The dev_err() is used incorrectly and we don't need the driver
> to state probe success.
>
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
> drivers/pci/pcie_starfive_jh7110.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-18 12:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 8:24 [PATCH v2] pcie: starfive: Remove the redundant print of probe success Hal Feng
2025-09-18 12:06 ` Leo Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox