U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <ziyao@disroot.org>
To: u-boot@lists.denx.de
Cc: Yao Zi <ziyao@disroot.org>, Leo <ycliang@andestech.com>,
	Minda Chen <minda.chen@starfivetech.com>,
	Hal Feng <hal.feng@starfivetech.com>, E Shattow <e@freeshell.de>
Subject: Booting from SD-card on StarFive VisionFive 2 is broken in master
Date: Mon, 20 Oct 2025 10:53:11 +0000	[thread overview]
Message-ID: <aPYUlyni65Ux8xpq@pie> (raw)

Hi there,

While testing the behavior of my previous patch on JH7110 platforms,
it's found that StarFive VisionFive 2 fails to boot from SD-card with
current U-Boot master "a58089ad2e4 (fs: semihosting: Use correct
variable for error check, 2025-10-02)" with messages like

	U-Boot SPL 2025.10-00669-ga58089ad2e41 (Oct 20 2025 - 10:29:30 +0000)
	DDR version: dc2e84f0.
	Trying to boot from MMC2
	spl: partition error
	Error: -38
	SPL: failed to boot from all boot devices
	### ERROR ### Please RESET the board ###

Bisecting shows the failure is introduced by commit 27f617019dd (riscv:
dts: starfive: prune redundant jh7110-common overrides, 2025-09-16),
where the U-Boot devicetree overrides are removed since these have been
in the upstream devicetree.

However, this is not totally true: for mmc0_pins, mmc1_pins, i2c5_pins
and their subnodes, the bootph-pre-ram properties aren't present in the
upstream 6.16 devicetree, and a simple removal seems to break SD card
initialization on StarFive VisionFive2 in SPL stage.

A simple (but obviously not acceptable as it modifies files in
dts/upstream) patch could be found here[1]. Manually adding the
bootph-pre-ram properties back to mmc1_pins and its children fixes the
booting process.

I don't think it's good idea to revert the problematic commit since
several follow-up commits depend on it. Maybe we could bring the
overrides back to arch/riscv/dts/starfive-visionfive2-u-boot.dtsi?

Best regards,
Yao Zi

[1]: https://gist.github.com/ziyao233/0bcce16753b3956a30113cf41631e720

             reply	other threads:[~2025-10-20 10:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 10:53 Yao Zi [this message]
2025-10-20 11:06 ` Booting from SD-card on StarFive VisionFive 2 is broken in master Yao Zi
2025-10-20 12:50   ` E Shattow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPYUlyni65Ux8xpq@pie \
    --to=ziyao@disroot.org \
    --cc=e@freeshell.de \
    --cc=hal.feng@starfivetech.com \
    --cc=minda.chen@starfivetech.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox