public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Cc: trini@konsulko.com, aswin.murugan@oss.qualcomm.com,
	lukma@denx.de, seanga2@gmail.com, casey.connolly@linaro.org,
	neil.armstrong@linaro.org, alexeymin@postmarketos.org,
	u-boot@lists.denx.de, u-boot-qcom@groups.io
Subject: Re: [PATCH v1 1/3] arm: dts: qcs615-ride: Remove unsupported USB clock reference
Date: Fri, 26 Dec 2025 15:52:41 +0530	[thread overview]
Message-ID: <aU5h8TrvG7GALEMc@sumit-xelite> (raw)
In-Reply-To: <20251114063804.3835132-2-balaji.selvanathan@oss.qualcomm.com>

On Fri, Nov 14, 2025 at 12:08:02PM +0530, Balaji Selvanathan wrote:
> Remove GCC_USB3_PRIM_CLKREF_CLK from the USB controller node as it is
> not implemented in the U-Boot clock driver. Keep only the supported
> clocks to avoid clock warnings during boot.

Rather than overriding DT, why can't this be implmented in U-Boot? And
how why it isn't an essential clock for U-Boot operation?

-Sumit

> 
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
>  arch/arm/dts/qcs615-ride-u-boot.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/dts/qcs615-ride-u-boot.dtsi b/arch/arm/dts/qcs615-ride-u-boot.dtsi
> index 68fffc70fcb..d8af124cc27 100644
> --- a/arch/arm/dts/qcs615-ride-u-boot.dtsi
> +++ b/arch/arm/dts/qcs615-ride-u-boot.dtsi
> @@ -11,4 +11,18 @@
>  		      <0x0 0xc0000000 0x0 0xc0000000>,
>  		      <0x1 0x80000000 0x1 0x00000000>;
>  	};
> +	soc@0 {
> +		/* Remove GCC_USB3_PRIM_CLKREF_CLK from usb_1 node to avoid U-Boot clock warnings */
> +		usb_1: usb@a6f8800 {
> +			/delete-property/ clocks;
> +			/delete-property/ clock-names;
> +			/* Keep only the clocks that are implemented in U-Boot clock driver */
> +			clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
> +				 <&gcc GCC_USB30_PRIM_MASTER_CLK>,
> +				 <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>,
> +				 <&gcc GCC_USB30_PRIM_SLEEP_CLK>,
> +				 <&gcc GCC_USB30_PRIM_MOCK_UTMI_CLK>;
> +			clock-names = "cfg_noc", "core", "iface", "sleep", "mock_utmi";
> +		};
> +	};
>  };
> -- 
> 2.34.1
> 

  reply	other threads:[~2025-12-26 10:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14  6:38 [PATCH v1 0/3] Enable USB High-Speed support for QCS615 Balaji Selvanathan
2025-11-14  6:38 ` [PATCH v1 1/3] arm: dts: qcs615-ride: Remove unsupported USB clock reference Balaji Selvanathan
2025-12-26 10:22   ` Sumit Garg [this message]
2026-01-20  4:30     ` Balaji Selvanathan
2026-01-20 12:07       ` Sumit Garg
2025-11-14  6:38 ` [PATCH v1 2/3] clk: qcom: qcs615: Add GCC_AHB2PHY_WEST_CLK clock support Balaji Selvanathan
2025-11-18  8:07   ` neil.armstrong
2025-12-26 10:29   ` Sumit Garg
2025-11-14  6:38 ` [PATCH v1 3/3] phy: qcom: qusb2: Add QCS615 QUSB2 PHY support Balaji Selvanathan
2025-11-18  8:07   ` neil.armstrong
2025-12-26 10:29   ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aU5h8TrvG7GALEMc@sumit-xelite \
    --to=sumit.garg@kernel.org \
    --cc=alexeymin@postmarketos.org \
    --cc=aswin.murugan@oss.qualcomm.com \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=lukma@denx.de \
    --cc=neil.armstrong@linaro.org \
    --cc=seanga2@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox