[PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

* [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y
@ 2025-12-22 11:51 Aswin Murugan
  2025-12-22 11:51 ` [PATCH v1 1/2] pinctrl: qcom: Make pinctrl drivers default y based on architecture Aswin Murugan
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Aswin Murugan @ 2025-12-22 11:51 UTC (permalink / raw)
  To: casey.connolly, neil.armstrong, sumit.garg, trini,
	ilias.apalodimas, christopher.obbard, quic_varada, me,
	marek.vasut+renesas, alexeymin, u-boot-qcom, u-boot
  Cc: Aswin Murugan

This is a follow-up patch series to address review feedback on the
QCS615 pinctrl driver addition:
https://lore.kernel.org/u-boot/20251112164758.1560041-1-aswin.murugan@oss.qualcomm.com/

During review, it was suggested that since all Qualcomm pinctrl
drivers are already within a menu conditional on ARCH_SNAPDRAGON ||
ARCH_IPQ40XX, they should be made default y based on the appropriate
architecture rather than requiring manual enablement in defconfig
files.

This series implements that suggestion by:
1. Adding 'default y if ARCH_SNAPDRAGON' to all Snapdragon pinctrl
   drivers and 'default y if ARCH_IPQ40XX' to all IPQ pinctrl
   drivers in the Kconfig
2. Removing the now-redundant explicit pinctrl driver selections
   from qcom_defconfig

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>

Aswin Murugan (2):
  pinctrl: qcom: Make pinctrl drivers default y based on architecture
  configs: qcom_defconfig: Remove redundant pinctrl driver selections

 configs/qcom_defconfig       | 18 ------------------
 drivers/pinctrl/qcom/Kconfig | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 18 deletions(-)

-- 
2.34.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v1 1/2] pinctrl: qcom: Make pinctrl drivers default y based on architecture
  2025-12-22 11:51 [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Aswin Murugan
@ 2025-12-22 11:51 ` Aswin Murugan
  2025-12-22 11:51 ` [PATCH v1 2/2] configs: qcom_defconfig: Remove redundant pinctrl driver selections Aswin Murugan
  2025-12-26  8:37 ` [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Sumit Garg
  2 siblings, 0 replies; 6+ messages in thread
From: Aswin Murugan @ 2025-12-22 11:51 UTC (permalink / raw)
  To: casey.connolly, neil.armstrong, sumit.garg, trini,
	ilias.apalodimas, christopher.obbard, quic_varada, me,
	marek.vasut+renesas, alexeymin, u-boot-qcom, u-boot
  Cc: Aswin Murugan

All Qualcomm pinctrl drivers are already within a menu conditional on
ARCH_SNAPDRAGON || ARCH_IPQ40XX. Make them default y based on the
appropriate architecture to avoid having to manually enable each driver
in defconfig files.

Suggested-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
---
 drivers/pinctrl/qcom/Kconfig | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
index 725200d94c8..283ca3c8813 100644
--- a/drivers/pinctrl/qcom/Kconfig
+++ b/drivers/pinctrl/qcom/Kconfig
@@ -8,6 +8,7 @@ menu "Qualcomm pinctrl drivers"
 
 config PINCTRL_QCOM_APQ8016
 	bool "Qualcomm APQ8016 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the MSM8916 / APQ8016
@@ -15,6 +16,7 @@ config PINCTRL_QCOM_APQ8016
 
 config PINCTRL_QCOM_APQ8096
 	bool "Qualcomm APQ8096 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the MSM8996 / APQ8096
@@ -22,6 +24,7 @@ config PINCTRL_QCOM_APQ8096
 
 config PINCTRL_QCOM_IPQ4019
 	bool "Qualcomm IPQ4019 Pinctrl"
+	default y if ARCH_IPQ40XX
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the IPQ4019 SoC,
@@ -29,6 +32,7 @@ config PINCTRL_QCOM_IPQ4019
 
 config PINCTRL_QCOM_IPQ5424
 	bool "Qualcomm IPQ5424 Pinctrl"
+	default y if ARCH_IPQ40XX
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the IPQ5424 SoC,
@@ -36,6 +40,7 @@ config PINCTRL_QCOM_IPQ5424
 
 config PINCTRL_QCOM_IPQ9574
 	bool "Qualcomm IPQ9574 Pinctrl"
+	default y if ARCH_IPQ40XX
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the IPQ9574 SoC,
@@ -43,6 +48,7 @@ config PINCTRL_QCOM_IPQ9574
 
 config PINCTRL_QCOM_QCM2290
 	bool "Qualcomm QCM2290 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon QCM2290 SoC,
@@ -50,6 +56,7 @@ config PINCTRL_QCOM_QCM2290
 
 config PINCTRL_QCOM_QCS404
 	bool "Qualcomm QCS404 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon QCS404 SoC,
@@ -57,6 +64,7 @@ config PINCTRL_QCOM_QCS404
 
 config PINCTRL_QCOM_QCS615
         bool "Qualcomm QCS615 Pinctrl"
+        default y if ARCH_SNAPDRAGON
         select PINCTRL_QCOM
         help
           Say Y here to enable support for pinctrl on the Snapdragon QCS615 SoC,
@@ -64,6 +72,7 @@ config PINCTRL_QCOM_QCS615
 
 config PINCTRL_QCOM_SA8775P
 	bool "Qualcomm SA8775P Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SA8775P SoC,
@@ -71,12 +80,14 @@ config PINCTRL_QCOM_SA8775P
 
 config PINCTRL_QCOM_SC7280
 	bool "Qualcomm SC7280/QCM6490 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SC7280 SoC,
 
 config PINCTRL_QCOM_SDM670
 	bool "Qualcomm SDM670 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SDM670 SoC,
@@ -84,6 +95,7 @@ config PINCTRL_QCOM_SDM670
 
 config PINCTRL_QCOM_SDM660
 	bool "Qualcomm SDM630/660 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon 630/636/660
@@ -91,6 +103,7 @@ config PINCTRL_QCOM_SDM660
 
 config PINCTRL_QCOM_SDM845
 	bool "Qualcomm SDM845 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon 845 SoC,
@@ -98,6 +111,7 @@ config PINCTRL_QCOM_SDM845
 
 config PINCTRL_QCOM_SM6115
 	bool "Qualcomm SM6115 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM6115 SoC,
@@ -105,12 +119,14 @@ config PINCTRL_QCOM_SM6115
 
 config PINCTRL_QCOM_SM6350
 	bool "Qualcomm SM6350 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM6350 SoC,
 
 config PINCTRL_QCOM_SM7150
 	bool "Qualcomm SM7150 GCC"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM7150 SoC,
@@ -118,6 +134,7 @@ config PINCTRL_QCOM_SM7150
 
 config PINCTRL_QCOM_SM8150
 	bool "Qualcomm SM8150 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8150 SoC,
@@ -125,6 +142,7 @@ config PINCTRL_QCOM_SM8150
 
 config PINCTRL_QCOM_SM8250
 	bool "Qualcomm SM8250 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8250 SoC,
@@ -132,6 +150,7 @@ config PINCTRL_QCOM_SM8250
 
 config PINCTRL_QCOM_SM8550
 	bool "Qualcomm SM8550 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8550 SoC,
@@ -139,6 +158,7 @@ config PINCTRL_QCOM_SM8550
 
 config PINCTRL_QCOM_SM8650
 	bool "Qualcomm SM8650 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8650 SoC,
@@ -146,6 +166,7 @@ config PINCTRL_QCOM_SM8650
 
 config PINCTRL_QCOM_X1E80100
 	bool "Qualcomm X1E80100 Pinctrl"
+	default y if ARCH_SNAPDRAGON
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon X1E80100 SoC,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v1 2/2] configs: qcom_defconfig: Remove redundant pinctrl driver selections
  2025-12-22 11:51 [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Aswin Murugan
  2025-12-22 11:51 ` [PATCH v1 1/2] pinctrl: qcom: Make pinctrl drivers default y based on architecture Aswin Murugan
@ 2025-12-22 11:51 ` Aswin Murugan
  2025-12-26  8:37 ` [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Sumit Garg
  2 siblings, 0 replies; 6+ messages in thread
From: Aswin Murugan @ 2025-12-22 11:51 UTC (permalink / raw)
  To: casey.connolly, neil.armstrong, sumit.garg, trini,
	ilias.apalodimas, christopher.obbard, quic_varada, me,
	marek.vasut+renesas, alexeymin, u-boot-qcom, u-boot
  Cc: Aswin Murugan

These pinctrl drivers are now automatically enabled via Kconfig
defaults based on ARCH_SNAPDRAGON, so explicit selection in the
defconfig is no longer needed.

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
---
 configs/qcom_defconfig | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index 919897b8d40..e1ae0d946ee 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -110,24 +110,6 @@ CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=y
 CONFIG_PHY_QCOM_SNPS_EUSB2=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
-CONFIG_PINCTRL_QCOM_APQ8016=y
-CONFIG_PINCTRL_QCOM_APQ8096=y
-CONFIG_PINCTRL_QCOM_QCM2290=y
-CONFIG_PINCTRL_QCOM_QCS404=y
-CONFIG_PINCTRL_QCOM_QCS615=y
-CONFIG_PINCTRL_QCOM_SA8775P=y
-CONFIG_PINCTRL_QCOM_SC7280=y
-CONFIG_PINCTRL_QCOM_SDM670=y
-CONFIG_PINCTRL_QCOM_SDM660=y
-CONFIG_PINCTRL_QCOM_SDM845=y
-CONFIG_PINCTRL_QCOM_SM6115=y
-CONFIG_PINCTRL_QCOM_SM6350=y
-CONFIG_PINCTRL_QCOM_SM7150=y
-CONFIG_PINCTRL_QCOM_SM8150=y
-CONFIG_PINCTRL_QCOM_SM8250=y
-CONFIG_PINCTRL_QCOM_SM8550=y
-CONFIG_PINCTRL_QCOM_SM8650=y
-CONFIG_PINCTRL_QCOM_X1E80100=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_QCOM=y
 CONFIG_DM_REGULATOR=y
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y
  2025-12-22 11:51 [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Aswin Murugan
  2025-12-22 11:51 ` [PATCH v1 1/2] pinctrl: qcom: Make pinctrl drivers default y based on architecture Aswin Murugan
  2025-12-22 11:51 ` [PATCH v1 2/2] configs: qcom_defconfig: Remove redundant pinctrl driver selections Aswin Murugan
@ 2025-12-26  8:37 ` Sumit Garg
  2025-12-26 14:56   ` Tom Rini
  2 siblings, 1 reply; 6+ messages in thread
From: Sumit Garg @ 2025-12-26  8:37 UTC (permalink / raw)
  To: Aswin Murugan
  Cc: casey.connolly, neil.armstrong, trini, ilias.apalodimas,
	christopher.obbard, quic_varada, me, marek.vasut+renesas,
	alexeymin, u-boot-qcom, u-boot

On Mon, Dec 22, 2025 at 05:21:42PM +0530, Aswin Murugan wrote:
> This is a follow-up patch series to address review feedback on the
> QCS615 pinctrl driver addition:
> https://lore.kernel.org/u-boot/20251112164758.1560041-1-aswin.murugan@oss.qualcomm.com/
> 
> During review, it was suggested that since all Qualcomm pinctrl
> drivers are already within a menu conditional on ARCH_SNAPDRAGON ||
> ARCH_IPQ40XX, they should be made default y based on the appropriate
> architecture rather than requiring manual enablement in defconfig
> files.
> 
> This series implements that suggestion by:
> 1. Adding 'default y if ARCH_SNAPDRAGON' to all Snapdragon pinctrl
>    drivers and 'default y if ARCH_IPQ40XX' to all IPQ pinctrl
>    drivers in the Kconfig

I see the usefullness of this feature but in turn it will limit the
capability to reduce U-Boot size to an essential minimum. In scenarios
where there are contraints on flash size or on-chip RAM for U-Boot SPL.
I would rather favour something like following like:

'default y if PINCTRL_QCOM_GENERIC'

where PINCTRL_QCOM_GENERIC can be enabled from generic Qcom defconfig.

-Sumit

> 2. Removing the now-redundant explicit pinctrl driver selections
>    from qcom_defconfig
> 
> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> 
> Aswin Murugan (2):
>   pinctrl: qcom: Make pinctrl drivers default y based on architecture
>   configs: qcom_defconfig: Remove redundant pinctrl driver selections
> 
>  configs/qcom_defconfig       | 18 ------------------
>  drivers/pinctrl/qcom/Kconfig | 21 +++++++++++++++++++++
>  2 files changed, 21 insertions(+), 18 deletions(-)
> 
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y
  2025-12-26  8:37 ` [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Sumit Garg
@ 2025-12-26 14:56   ` Tom Rini
  2025-12-29  4:16     ` Sumit Garg
  0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2025-12-26 14:56 UTC (permalink / raw)
  To: Sumit Garg
  Cc: Aswin Murugan, casey.connolly, neil.armstrong, ilias.apalodimas,
	christopher.obbard, quic_varada, me, marek.vasut+renesas,
	alexeymin, u-boot-qcom, u-boot

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

On Fri, Dec 26, 2025 at 02:07:18PM +0530, Sumit Garg wrote:
> On Mon, Dec 22, 2025 at 05:21:42PM +0530, Aswin Murugan wrote:
> > This is a follow-up patch series to address review feedback on the
> > QCS615 pinctrl driver addition:
> > https://lore.kernel.org/u-boot/20251112164758.1560041-1-aswin.murugan@oss.qualcomm.com/
> > 
> > During review, it was suggested that since all Qualcomm pinctrl
> > drivers are already within a menu conditional on ARCH_SNAPDRAGON ||
> > ARCH_IPQ40XX, they should be made default y based on the appropriate
> > architecture rather than requiring manual enablement in defconfig
> > files.
> > 
> > This series implements that suggestion by:
> > 1. Adding 'default y if ARCH_SNAPDRAGON' to all Snapdragon pinctrl
> >    drivers and 'default y if ARCH_IPQ40XX' to all IPQ pinctrl
> >    drivers in the Kconfig
> 
> I see the usefullness of this feature but in turn it will limit the
> capability to reduce U-Boot size to an essential minimum. In scenarios
> where there are contraints on flash size or on-chip RAM for U-Boot SPL.
> I would rather favour something like following like:
> 
> 'default y if PINCTRL_QCOM_GENERIC'
> 
> where PINCTRL_QCOM_GENERIC can be enabled from generic Qcom defconfig.

If something is merely "default y" it can still be easily turned off. If
we want to make the "if ..." part more precise, OK. But I don't want to
go back to (nearly?) every snapdragon and ipq40xx defconfig being
modified, as it was in an earlier iteration.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y
  2025-12-26 14:56   ` Tom Rini
@ 2025-12-29  4:16     ` Sumit Garg
  0 siblings, 0 replies; 6+ messages in thread
From: Sumit Garg @ 2025-12-29  4:16 UTC (permalink / raw)
  To: Tom Rini
  Cc: Aswin Murugan, casey.connolly, neil.armstrong, ilias.apalodimas,
	christopher.obbard, quic_varada, me, marek.vasut+renesas,
	alexeymin, u-boot-qcom, u-boot

On Fri, Dec 26, 2025 at 08:56:29AM -0600, Tom Rini wrote:
> On Fri, Dec 26, 2025 at 02:07:18PM +0530, Sumit Garg wrote:
> > On Mon, Dec 22, 2025 at 05:21:42PM +0530, Aswin Murugan wrote:
> > > This is a follow-up patch series to address review feedback on the
> > > QCS615 pinctrl driver addition:
> > > https://lore.kernel.org/u-boot/20251112164758.1560041-1-aswin.murugan@oss.qualcomm.com/
> > > 
> > > During review, it was suggested that since all Qualcomm pinctrl
> > > drivers are already within a menu conditional on ARCH_SNAPDRAGON ||
> > > ARCH_IPQ40XX, they should be made default y based on the appropriate
> > > architecture rather than requiring manual enablement in defconfig
> > > files.
> > > 
> > > This series implements that suggestion by:
> > > 1. Adding 'default y if ARCH_SNAPDRAGON' to all Snapdragon pinctrl
> > >    drivers and 'default y if ARCH_IPQ40XX' to all IPQ pinctrl
> > >    drivers in the Kconfig
> > 
> > I see the usefullness of this feature but in turn it will limit the
> > capability to reduce U-Boot size to an essential minimum. In scenarios
> > where there are contraints on flash size or on-chip RAM for U-Boot SPL.
> > I would rather favour something like following like:
> > 
> > 'default y if PINCTRL_QCOM_GENERIC'
> > 
> > where PINCTRL_QCOM_GENERIC can be enabled from generic Qcom defconfig.
> 
> If something is merely "default y" it can still be easily turned off.

Yeah true but then again in say any SPL defconfig every config option
needs to be turned off which is a similar thing you want to avoid now.

> If
> we want to make the "if ..." part more precise, OK.

Exactly, lets do it properly.

> But I don't want to
> go back to (nearly?) every snapdragon and ipq40xx defconfig being
> modified, as it was in an earlier iteration.

Sure, we don't want to go back but extend your suggestion with
PINCTRL_QCOM_GENERIC.

-Sumit

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-12-29  4:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-22 11:51 [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Aswin Murugan
2025-12-22 11:51 ` [PATCH v1 1/2] pinctrl: qcom: Make pinctrl drivers default y based on architecture Aswin Murugan
2025-12-22 11:51 ` [PATCH v1 2/2] configs: qcom_defconfig: Remove redundant pinctrl driver selections Aswin Murugan
2025-12-26  8:37 ` [PATCH v1 0/2] pinctrl: qcom: Make pinctrl drivers default y Sumit Garg
2025-12-26 14:56   ` Tom Rini
2025-12-29  4:16     ` Sumit Garg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox