From: Yao Zi <me@ziyao.cc>
To: Kuan-Wei Chiu <visitorckw@gmail.com>,
alison.wang@nxp.com, angelo@kernel-space.org, trini@konsulko.com
Cc: daniel@0x0f.com, jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com,
u-boot@lists.denx.de
Subject: Re: [PATCH v3 1/6] serial: Add Goldfish TTY driver
Date: Wed, 31 Dec 2025 03:01:30 +0000 [thread overview]
Message-ID: <aVSSCnF_YO3IaGR8@pie> (raw)
In-Reply-To: <20251230160112.3045527-2-visitorckw@gmail.com>
On Tue, Dec 30, 2025 at 04:01:07PM +0000, Kuan-Wei Chiu wrote:
> Add support for the Google Goldfish TTY serial device. This virtual
> device is commonly used in QEMU virtual machines (such as the m68k
> virt machine) and Android emulators.
>
> The driver implements basic console output and input polling using the
> Goldfish MMIO interface.
>
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
> Changes in v3:
> - Remove unnecessary type casts for MMIO register access.
>
> MAINTAINERS | 6 ++
> drivers/serial/Kconfig | 8 +++
> drivers/serial/Makefile | 1 +
> drivers/serial/serial_goldfish.c | 102 +++++++++++++++++++++++++++++++
> include/goldfish_tty.h | 18 ++++++
> 5 files changed, 135 insertions(+)
> create mode 100644 drivers/serial/serial_goldfish.c
> create mode 100644 include/goldfish_tty.h
This version looks good to me,
Reviewed-by: Yao Zi <me@ziyao.cc>
next prev parent reply other threads:[~2025-12-31 3:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 16:01 [PATCH v3 0/6] m68k: Add support for QEMU virt machine Kuan-Wei Chiu
2025-12-30 16:01 ` [PATCH v3 1/6] serial: Add Goldfish TTY driver Kuan-Wei Chiu
2025-12-31 3:01 ` Yao Zi [this message]
2025-12-31 3:52 ` Daniel Palmer
2025-12-31 12:25 ` Heinrich Schuchardt
2025-12-31 16:18 ` Kuan-Wei Chiu
2025-12-30 16:01 ` [PATCH v3 2/6] timer: Add Goldfish timer driver Kuan-Wei Chiu
2025-12-31 3:49 ` Daniel Palmer
2025-12-31 6:27 ` Yao Zi
2025-12-31 16:15 ` Kuan-Wei Chiu
2025-12-30 16:01 ` [PATCH v3 3/6] rtc: goldfish: Support platform data for non-DT probing Kuan-Wei Chiu
2025-12-31 12:12 ` Heinrich Schuchardt
2025-12-31 16:23 ` Kuan-Wei Chiu
2025-12-30 16:01 ` [PATCH v3 4/6] m68k: Add support for M68040 CPU Kuan-Wei Chiu
2025-12-30 16:01 ` [PATCH v3 5/6] board: Add QEMU m68k virt board support Kuan-Wei Chiu
2025-12-31 3:59 ` Daniel Palmer
2025-12-30 16:01 ` [PATCH v3 6/6] CI: Add test jobs for QEMU m68k virt machine Kuan-Wei Chiu
2025-12-30 16:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aVSSCnF_YO3IaGR8@pie \
--to=me@ziyao.cc \
--cc=alison.wang@nxp.com \
--cc=angelo@kernel-space.org \
--cc=daniel@0x0f.com \
--cc=eleanor15x@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox