[PATCH v2 0/2] pinctrl: qcom: Make pinctrl drivers default y

[PATCH v2 0/2] pinctrl: qcom: Make pinctrl drivers default y

[Aswin Murugan]

This is a follow-up patch series to address review feedback on the
QCS615 pinctrl driver addition:
https://lore.kernel.org/u-boot/20251112164758.1560041-1-aswin.murugan@oss.qualcomm.com/

During review, it was suggested that all Qualcomm pinctrl
drivers should be enabled by default based on a condition,
rather than requiring manual enablement in defconfig files.

This series implements that suggestion by:
1. Adding 'default y if PINCTRL_QCOM_GENERIC' to all qualcomm pinctrl
   drivers in the Kconfig
2. Removing the now-redundant explicit pinctrl driver selections
   from qcom_defconfig & enabling PINCTRL_QCOM_GENERIC config

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
---
Changes in v2:
- As per review comments made default y for pinctrl drivers
  based on PINCTRL_QCOM_GENERIC config 'default y if PINCTRL_QCOM_GENERIC'
- Link to v1: https://lore.kernel.org/u-boot/20251222115144.2146964-1-aswin.murugan@oss.qualcomm.com/
---

Aswin Murugan (2):
  pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by
    default
  qcom_defconfig: Remove redundant pinctrl driver selections

 configs/qcom_defconfig       | 19 +------------------
 drivers/pinctrl/qcom/Kconfig | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 18 deletions(-)

-- 
2.34.1

[PATCH v2 1/2] pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by default

[Aswin Murugan]

Introduce a new Kconfig option PINCTRL_QCOM_GENERIC that, when selected,
enables all Qualcomm pinctrl drivers by default. This simplifies defconfigs
for platforms supporting multiple SoCs and avoids manual driver selection.
Individual drivers can still be disabled if required.

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
---
Changes in v2:
- As per review comments made default y for pinctrl drivers
  based on PINCTRL_QCOM_GENERIC config 'default y if PINCTRL_QCOM_GENERIC' 
---
 drivers/pinctrl/qcom/Kconfig | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
index 725200d94c8..580308621b1 100644
--- a/drivers/pinctrl/qcom/Kconfig
+++ b/drivers/pinctrl/qcom/Kconfig
@@ -6,8 +6,17 @@ config PINCTRL_QCOM
 
 menu "Qualcomm pinctrl drivers"
 
+config PINCTRL_QCOM_GENERIC
+	bool "Enable all Qualcomm pinctrl drivers by default"
+	select PINCTRL_QCOM
+	help
+	  Say Y here to enable all Qualcomm pinctrl drivers by default.
+	  This is useful for generic Qualcomm defconfigs that support
+	  multiple SoCs. Individual drivers can still be disabled if needed.
+
 config PINCTRL_QCOM_APQ8016
 	bool "Qualcomm APQ8016 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the MSM8916 / APQ8016
@@ -15,6 +24,7 @@ config PINCTRL_QCOM_APQ8016
 
 config PINCTRL_QCOM_APQ8096
 	bool "Qualcomm APQ8096 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the MSM8996 / APQ8096
@@ -22,6 +32,7 @@ config PINCTRL_QCOM_APQ8096
 
 config PINCTRL_QCOM_IPQ4019
 	bool "Qualcomm IPQ4019 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the IPQ4019 SoC,
@@ -29,6 +40,7 @@ config PINCTRL_QCOM_IPQ4019
 
 config PINCTRL_QCOM_IPQ5424
 	bool "Qualcomm IPQ5424 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the IPQ5424 SoC,
@@ -36,6 +48,7 @@ config PINCTRL_QCOM_IPQ5424
 
 config PINCTRL_QCOM_IPQ9574
 	bool "Qualcomm IPQ9574 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the IPQ9574 SoC,
@@ -43,6 +56,7 @@ config PINCTRL_QCOM_IPQ9574
 
 config PINCTRL_QCOM_QCM2290
 	bool "Qualcomm QCM2290 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon QCM2290 SoC,
@@ -50,6 +64,7 @@ config PINCTRL_QCOM_QCM2290
 
 config PINCTRL_QCOM_QCS404
 	bool "Qualcomm QCS404 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon QCS404 SoC,
@@ -57,6 +72,7 @@ config PINCTRL_QCOM_QCS404
 
 config PINCTRL_QCOM_QCS615
         bool "Qualcomm QCS615 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
         select PINCTRL_QCOM
         help
           Say Y here to enable support for pinctrl on the Snapdragon QCS615 SoC,
@@ -64,6 +80,7 @@ config PINCTRL_QCOM_QCS615
 
 config PINCTRL_QCOM_SA8775P
 	bool "Qualcomm SA8775P Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SA8775P SoC,
@@ -71,12 +88,14 @@ config PINCTRL_QCOM_SA8775P
 
 config PINCTRL_QCOM_SC7280
 	bool "Qualcomm SC7280/QCM6490 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SC7280 SoC,
 
 config PINCTRL_QCOM_SDM670
 	bool "Qualcomm SDM670 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SDM670 SoC,
@@ -84,6 +103,7 @@ config PINCTRL_QCOM_SDM670
 
 config PINCTRL_QCOM_SDM660
 	bool "Qualcomm SDM630/660 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon 630/636/660
@@ -91,6 +111,7 @@ config PINCTRL_QCOM_SDM660
 
 config PINCTRL_QCOM_SDM845
 	bool "Qualcomm SDM845 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon 845 SoC,
@@ -98,6 +119,7 @@ config PINCTRL_QCOM_SDM845
 
 config PINCTRL_QCOM_SM6115
 	bool "Qualcomm SM6115 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM6115 SoC,
@@ -105,12 +127,14 @@ config PINCTRL_QCOM_SM6115
 
 config PINCTRL_QCOM_SM6350
 	bool "Qualcomm SM6350 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM6350 SoC,
 
 config PINCTRL_QCOM_SM7150
 	bool "Qualcomm SM7150 GCC"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM7150 SoC,
@@ -118,6 +142,7 @@ config PINCTRL_QCOM_SM7150
 
 config PINCTRL_QCOM_SM8150
 	bool "Qualcomm SM8150 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8150 SoC,
@@ -125,6 +150,7 @@ config PINCTRL_QCOM_SM8150
 
 config PINCTRL_QCOM_SM8250
 	bool "Qualcomm SM8250 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8250 SoC,
@@ -132,6 +158,7 @@ config PINCTRL_QCOM_SM8250
 
 config PINCTRL_QCOM_SM8550
 	bool "Qualcomm SM8550 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8550 SoC,
@@ -139,6 +166,7 @@ config PINCTRL_QCOM_SM8550
 
 config PINCTRL_QCOM_SM8650
 	bool "Qualcomm SM8650 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon SM8650 SoC,
@@ -146,6 +174,7 @@ config PINCTRL_QCOM_SM8650
 
 config PINCTRL_QCOM_X1E80100
 	bool "Qualcomm X1E80100 Pinctrl"
+	default y if PINCTRL_QCOM_GENERIC
 	select PINCTRL_QCOM
 	help
 	  Say Y here to enable support for pinctrl on the Snapdragon X1E80100 SoC,
-- 
2.34.1

[PATCH v2 2/2] qcom_defconfig: Remove redundant pinctrl driver selections

[Aswin Murugan]

Enable PINCTRL_QCOM_GENERIC config
The pinctrl drivers are now automatically enabled via Kconfig
defaults based on PINCTRL_QCOM_GENERIC, so explicit selection in the
defconfig is no longer needed.

Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
---
Changes in v2:
- Enable newly added PINCTRL_QCOM_GENERIC config
---
 configs/qcom_defconfig | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index aa3902f5627..fe5880de1fd 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -113,24 +113,7 @@ CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=y
 CONFIG_PHY_QCOM_SNPS_EUSB2=y
 CONFIG_PINCTRL=y
 CONFIG_PINCONF=y
-CONFIG_PINCTRL_QCOM_APQ8016=y
-CONFIG_PINCTRL_QCOM_APQ8096=y
-CONFIG_PINCTRL_QCOM_QCM2290=y
-CONFIG_PINCTRL_QCOM_QCS404=y
-CONFIG_PINCTRL_QCOM_QCS615=y
-CONFIG_PINCTRL_QCOM_SA8775P=y
-CONFIG_PINCTRL_QCOM_SC7280=y
-CONFIG_PINCTRL_QCOM_SDM670=y
-CONFIG_PINCTRL_QCOM_SDM660=y
-CONFIG_PINCTRL_QCOM_SDM845=y
-CONFIG_PINCTRL_QCOM_SM6115=y
-CONFIG_PINCTRL_QCOM_SM6350=y
-CONFIG_PINCTRL_QCOM_SM7150=y
-CONFIG_PINCTRL_QCOM_SM8150=y
-CONFIG_PINCTRL_QCOM_SM8250=y
-CONFIG_PINCTRL_QCOM_SM8550=y
-CONFIG_PINCTRL_QCOM_SM8650=y
-CONFIG_PINCTRL_QCOM_X1E80100=y
+CONFIG_PINCTRL_QCOM_GENERIC=y
 CONFIG_DM_PMIC=y
 CONFIG_PMIC_QCOM=y
 CONFIG_DM_REGULATOR=y
-- 
2.34.1

Re: [PATCH v2 0/2] pinctrl: qcom: Make pinctrl drivers default y

[Casey Connolly]

On 07/01/2026 16:47, Aswin Murugan wrote:
> This is a follow-up patch series to address review feedback on the
> QCS615 pinctrl driver addition:
> https://lore.kernel.org/u-boot/20251112164758.1560041-1-aswin.murugan@oss.qualcomm.com/
> 
> During review, it was suggested that all Qualcomm pinctrl
> drivers should be enabled by default based on a condition,
> rather than requiring manual enablement in defconfig files.
> 
> This series implements that suggestion by:
> 1. Adding 'default y if PINCTRL_QCOM_GENERIC' to all qualcomm pinctrl
>    drivers in the Kconfig
> 2. Removing the now-redundant explicit pinctrl driver selections
>    from qcom_defconfig & enabling PINCTRL_QCOM_GENERIC config
> 
> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>

Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

Thanks,

> ---
> Changes in v2:
> - As per review comments made default y for pinctrl drivers
>   based on PINCTRL_QCOM_GENERIC config 'default y if PINCTRL_QCOM_GENERIC'
> - Link to v1: https://lore.kernel.org/u-boot/20251222115144.2146964-1-aswin.murugan@oss.qualcomm.com/
> ---
> 
> Aswin Murugan (2):
>   pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by
>     default
>   qcom_defconfig: Remove redundant pinctrl driver selections
> 
>  configs/qcom_defconfig       | 19 +------------------
>  drivers/pinctrl/qcom/Kconfig | 29 +++++++++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 18 deletions(-)
> 

-- 
// Casey (she/her)

Re: [PATCH v2 1/2] pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by default

[Quentin Schulz]

Hi Aswin,

On 1/7/26 4:47 PM, Aswin Murugan wrote:
> Introduce a new Kconfig option PINCTRL_QCOM_GENERIC that, when selected,
> enables all Qualcomm pinctrl drivers by default. This simplifies defconfigs
> for platforms supporting multiple SoCs and avoids manual driver selection.
> Individual drivers can still be disabled if required.
> 
> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> ---
> Changes in v2:
> - As per review comments made default y for pinctrl drivers
>    based on PINCTRL_QCOM_GENERIC config 'default y if PINCTRL_QCOM_GENERIC'
> ---
>   drivers/pinctrl/qcom/Kconfig | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> index 725200d94c8..580308621b1 100644
> --- a/drivers/pinctrl/qcom/Kconfig
> +++ b/drivers/pinctrl/qcom/Kconfig
> @@ -6,8 +6,17 @@ config PINCTRL_QCOM
>   
>   menu "Qualcomm pinctrl drivers"
>   
> +config PINCTRL_QCOM_GENERIC
> +	bool "Enable all Qualcomm pinctrl drivers by default"
> +	select PINCTRL_QCOM
> +	help
> +	  Say Y here to enable all Qualcomm pinctrl drivers by default.
> +	  This is useful for generic Qualcomm defconfigs that support
> +	  multiple SoCs. Individual drivers can still be disabled if needed.
> +
>   config PINCTRL_QCOM_APQ8016
>   	bool "Qualcomm APQ8016 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the MSM8916 / APQ8016
> @@ -15,6 +24,7 @@ config PINCTRL_QCOM_APQ8016
>   
>   config PINCTRL_QCOM_APQ8096
>   	bool "Qualcomm APQ8096 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the MSM8996 / APQ8096
> @@ -22,6 +32,7 @@ config PINCTRL_QCOM_APQ8096
>   
>   config PINCTRL_QCOM_IPQ4019
>   	bool "Qualcomm IPQ4019 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the IPQ4019 SoC,
> @@ -29,6 +40,7 @@ config PINCTRL_QCOM_IPQ4019
>   
>   config PINCTRL_QCOM_IPQ5424
>   	bool "Qualcomm IPQ5424 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the IPQ5424 SoC,
> @@ -36,6 +48,7 @@ config PINCTRL_QCOM_IPQ5424
>   
>   config PINCTRL_QCOM_IPQ9574
>   	bool "Qualcomm IPQ9574 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the IPQ9574 SoC,
> @@ -43,6 +56,7 @@ config PINCTRL_QCOM_IPQ9574
>   
>   config PINCTRL_QCOM_QCM2290
>   	bool "Qualcomm QCM2290 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the Snapdragon QCM2290 SoC,
> @@ -50,6 +64,7 @@ config PINCTRL_QCOM_QCM2290
>   
>   config PINCTRL_QCOM_QCS404
>   	bool "Qualcomm QCS404 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC
>   	select PINCTRL_QCOM
>   	help
>   	  Say Y here to enable support for pinctrl on the Snapdragon QCS404 SoC,
> @@ -57,6 +72,7 @@ config PINCTRL_QCOM_QCS404
>   
>   config PINCTRL_QCOM_QCS615
>           bool "Qualcomm QCS615 Pinctrl"
> +	default y if PINCTRL_QCOM_GENERIC

Indentation seems incorrect here?

b4 doesn't want to pick up the patch from lore so cannot check if it's 
an actual problem or not. See:

$ b4 shazam --add-my-sob --add-link 
https://lore.kernel.org/u-boot/67140dbd-1b93-43d1-b218-0b57a762ce1a@linaro.org/
[...]
Applying: pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers 
by default
Patch failed at 0001 pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable 
all drivers by default
error: sha1 information is lacking or useless 
(drivers/pinctrl/qcom/Kconfig).
error: could not build fake ancestor
[...]

Cheers,
Quentin

Re: [PATCH v2 2/2] qcom_defconfig: Remove redundant pinctrl driver selections

[Sumit Garg]

On Wed, Jan 07, 2026 at 09:17:45PM +0530, Aswin Murugan wrote:
> Enable PINCTRL_QCOM_GENERIC config
> The pinctrl drivers are now automatically enabled via Kconfig
> defaults based on PINCTRL_QCOM_GENERIC, so explicit selection in the
> defconfig is no longer needed.
> 
> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> ---
> Changes in v2:
> - Enable newly added PINCTRL_QCOM_GENERIC config
> ---
>  configs/qcom_defconfig | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index aa3902f5627..fe5880de1fd 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -113,24 +113,7 @@ CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=y
>  CONFIG_PHY_QCOM_SNPS_EUSB2=y
>  CONFIG_PINCTRL=y
>  CONFIG_PINCONF=y
> -CONFIG_PINCTRL_QCOM_APQ8016=y
> -CONFIG_PINCTRL_QCOM_APQ8096=y
> -CONFIG_PINCTRL_QCOM_QCM2290=y
> -CONFIG_PINCTRL_QCOM_QCS404=y
> -CONFIG_PINCTRL_QCOM_QCS615=y
> -CONFIG_PINCTRL_QCOM_SA8775P=y
> -CONFIG_PINCTRL_QCOM_SC7280=y
> -CONFIG_PINCTRL_QCOM_SDM670=y
> -CONFIG_PINCTRL_QCOM_SDM660=y
> -CONFIG_PINCTRL_QCOM_SDM845=y
> -CONFIG_PINCTRL_QCOM_SM6115=y
> -CONFIG_PINCTRL_QCOM_SM6350=y
> -CONFIG_PINCTRL_QCOM_SM7150=y
> -CONFIG_PINCTRL_QCOM_SM8150=y
> -CONFIG_PINCTRL_QCOM_SM8250=y
> -CONFIG_PINCTRL_QCOM_SM8550=y
> -CONFIG_PINCTRL_QCOM_SM8650=y
> -CONFIG_PINCTRL_QCOM_X1E80100=y
> +CONFIG_PINCTRL_QCOM_GENERIC=y
>  CONFIG_DM_PMIC=y
>  CONFIG_PMIC_QCOM=y
>  CONFIG_DM_REGULATOR=y
> -- 
> 2.34.1
> 

Re: [PATCH v2 1/2] pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by default

[Sumit Garg]

On Wed, Jan 14, 2026 at 06:29:55PM +0100, Quentin Schulz wrote:
> Hi Aswin,
> 
> On 1/7/26 4:47 PM, Aswin Murugan wrote:
> > Introduce a new Kconfig option PINCTRL_QCOM_GENERIC that, when selected,
> > enables all Qualcomm pinctrl drivers by default. This simplifies defconfigs
> > for platforms supporting multiple SoCs and avoids manual driver selection.
> > Individual drivers can still be disabled if required.
> > 
> > Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> > ---
> > Changes in v2:
> > - As per review comments made default y for pinctrl drivers
> >    based on PINCTRL_QCOM_GENERIC config 'default y if PINCTRL_QCOM_GENERIC'
> > ---

"---" is redundant here and may be causing issues with the b4 patch
pickup.

> >   drivers/pinctrl/qcom/Kconfig | 29 +++++++++++++++++++++++++++++
> >   1 file changed, 29 insertions(+)
> > 
> > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig
> > index 725200d94c8..580308621b1 100644
> > --- a/drivers/pinctrl/qcom/Kconfig
> > +++ b/drivers/pinctrl/qcom/Kconfig
> > @@ -6,8 +6,17 @@ config PINCTRL_QCOM
> >   menu "Qualcomm pinctrl drivers"
> > +config PINCTRL_QCOM_GENERIC
> > +	bool "Enable all Qualcomm pinctrl drivers by default"
> > +	select PINCTRL_QCOM
> > +	help
> > +	  Say Y here to enable all Qualcomm pinctrl drivers by default.
> > +	  This is useful for generic Qualcomm defconfigs that support
> > +	  multiple SoCs. Individual drivers can still be disabled if needed.
> > +
> >   config PINCTRL_QCOM_APQ8016
> >   	bool "Qualcomm APQ8016 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the MSM8916 / APQ8016
> > @@ -15,6 +24,7 @@ config PINCTRL_QCOM_APQ8016
> >   config PINCTRL_QCOM_APQ8096
> >   	bool "Qualcomm APQ8096 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the MSM8996 / APQ8096
> > @@ -22,6 +32,7 @@ config PINCTRL_QCOM_APQ8096
> >   config PINCTRL_QCOM_IPQ4019
> >   	bool "Qualcomm IPQ4019 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the IPQ4019 SoC,
> > @@ -29,6 +40,7 @@ config PINCTRL_QCOM_IPQ4019
> >   config PINCTRL_QCOM_IPQ5424
> >   	bool "Qualcomm IPQ5424 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the IPQ5424 SoC,
> > @@ -36,6 +48,7 @@ config PINCTRL_QCOM_IPQ5424
> >   config PINCTRL_QCOM_IPQ9574
> >   	bool "Qualcomm IPQ9574 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the IPQ9574 SoC,
> > @@ -43,6 +56,7 @@ config PINCTRL_QCOM_IPQ9574
> >   config PINCTRL_QCOM_QCM2290
> >   	bool "Qualcomm QCM2290 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the Snapdragon QCM2290 SoC,
> > @@ -50,6 +64,7 @@ config PINCTRL_QCOM_QCM2290
> >   config PINCTRL_QCOM_QCS404
> >   	bool "Qualcomm QCS404 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> >   	select PINCTRL_QCOM
> >   	help
> >   	  Say Y here to enable support for pinctrl on the Snapdragon QCS404 SoC,
> > @@ -57,6 +72,7 @@ config PINCTRL_QCOM_QCS404
> >   config PINCTRL_QCOM_QCS615
> >           bool "Qualcomm QCS615 Pinctrl"
> > +	default y if PINCTRL_QCOM_GENERIC
> 
> Indentation seems incorrect here?

With indentation fixed, feel free to add:

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> b4 doesn't want to pick up the patch from lore so cannot check if it's an
> actual problem or not. See:
> 
> $ b4 shazam --add-my-sob --add-link https://lore.kernel.org/u-boot/67140dbd-1b93-43d1-b218-0b57a762ce1a@linaro.org/
> [...]
> Applying: pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all drivers by
> default
> Patch failed at 0001 pinctrl: qcom: add PINCTRL_QCOM_GENERIC to enable all
> drivers by default
> error: sha1 information is lacking or useless
> (drivers/pinctrl/qcom/Kconfig).
> error: could not build fake ancestor
> [...]
> 
> Cheers,
> Quentin