From: Sumit Garg <sumit.garg@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Cc: casey.connolly@linaro.org, neil.armstrong@linaro.org,
trini@konsulko.com, aswin.murugan@oss.qualcomm.com,
ilias.apalodimas@linaro.org, u-boot-qcom@groups.io,
u-boot@lists.denx.de
Subject: Re: [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards
Date: Thu, 15 Jan 2026 12:54:06 +0530 [thread overview]
Message-ID: <aWiWFrdwvy7-IK63@sumit-xelite> (raw)
In-Reply-To: <20260107095038.2491697-1-balaji.selvanathan@oss.qualcomm.com>
Hi Balaji,
On Wed, Jan 07, 2026 at 03:20:38PM +0530, Balaji Selvanathan wrote:
> The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes
> NULL pointer dereference during fastboot commands when users dont
> provide "-l" option in fastboot usb command.
On Qcom platforms, we usually rely on LMB allocations for fastboot
address, see here [1]. So I would rather suggest you to adapt fastboot
common code [2] to consume fastboot address from env (fastboot_addr_r)
in case CONFIG_FASTBOOT_BUF_ADDR is 0. Then it will be a generic fix
applicable for all the Qcom platforms.
[1] arch/arm/mach-snapdragon/board.c:545 env_set_hex("fastboot_addr_r", addr)
[2] drivers/fastboot/fb_common.c:235 fastboot_init()
-Sumit
>
> Set it to safe and sufficiently large region in RAM
> of the QCS615 and QCM6490 boards, to prevent crashes.
>
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
> configs/qcm6490_defconfig | 2 ++
> configs/qcom_qcs615_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig
> index 54eb5dedaec..618098c8860 100644
> --- a/configs/qcm6490_defconfig
> +++ b/configs/qcm6490_defconfig
> @@ -13,3 +13,5 @@ CONFIG_TEXT_BASE=0x9fc00000
> CONFIG_REMAKE_ELF=y
>
> CONFIG_DEFAULT_DEVICE_TREE="qcom/qcs6490-rb3gen2"
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xd8800000
> diff --git a/configs/qcom_qcs615_defconfig b/configs/qcom_qcs615_defconfig
> index 2468267b955..14043b4f23d 100644
> --- a/configs/qcom_qcs615_defconfig
> +++ b/configs/qcom_qcs615_defconfig
> @@ -20,3 +20,5 @@ CONFIG_REMAKE_ELF=y
>
> # Address where U-Boot will be loaded
> CONFIG_TEXT_BASE=0x9fc00000
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xa1600000
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-01-15 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 9:50 [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards Balaji Selvanathan
2026-01-08 5:42 ` Varadarajan Narayanan
2026-01-15 7:24 ` Sumit Garg [this message]
2026-01-16 18:03 ` Casey Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWiWFrdwvy7-IK63@sumit-xelite \
--to=sumit.garg@kernel.org \
--cc=aswin.murugan@oss.qualcomm.com \
--cc=balaji.selvanathan@oss.qualcomm.com \
--cc=casey.connolly@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox