public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards
@ 2026-01-07  9:50 Balaji Selvanathan
  2026-01-08  5:42 ` Varadarajan Narayanan
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Balaji Selvanathan @ 2026-01-07  9:50 UTC (permalink / raw)
  To: casey.connolly, neil.armstrong, sumit.garg, trini, aswin.murugan,
	ilias.apalodimas, balaji.selvanathan, u-boot-qcom, u-boot

The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes
NULL pointer dereference during fastboot commands when users dont
provide "-l" option in fastboot usb command.

Set it to safe and sufficiently large region in RAM
of the QCS615 and QCM6490 boards, to prevent crashes.

Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
---
 configs/qcm6490_defconfig     | 2 ++
 configs/qcom_qcs615_defconfig | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig
index 54eb5dedaec..618098c8860 100644
--- a/configs/qcm6490_defconfig
+++ b/configs/qcm6490_defconfig
@@ -13,3 +13,5 @@ CONFIG_TEXT_BASE=0x9fc00000
 CONFIG_REMAKE_ELF=y
 
 CONFIG_DEFAULT_DEVICE_TREE="qcom/qcs6490-rb3gen2"
+
+CONFIG_FASTBOOT_BUF_ADDR=0xd8800000
diff --git a/configs/qcom_qcs615_defconfig b/configs/qcom_qcs615_defconfig
index 2468267b955..14043b4f23d 100644
--- a/configs/qcom_qcs615_defconfig
+++ b/configs/qcom_qcs615_defconfig
@@ -20,3 +20,5 @@ CONFIG_REMAKE_ELF=y
 
 # Address where U-Boot will be loaded
 CONFIG_TEXT_BASE=0x9fc00000
+
+CONFIG_FASTBOOT_BUF_ADDR=0xa1600000
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards
  2026-01-07  9:50 [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards Balaji Selvanathan
@ 2026-01-08  5:42 ` Varadarajan Narayanan
  2026-01-15  7:24 ` Sumit Garg
  2026-01-16 18:03 ` Casey Connolly
  2 siblings, 0 replies; 4+ messages in thread
From: Varadarajan Narayanan @ 2026-01-08  5:42 UTC (permalink / raw)
  To: Balaji Selvanathan
  Cc: casey.connolly, neil.armstrong, sumit.garg, trini, aswin.murugan,
	ilias.apalodimas, u-boot-qcom, u-boot

On Wed, Jan 07, 2026 at 03:20:38PM +0530, Balaji Selvanathan wrote:
> The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes
> NULL pointer dereference during fastboot commands when users dont
> provide "-l" option in fastboot usb command.
>
> Set it to safe and sufficiently large region in RAM
> of the QCS615 and QCM6490 boards, to prevent crashes.
>
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
>  configs/qcm6490_defconfig     | 2 ++
>  configs/qcom_qcs615_defconfig | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig
> index 54eb5dedaec..618098c8860 100644
> --- a/configs/qcm6490_defconfig
> +++ b/configs/qcm6490_defconfig
> @@ -13,3 +13,5 @@ CONFIG_TEXT_BASE=0x9fc00000
>  CONFIG_REMAKE_ELF=y
>
>  CONFIG_DEFAULT_DEVICE_TREE="qcom/qcs6490-rb3gen2"
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xd8800000
> diff --git a/configs/qcom_qcs615_defconfig b/configs/qcom_qcs615_defconfig
> index 2468267b955..14043b4f23d 100644
> --- a/configs/qcom_qcs615_defconfig
> +++ b/configs/qcom_qcs615_defconfig
> @@ -20,3 +20,5 @@ CONFIG_REMAKE_ELF=y
>
>  # Address where U-Boot will be loaded
>  CONFIG_TEXT_BASE=0x9fc00000
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xa1600000
> --
> 2.34.1
>

Reviewed-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards
  2026-01-07  9:50 [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards Balaji Selvanathan
  2026-01-08  5:42 ` Varadarajan Narayanan
@ 2026-01-15  7:24 ` Sumit Garg
  2026-01-16 18:03 ` Casey Connolly
  2 siblings, 0 replies; 4+ messages in thread
From: Sumit Garg @ 2026-01-15  7:24 UTC (permalink / raw)
  To: Balaji Selvanathan
  Cc: casey.connolly, neil.armstrong, trini, aswin.murugan,
	ilias.apalodimas, u-boot-qcom, u-boot

Hi Balaji,

On Wed, Jan 07, 2026 at 03:20:38PM +0530, Balaji Selvanathan wrote:
> The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes
> NULL pointer dereference during fastboot commands when users dont
> provide "-l" option in fastboot usb command.

On Qcom platforms, we usually rely on LMB allocations for fastboot
address, see here [1]. So I would rather suggest you to adapt fastboot
common code [2] to consume fastboot address from env (fastboot_addr_r)
in case CONFIG_FASTBOOT_BUF_ADDR is 0. Then it will be a generic fix
applicable for all the Qcom platforms.

[1] arch/arm/mach-snapdragon/board.c:545 env_set_hex("fastboot_addr_r", addr)
[2] drivers/fastboot/fb_common.c:235 fastboot_init()

-Sumit

> 
> Set it to safe and sufficiently large region in RAM
> of the QCS615 and QCM6490 boards, to prevent crashes.
> 
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
>  configs/qcm6490_defconfig     | 2 ++
>  configs/qcom_qcs615_defconfig | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig
> index 54eb5dedaec..618098c8860 100644
> --- a/configs/qcm6490_defconfig
> +++ b/configs/qcm6490_defconfig
> @@ -13,3 +13,5 @@ CONFIG_TEXT_BASE=0x9fc00000
>  CONFIG_REMAKE_ELF=y
>  
>  CONFIG_DEFAULT_DEVICE_TREE="qcom/qcs6490-rb3gen2"
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xd8800000
> diff --git a/configs/qcom_qcs615_defconfig b/configs/qcom_qcs615_defconfig
> index 2468267b955..14043b4f23d 100644
> --- a/configs/qcom_qcs615_defconfig
> +++ b/configs/qcom_qcs615_defconfig
> @@ -20,3 +20,5 @@ CONFIG_REMAKE_ELF=y
>  
>  # Address where U-Boot will be loaded
>  CONFIG_TEXT_BASE=0x9fc00000
> +
> +CONFIG_FASTBOOT_BUF_ADDR=0xa1600000
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards
  2026-01-07  9:50 [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards Balaji Selvanathan
  2026-01-08  5:42 ` Varadarajan Narayanan
  2026-01-15  7:24 ` Sumit Garg
@ 2026-01-16 18:03 ` Casey Connolly
  2 siblings, 0 replies; 4+ messages in thread
From: Casey Connolly @ 2026-01-16 18:03 UTC (permalink / raw)
  To: neil.armstrong, sumit.garg, trini, aswin.murugan,
	ilias.apalodimas, u-boot-qcom, u-boot, Balaji Selvanathan


On Wed, 07 Jan 2026 15:20:38 +0530, Balaji Selvanathan wrote:
> The default value of CONFIG_FASTBOOT_BUF_ADDR is 0, which causes
> NULL pointer dereference during fastboot commands when users dont
> provide "-l" option in fastboot usb command.
> 
> Set it to safe and sufficiently large region in RAM
> of the QCS615 and QCM6490 boards, to prevent crashes.
> 
> [...]

Applied, thanks!

[1/1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/cb07205adb5b

Best regards,
-- 
// Casey (she/they)



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-16 18:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07  9:50 [PATCH v1] configs: Fix fastboot buffer address for QCS615 and QCM6490 boards Balaji Selvanathan
2026-01-08  5:42 ` Varadarajan Narayanan
2026-01-15  7:24 ` Sumit Garg
2026-01-16 18:03 ` Casey Connolly

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox