From: Leo Liang <ycliang@andestech.com>
To: Tom Rini <trini@konsulko.com>
Cc: <u-boot@lists.denx.de>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Beleswar Padhi <b-padhi@ti.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Rick Chen <rick@andestech.com>
Subject: Re: [PATCH 08/10] riscv: Update linker scripts to ensure appended device tree is aligned
Date: Fri, 16 Jan 2026 09:27:59 +0800 [thread overview]
Message-ID: <aWmUHzFeByWHEyy5@swlinux02> (raw)
In-Reply-To: <20260115222828.3931345-9-trini@konsulko.com>
On Thu, Jan 15, 2026 at 04:19:38PM -0600, Tom Rini wrote:
> [EXTERNAL MAIL]
>
> With commit 0535e46d55d7 ("scripts/dtc: Update to upstream version
> v1.7.2-35-g52f07dcca47c") it is now a fatal error to U-Boot if our
> device tree is not 8-byte aligned. In commit f613a6e15ef7 ("ARM: OMAP2+:
> Pad SPL binary to 8-byte alignment before DTB") Beleswar Padhi explains
> that we must have ALIGN(x) statements inside of a section to ensure that
> padding is included and not simply that the linker address counter is
> incremented. To that end, this patch:
> - Aligns the final section before _end (for U-Boot) or _image_binary_end
> (for xPL phases) by 8-bytes by adding '. = ALIGN(8);' to the final
> section before the symbol.
> - Remove a now-spurious '. = ALIGN(x);' statement that was intended to
> provide the above alignments.
> - Ensure that we do have alignment by adding an ASSERT so that when not
> aligned we fail to link (and explain why).
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Leo <ycliang@andestech.com>
> Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Rick Chen <rick@andestech.com>
> ---
> arch/riscv/cpu/u-boot-spl.lds | 4 ++++
> arch/riscv/cpu/u-boot.lds | 5 +++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
next prev parent reply other threads:[~2026-01-16 1:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 22:19 [PATCH 00/10] Update linker scripts to ensure appended device tree is correctly aligned Tom Rini
2026-01-15 22:19 ` [PATCH 01/10] Makefile: Have binary_size_check report only first match of _image_binary_end Tom Rini
2026-01-22 9:07 ` Marek Vasut
2026-01-22 14:21 ` Tom Rini
2026-01-15 22:19 ` [PATCH 02/10] arm: Update linker scripts to ensure appended device tree is aligned Tom Rini
2026-01-16 9:59 ` Ilias Apalodimas
2026-01-16 14:40 ` Tom Rini
2026-01-20 8:38 ` Ilias Apalodimas
2026-01-20 14:27 ` Tom Rini
2026-01-16 10:00 ` Michal Simek
2026-01-22 3:08 ` Fabio Estevam
2026-01-22 3:33 ` Fabio Estevam
2026-01-22 11:22 ` Marek Vasut
2026-01-22 14:23 ` Tom Rini
2026-01-22 18:47 ` Fabio Estevam
2026-01-22 19:10 ` Tom Rini
2026-01-22 19:19 ` Fabio Estevam
2026-01-22 19:28 ` Tom Rini
2026-01-22 19:32 ` Fabio Estevam
2026-01-22 19:42 ` Tom Rini
2026-01-22 22:56 ` Fabio Estevam
2026-01-22 23:24 ` Tom Rini
2026-01-23 0:25 ` Fabio Estevam
2026-01-23 0:52 ` Fabio Estevam
2026-01-23 14:27 ` Tom Rini
2026-01-23 15:45 ` Fabio Estevam
2026-01-23 15:50 ` Tom Rini
2026-01-22 14:25 ` Tom Rini
2026-02-04 21:16 ` Phil Sutter
2026-02-04 21:20 ` Tom Rini
2026-02-04 21:27 ` Phil Sutter
2026-02-04 21:31 ` Tom Rini
2026-02-04 21:40 ` Phil Sutter
2026-02-04 21:50 ` Tom Rini
2026-02-04 23:00 ` Phil Sutter
2026-02-04 23:04 ` Tom Rini
2026-02-04 23:29 ` Phil Sutter
2026-02-04 23:35 ` Tom Rini
2026-02-04 23:48 ` Phil Sutter
2026-02-05 18:01 ` Tom Rini
2026-01-15 22:19 ` [PATCH 03/10] m68k: " Tom Rini
2026-01-15 22:19 ` [PATCH 04/10] microblaze: " Tom Rini
2026-01-16 9:59 ` Michal Simek
2026-01-16 10:00 ` Ilias Apalodimas
2026-01-15 22:19 ` [PATCH 05/10] mips: " Tom Rini
2026-01-20 13:57 ` Daniel Schwierzeck
2026-01-15 22:19 ` [PATCH 06/10] nios2: " Tom Rini
2026-01-16 10:00 ` Ilias Apalodimas
2026-01-15 22:19 ` [PATCH 07/10] powerpc: " Tom Rini
2026-02-06 7:18 ` Christophe Leroy (CS GROUP)
2026-01-15 22:19 ` [PATCH 08/10] riscv: " Tom Rini
2026-01-16 1:27 ` Leo Liang [this message]
2026-01-16 9:49 ` Ilias Apalodimas
2026-01-15 22:19 ` [PATCH 09/10] sandbox: " Tom Rini
2026-01-15 22:19 ` [PATCH 10/10] x86: " Tom Rini
2026-01-20 18:08 ` [PATCH 00/10] Update linker scripts to ensure appended device tree is correctly aligned Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWmUHzFeByWHEyy5@swlinux02 \
--to=ycliang@andestech.com \
--cc=b-padhi@ti.com \
--cc=ilias.apalodimas@linaro.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=richard.henderson@linaro.org \
--cc=rick@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox