Re: [PATCH 02/17] spacemit: k1: enable SPL with debug UART

[Yao Zi <me@ziyao.cc>]

On Sat, Jan 17, 2026 at 02:01:36PM -0500, Raymond Mao wrote:
> From: Raymond Mao <raymond.mao@riscstar.com>
> 
> Add SPL support featuring debug UART output for early boot
> diagnostics on K1 SoC.
> 
> Signed-off-by: Raymond Mao <raymond.mao@riscstar.com>
> ---
>  arch/riscv/cpu/k1/Kconfig  |  2 ++
>  arch/riscv/dts/Makefile    |  1 +
>  arch/riscv/dts/k1-spl.dts  | 26 ++++++++++++++++++++++++++
>  arch/riscv/dts/k1.dtsi     |  2 +-
>  board/spacemit/k1/Makefile |  2 ++
>  board/spacemit/k1/spl.c    | 24 ++++++++++++++++++++++++
>  configs/k1_defconfig       | 21 ++++++++++++++++++++-
>  include/configs/k1.h       |  2 ++
>  8 files changed, 78 insertions(+), 2 deletions(-)
>  create mode 100644 arch/riscv/dts/k1-spl.dts
>  create mode 100644 board/spacemit/k1/spl.c

...

> diff --git a/configs/k1_defconfig b/configs/k1_defconfig
> index 0bdc3c800f0..f1a16735943 100644
> --- a/configs/k1_defconfig
> +++ b/configs/k1_defconfig
> @@ -3,7 +3,19 @@ CONFIG_SYS_MALLOC_LEN=0x1000000
>  CONFIG_NR_DRAM_BANKS=2
>  CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>  CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x1000000
> -CONFIG_DEFAULT_DEVICE_TREE="k1-bananapi-f3"
> +CONFIG_DEFAULT_DEVICE_TREE="k1-spl"
> +CONFIG_SPL=y
> +CONFIG_SPL_TEXT_BASE=0xC0801000

Please be consistent about cases in hex. Rest of the file uses
lowercases, and I think it's better to align.

> +CONFIG_SPL_MAX_SIZE=0x33000
> +CONFIG_SPL_BSS_START_ADDR=0xC0837000
> +CONFIG_SPL_BSS_MAX_SIZE=0x2000
> +# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
> +CONFIG_SPL_HAVE_INIT_STACK=y
> +CONFIG_SPL_STACK=0xC0840000
> +CONFIG_SPL_SIZE_LIMIT=0x31000
> +CONFIG_SPL_FIT_SIGNATURE=y
> +CONFIG_SPL_LOAD_FIT_ADDRESS=0x08000000
> +CONFIG_STACK_SIZE=0x100000
>  CONFIG_SYS_BOOTM_LEN=0xa000000
>  CONFIG_SYS_LOAD_ADDR=0x200000
>  CONFIG_ARCH_RV64I=y
> @@ -23,3 +35,10 @@ CONFIG_PINCTRL_SINGLE=y
>  CONFIG_RESET_SPACEMIT_K1=y
>  CONFIG_SYS_NS16550=y
>  CONFIG_SYS_NS16550_MEM32=y
> +CONFIG_DEBUG_UART=y
> +CONFIG_DEBUG_UART_BASE=0xD4017000
> +CONFIG_DEBUG_UART_CLOCK=14700000
> +CONFIG_DEBUG_UART_SHIFT=2
> +CONFIG_DEBUG_UART_NS16550=y
> +CONFIG_DEBUG_UART_ANNOUNCE=y

Regards,
Yao Zi