From: Yao Zi <me@ziyao.cc>
To: Raymond Mao <raymondmaoca@gmail.com>, u-boot@lists.denx.de
Cc: uboot@riscstar.com, Raymond Mao <raymond.mao@riscstar.com>,
Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
Tom Rini <trini@konsulko.com>, Lukasz Majewski <lukma@denx.de>,
Heiko Schocher <hs@nabladev.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Peng Fan <peng.fan@nxp.com>,
Randolph Sheng-Kai Lin <randolph@andestech.com>,
Yu-Chien Peter Lin <peter.lin@sifive.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Conor Dooley <conor.dooley@microchip.com>,
Jamie Gibbons <jamie.gibbons@microchip.com>,
Michal Simek <michal.simek@amd.com>,
Eric Schikschneit <eric.schikschneit@novatechautomation.com>,
Yixun Lan <dlan@gentoo.org>,
Junhui Liu <junhui.liu@pigmoral.tech>,
Sam Protsenko <semen.protsenko@linaro.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Casey Connolly <casey.connolly@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Aniket Limaye <a-limaye@ti.com>,
Utsav Agarwal <utsav.agarwal@analog.com>,
Greg Malysa <malysagreg@gmail.com>,
Justin Swartz <justin.swartz@risingedge.co.za>,
Nathan Barrett-Morrison <nathan.morrison@timesys.com>,
Vasileios Bimpikas <vasileios.bimpikas@analog.com>,
Arturs Artamonovs <arturs.artamonovs@analog.com>,
Ian Roberts <ian.roberts@timesys.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Henrik Grimler <henrik@grimler.se>,
Quentin Schulz <quentin.schulz@cherry.de>,
Kory Maincent <kory.maincent@bootlin.com>,
Paul Barker <paul.barker.ct@bp.renesas.com>,
Justin Klaassen <justin@tidylabs.net>,
Rui Miguel Silva <rui.silva@linaro.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Samuel Holland <samuel@sholland.org>,
Gabriel Fernandez <gabriel.fernandez@foss.st.com>,
Kever Yang <kever.yang@rock-chips.com>,
Jonas Karlman <jonas@kwiboo.se>,
Elaine Zhang <zhangqing@rock-chips.com>,
Joseph Chen <chenjh@rock-chips.com>
Subject: Re: [PATCH 04/17] reset: k1: add SPL support and enable TWSI8 reset
Date: Sun, 18 Jan 2026 09:10:00 +0000 [thread overview]
Message-ID: <aWyjUHwp2gzZfUYH@pie> (raw)
In-Reply-To: <20260117190231.977686-5-raymondmaoca@gmail.com>
On Sat, Jan 17, 2026 at 02:01:38PM -0500, Raymond Mao wrote:
> From: Raymond Mao <raymond.mao@riscstar.com>
>
> This commit enhances the K1 reset controller driver:
>
> 1. Enable SPL support
> - Select CONFIG_SPL_RESET_SPACEMIT_K1 for SPL builds
> - Reset controller is required during early boot for
> proper hardware initialization sequence
>
> 2. Remove TWSI8 (I2C8) reset restriction
> - TWSI8 is now fully controllable by reset controller
I don't think you change any real logics in the driver, so what fixes
the function of TWSI8 reset? This deserves more explanation.
> Signed-off-by: Raymond Mao <raymond.mao@riscstar.com>
> ---
> drivers/reset/Kconfig | 7 +++++++
> drivers/reset/Makefile | 2 +-
> drivers/reset/reset-spacemit-k1.c | 4 ----
> 3 files changed, 8 insertions(+), 5 deletions(-)
Regards,
Yao Zi
next prev parent reply other threads:[~2026-01-18 13:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-17 19:01 [PATCH 00/17] Add board support for Spacemit K1 SoC in SPL Raymond Mao
2026-01-17 19:01 ` [PATCH 01/17] spacemit: k1: support multi-board infrastructure Raymond Mao
2026-01-23 10:27 ` Heinrich Schuchardt
2026-01-23 10:46 ` Heinrich Schuchardt
2026-01-17 19:01 ` [PATCH 02/17] spacemit: k1: enable SPL with debug UART Raymond Mao
2026-01-18 8:50 ` Yao Zi
2026-01-23 14:51 ` Heinrich Schuchardt
2026-02-03 14:24 ` Raymond Mao
2026-01-17 19:01 ` [PATCH 03/17] configs: k1: enable early timer support Raymond Mao
2026-01-17 19:01 ` [PATCH 04/17] reset: k1: add SPL support and enable TWSI8 reset Raymond Mao
2026-01-18 9:10 ` Yao Zi [this message]
2026-01-21 23:17 ` Raymond Mao
2026-01-17 19:01 ` [PATCH 05/17] dt-bindings: clock: import k1-syscon from upstream Raymond Mao
2026-01-17 19:01 ` [PATCH 06/17] dts: k1: import dts file from upstream folder Raymond Mao
2026-01-17 23:03 ` Yixun Lan
2026-01-18 8:56 ` Yao Zi
2026-01-17 19:01 ` [PATCH 07/17] clk: spacemit: Add support for K1 SoC Raymond Mao
2026-01-17 19:01 ` [PATCH 08/17] dts: k1: enable clocks in SPL Raymond Mao
2026-01-17 19:01 ` [PATCH 09/17] board: k1: initialize clock and serial devices " Raymond Mao
2026-01-17 19:01 ` [PATCH 10/17] configs: k1: add default option for clock driver " Raymond Mao
2026-01-17 19:01 ` [PATCH 11/17] i2c: k1: add I2C driver support Raymond Mao
2026-01-19 5:24 ` Heiko Schocher
2026-01-17 19:01 ` [PATCH 12/17] dt-bindings: pinctrl: add k1 support Raymond Mao
2026-01-18 9:26 ` Yao Zi
2026-01-21 23:20 ` Raymond Mao
2026-01-22 14:55 ` Yao Zi
2026-01-17 19:01 ` [PATCH 13/17] spacemit: k1: add TLV EEPROM support in SPL Raymond Mao
2026-01-17 19:01 ` [PATCH 14/17] spacemit: k1: Add DDR firmware support to SPL Raymond Mao
2026-01-19 9:40 ` Yao Zi
2026-01-21 23:24 ` Raymond Mao
2026-01-22 14:43 ` Yao Zi
2026-01-17 19:01 ` [PATCH 15/17] power: pmic: add support for Spacemit P1 PMIC Raymond Mao
2026-01-17 19:01 ` [PATCH 16/17] power: regulator: add support for Spacemit P1 SoC Raymond Mao
2026-01-17 19:01 ` [PATCH 17/17] board: k1: enable pmic in spl Raymond Mao
2026-01-17 23:13 ` [PATCH 00/17] Add board support for Spacemit K1 SoC in SPL Yixun Lan
2026-01-22 8:29 ` Heinrich Schuchardt
2026-01-23 14:58 ` Raymond Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWyjUHwp2gzZfUYH@pie \
--to=me@ziyao.cc \
--cc=a-limaye@ti.com \
--cc=ansuelsmth@gmail.com \
--cc=arturs.artamonovs@analog.com \
--cc=casey.connolly@linaro.org \
--cc=chenjh@rock-chips.com \
--cc=clamor95@gmail.com \
--cc=conor.dooley@microchip.com \
--cc=dlan@gentoo.org \
--cc=eric.schikschneit@novatechautomation.com \
--cc=gabriel.fernandez@foss.st.com \
--cc=henrik@grimler.se \
--cc=hs@nabladev.com \
--cc=ian.roberts@timesys.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jamie.gibbons@microchip.com \
--cc=jh80.chung@samsung.com \
--cc=jonas@kwiboo.se \
--cc=junhui.liu@pigmoral.tech \
--cc=justin.swartz@risingedge.co.za \
--cc=justin@tidylabs.net \
--cc=kever.yang@rock-chips.com \
--cc=kory.maincent@bootlin.com \
--cc=lukma@denx.de \
--cc=malysagreg@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=michal.simek@amd.com \
--cc=nathan.morrison@timesys.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=peng.fan@nxp.com \
--cc=peter.lin@sifive.com \
--cc=quentin.schulz@cherry.de \
--cc=randolph@andestech.com \
--cc=raymond.mao@riscstar.com \
--cc=raymondmaoca@gmail.com \
--cc=rick@andestech.com \
--cc=rui.silva@linaro.org \
--cc=samuel@sholland.org \
--cc=semen.protsenko@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot@riscstar.com \
--cc=utsav.agarwal@analog.com \
--cc=vasileios.bimpikas@analog.com \
--cc=xypron.glpk@gmx.de \
--cc=ycliang@andestech.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox