public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Mateus Lima <mateuslima.ti@gmail.com>
Cc: alison.wang@nxp.com, u-boot@lists.denx.de
Subject: Re: [PATCH v2] armv7: Add CPLD support via IFC to the ls1021a-iot board.
Date: Mon, 26 Jan 2026 10:11:20 +0800	[thread overview]
Message-ID: <aXbNSAUDjG83gKsq@shlinux89> (raw)
In-Reply-To: <CAP8WwTH5=Aqy+QLLRv9QGJ3RTbwyMXA88BsO4eJOB-WawHfHMg@mail.gmail.com>

On Thu, Jan 22, 2026 at 10:12:36AM -0300, Mateus Lima wrote:
>On Wed, Jan 21, 2026 at 11:13 PM Peng Fan <peng.fan@oss.nxp.com> wrote:
>
>> On Tue, Jan 13, 2026 at 11:23:01AM -0300, Mateus Lima Alves wrote:
>> >This patch adds CPLD support via IFC to the ls1021a-iot board.
>> >
>> >Signed-off-by: Mateus Lima Alves <mateuslima.ti@gmail.com>
>>
>> CI report build failure.
>>
>>   CC      drivers/video/hitachi-tx10d07vm0baa.o
>> In file included from drivers/misc/fsl_ifc.c:8:
>> include/fsl_ifc.h:16:10: fatal error: asm/ppc.h: No such file or directory
>>    16 | #include <asm/ppc.h>
>>       |          ^~~~~~~~~~~
>> compilation terminated.
>> make[3]: *** [scripts/Makefile.build:271: drivers/misc/fsl_ifc.o] Error 1
>> make[2]: *** [scripts/Makefile.build:492: drivers/misc] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>>   CC      drivers/rtc/ht1380.o
>>   CC      drivers/video/hitachi_tx18d42vm_lcd.o
>>   CC      drivers/rtc/i2c_rtc_emul.o
>>
>> make[1]: *** [Makefile:2191: drivers] Error 2
>> make: *** [Makefile:362: __build_one_by_one] Error 2
>> Cleaning up project directory and file based variables
>>
>> Regards
>> Peng
>>
>Hi Peng,
>
>Thank you for the test, and apologies for not having validated the patch on
>other targets.
>In fact, this driver was not being used by any target (neither ARM nor PPC)
>and after this patch it became enabled again. However, PPC targets fail
>when trying to include the asm/ppc.h header, which is not available for
>some reason.
>
>For now, I am thinking of submitting a v3 of the patch adding an explicit
>dependency on ARM, something like:
>
>+ depends on ARM
>
>This way we would avoid building the driver for PPC targets.
>What do you think about this approach?

It should be ok.

Thanks,
Peng

>
>Thanks again for the report and the feedback.
>
>BR,
>Mateus

  parent reply	other threads:[~2026-01-26  2:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 14:23 [PATCH v2] armv7: Add CPLD support via IFC to the ls1021a-iot board Mateus Lima Alves
2026-01-22  3:28 ` Peng Fan
2026-01-22 13:12   ` Mateus Lima
2026-01-23  2:11     ` Mateus Lima
2026-01-26  2:11     ` Peng Fan [this message]
2026-01-28 16:47       ` Tom Rini
2026-01-28 17:06         ` Mateus Lima
2026-01-28 17:46           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXbNSAUDjG83gKsq@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=alison.wang@nxp.com \
    --cc=mateuslima.ti@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox