public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
Cc: trini@konsulko.com, casey.connolly@linaro.org,
	neil.armstrong@linaro.org, lukma@denx.de,
	aswin.murugan@oss.qualcomm.com, rui.silva@linaro.org,
	david.wronek@mainlining.org, ilias.apalodimas@linaro.org,
	luca.weiss@fairphone.com, jorge.ramirez@oss.qualcomm.com,
	stephan.gerhold@linaro.org, quic_varada@quicinc.com,
	u-boot-qcom@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH v1 2/3] arm: snapdragon: Remove QCS615 MMC node disable fixup
Date: Tue, 27 Jan 2026 12:48:43 +0530	[thread overview]
Message-ID: <aXhm01e0EgM7HyKz@sumit-xelite> (raw)
In-Reply-To: <20260126155938.2717540-3-balaji.selvanathan@oss.qualcomm.com>

On Mon, Jan 26, 2026 at 09:29:37PM +0530, Balaji Selvanathan wrote:
> Remove the QCS615-specific device tree fixup that was disabling the
> MMC node at /soc@0/mmc@7c4000. This fixup is no longer needed as the
> MMC/SDCC functionality should now be properly supported through the
> clock infrastructure and device tree configuration.
> 
> This patch is based on the changes in the upstream submission:
> https://lore.kernel.org/u-boot/20260113115404.1448759-4-aswin.murugan@oss.qualcomm.com/

Rather drop this patch entirely since fixing eMMC as you did as part of
patch #1 is the right thing to do for upstream. The series you
referenced can be adjusted accordingly.

-Sumit

> 
> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
> ---
>  arch/arm/mach-snapdragon/of_fixup.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/arch/arm/mach-snapdragon/of_fixup.c b/arch/arm/mach-snapdragon/of_fixup.c
> index 9b6e1847489..216cc816d95 100644
> --- a/arch/arm/mach-snapdragon/of_fixup.c
> +++ b/arch/arm/mach-snapdragon/of_fixup.c
> @@ -194,20 +194,6 @@ EVENT_SPY_FULL(EVT_OF_LIVE_BUILT, qcom_of_fixup_nodes);
>  static void soc_specific_fixups(struct fdt_header *fdt)
>  {
>  	int ret;
> -
> -	/* QCS615-specific fixup: Disable MMC node */
> -	if (fdt_node_check_compatible(fdt, 0, "qcom,qcs615") == 0) {
> -		int path_offset;
> -		char prop_val[] = "disabled";
> -
> -		path_offset = fdt_path_offset(fdt, "/soc@0/mmc@7c4000");
> -		if (path_offset >= 0) {
> -			ret = fixup_dt_node(fdt, path_offset, "status",
> -					    (void *)prop_val, SET_PROP_STRING);
> -			if (ret)
> -				log_err("Failed to disable MMC node for QCS615: %d\n", ret);
> -		}
> -	}
>  }
>  
>  int ft_board_setup(void __maybe_unused *blob, struct bd_info __maybe_unused *bd)
> -- 
> 2.34.1
> 

  reply	other threads:[~2026-01-27  7:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 15:59 [PATCH v1 0/3] Enable eMMC/SDCC support for QCS615 platform Balaji Selvanathan
2026-01-26 15:59 ` [PATCH v1 1/3] clk: qcom: Add QCS615 SDCC clock support and RPMH-CLK compatibility Balaji Selvanathan
2026-01-27  6:28   ` Sumit Garg
2026-02-09 18:56   ` Casey Connolly
2026-01-26 15:59 ` [PATCH v1 2/3] arm: snapdragon: Remove QCS615 MMC node disable fixup Balaji Selvanathan
2026-01-27  7:18   ` Sumit Garg [this message]
2026-01-26 15:59 ` [PATCH v1 3/3] board: qualcomm: Remove SCSI scan from default preboot environment Balaji Selvanathan
2026-01-27  7:25   ` Sumit Garg
2026-02-09 19:16   ` Casey Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXhm01e0EgM7HyKz@sumit-xelite \
    --to=sumit.garg@kernel.org \
    --cc=aswin.murugan@oss.qualcomm.com \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=david.wronek@mainlining.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=luca.weiss@fairphone.com \
    --cc=lukma@denx.de \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_varada@quicinc.com \
    --cc=rui.silva@linaro.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox