From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B52B1EA7948 for ; Wed, 4 Feb 2026 21:40:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B4F283015; Wed, 4 Feb 2026 22:40:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=nwl.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nwl.cc header.i=@nwl.cc header.b="gYgwRQ3s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D3C0838FA; Wed, 4 Feb 2026 22:40:19 +0100 (CET) Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8190D8063E for ; Wed, 4 Feb 2026 22:40:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=nwl.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=phil@nwl.cc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nwl.cc; s=mail2022; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QMYYJBi3O9yc4d5/fagmQSMD97GVu0OP1ZDkbXysBDc=; b=gYgwRQ3sDldsgai/P5/pY6mL3+ df4if4xzPh1KmVhjibbu7amqJLKtvN+lgjNtcy0bEYF4pfkCL4pMcMVBppP09yqqVRMGL+5OIuiFJ NlFrihj0MSaS8N4b8bGMIbA6/pKC7vjASiAlWeOGnRVKlHo5wZIFnY1h2lBGMh/NQHs2ows8kq8EG qGQz6JOth3RIgwMrkQSsssR0/ys2qvOyu48IKznxzjN+41B5b0SvXmY0tJnalvr/R14Nf0aSg96T3 J4vIj47AfNzlcRKB8NXJkLUfZFdbuU/DFawoqYQFVp4axsoGFJTecpqKPOcYhtZ05Ea6gLlKjgpwE fQu9c7Eg==; Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.98.2) (envelope-from ) id 1vnkbc-000000002KM-15r2; Wed, 04 Feb 2026 22:40:12 +0100 Date: Wed, 4 Feb 2026 22:40:12 +0100 From: Phil Sutter To: Tom Rini Cc: u-boot@lists.denx.de, Marek Vasut , Beleswar Padhi , "NXP i.MX U-Boot Team" , Adam Ford , Andre Przywara , Aspeed BMC SW team , Chia-Wei Wang , Eugen Hristev , Fabio Estevam , Ilias Apalodimas , Jagan Teki , Joel Stanley , Kever Yang , Michal Simek , Philipp Tomsich , Richard Henderson , Ryan Chen , Stefano Babic Subject: Re: [PATCH 02/10] arm: Update linker scripts to ensure appended device tree is aligned Message-ID: Mail-Followup-To: Phil Sutter , Tom Rini , u-boot@lists.denx.de, Marek Vasut , Beleswar Padhi , "NXP i.MX U-Boot Team" , Adam Ford , Andre Przywara , Aspeed BMC SW team , Chia-Wei Wang , Eugen Hristev , Fabio Estevam , Ilias Apalodimas , Jagan Teki , Joel Stanley , Kever Yang , Michal Simek , Philipp Tomsich , Richard Henderson , Ryan Chen , Stefano Babic References: <20260115222828.3931345-1-trini@konsulko.com> <20260115222828.3931345-3-trini@konsulko.com> <20260204212010.GD2603314@bill-the-cat> <20260204213139.GE2603314@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260204213139.GE2603314@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Feb 04, 2026 at 03:31:39PM -0600, Tom Rini wrote: > On Wed, Feb 04, 2026 at 10:27:11PM +0100, Phil Sutter wrote: > > On Wed, Feb 04, 2026 at 03:20:10PM -0600, Tom Rini wrote: > > > On Wed, Feb 04, 2026 at 10:16:12PM +0100, Phil Sutter wrote: > > > > Hi, > > > > > > > > On Thu, Jan 15, 2026 at 04:19:32PM -0600, Tom Rini wrote: > > > > > With commit 0535e46d55d7 ("scripts/dtc: Update to upstream version > > > > > v1.7.2-35-g52f07dcca47c") it is now a fatal error to U-Boot if our > > > > > device tree is not 8-byte aligned. In commit f613a6e15ef7 ("ARM: OMAP2+: > > > > > Pad SPL binary to 8-byte alignment before DTB") Beleswar Padhi explains > > > > > that we must have ALIGN(x) statements inside of a section to ensure that > > > > > padding is included and not simply that the linker address counter is > > > > > incremented. To that end, this patch: > > > > > - Expands some linker sections to be more readable when adding a second > > > > > statement to the section. > > > > > - Aligns the final section before _end (for U-Boot) or > > > > > _image_binary_end or __bss_end (for xPL phases) by 8-bytes by adding > > > > > '. = ALIGN(8);' to the final section before the symbol. > > > > > - Ensure that we do have alignment by adding an ASSERT so that when not > > > > > aligned we fail to link (and explain why). > > > > > - Remove now-spurious '. = ALIGN(x);' statements that were intended to > > > > > provide the above alignments. > > > > > > > > > > Signed-off-by: Tom Rini > > > > > > > > For unclear reasons, this seems to break boot via xmodem protocol on my > > > > Synology DS414. I found this commit via 'git bisect'. The symptom is: > > > > > > > > | kwboot version 2026.04-rc1-00098-g6ad0cf8f83db > > > > | Detected kwbimage v1 with SPI boot signature > > > > | Patching image boot signature to UART > > > > | Aligning image header to Xmodem block size > > > > | Sending boot message. Please reboot the target...\ > > > > | Sending boot image header (67584 bytes)... > > > > | 0 % [......................................................................] > > > > | 13 % [......................................................................] > > > > | 26 % [......................................................................] > > > > | 39 % [......................................................................] > > > > | 53 % [......................................................................] > > > > | 66 % [......................................................................] > > > > | 79 % [......................................................................] > > > > | 92 % [...................................... ] > > > > | Done > > > > | Missing DTB > > > > | spl_init() failed: -2 > > > > | ### ERROR ### Please RESET the board ### > > > > | > > > > | > > > > | xmodem: Connection timed out > > > > > > > > Debug printf()s in fdtdec_prepare_fdt() show that fdt_check_header() > > > > returns -FDT_ERR_BADMAGIC. > > > > > > > > With HEAD at a8d982e1f1726 ("x86: cpu: Fix crash on FTRACE enabled > > > > builds"), reverting arch/arm/cpu/u-boot-spl.lds like so: > > > > > > > > | @@ -41,14 +41,21 @@ SECTIONS > > > > | __binman_sym_start = .; > > > > | KEEP(*(SORT(.binman_sym*))); > > > > | __binman_sym_end = .; > > > > | - . = ALIGN(8); > > > > | } > > > > | > > > > | + . = ALIGN(4); /* critical! */ > > > > | __image_copy_end = .; > > > > | + .rel.dyn : { > > > > | + __rel_dyn_start = .; > > > > | + *(.rel*) > > > > | + __rel_dyn_end = .; > > > > | + } > > > > | + > > > > | + . = ALIGN(8); > > > > | _image_binary_end = .; > > > > | _end = .; > > > > | > > > > | - .bss : { > > > > | + .bss __rel_dyn_start (OVERLAY) : { > > > > | __bss_start = .; > > > > | *(.bss*) > > > > | . = ALIGN(8); > > > > > > > > The SPL image starts up again and continues loading the real uboot > > > > image. Note that I have no idea what these changes actually do, so I > > > > need instructions if I should dig further. > > > > > > Does: > > > https://patchwork.ozlabs.org/project/uboot/patch/20260130183635.2612933-1-trini@konsulko.com/ > > > fix it? > > > > Sadly not, same result. > > Ugh. What file, specifically, do you send via xmodem? And so that maybe > I can more easily replicate the failure, are you using the kernel.org > gcc-14.2.0 toolchain or something else? I am building with a custom-built arm-openadk-linux-uclibceabi-gcc version 14.3.0. Basically what I run is: MYENV='ARCH=arm CROSS_COMPILE=~/git/openadk-ds414/toolchain_synology-ds414_uclibc-ng_softfp_eabi_arm/usr/bin/arm-openadk-linux-uclibceabi-' make $MYENV clean && \ for f in $(ls u-boot*.kwb 2>/dev/null); do rm $f; done && \ make $MYENV ds414_defconfig && \ make $MYENV -j12 && \ ./tools/kwboot -a -t -p -b u-boot-*spl.kwb /dev/ttyUSB0 With current uboot, this should be u-boot-with-spl.kwb image. With said patch reverted (or the above changes applied), I produce a working u-boot-with-spl.kwb which loads and boots linux from flash. So my toolchain is at least not totally broken. ;) Cheers, Phil