Re: [PATCH v1 07/12] arm: imx952: Add watchdog base address definitions

Fabio Estevam
2026-02-06T03:59:37Z

Hi Alice,

On Thu, Feb 5, 2026 at 12:16 PM <alice.guo@oss.nxp.com> wrote:
>
> From: Alice Guo <alice.guo@nxp.com>
>
> Add WDG3, WDG4 and WDG5 base addresses for i.MX952.
>
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
> arch/arm/include/asm/arch-imx9/imx-regs.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-imx9/imx-regs.h b/arch/arm/include/asm/arch-imx9/imx-regs.h
> index 2d084e5227a..7c7a34f74af 100644
> --- a/arch/arm/include/asm/arch-imx9/imx-regs.h
> +++ b/arch/arm/include/asm/arch-imx9/imx-regs.h
> @@ -17,6 +17,11 @@
>
> #define ANATOP_BASE_ADDR 0x44480000UL
>
> +#ifdef CONFIG_IMX952
> +#define WDG3_BASE_ADDR 0x420b0000UL
> +#define WDG4_BASE_ADDR 0x420c0000UL
> +#define WDG5_BASE_ADDR 0x420d0000UL
> +#else
> #ifdef CONFIG_IMX94
> #define WDG3_BASE_ADDR 0x49220000UL
> #define WDG4_BASE_ADDR 0x49230000UL
> @@ -25,6 +30,7 @@
> #define WDG4_BASE_ADDR 0x424a0000UL
> #endif
> #define WDG5_BASE_ADDR 0x424b0000UL
> +#endif

Can we improve this and retrieve the watchdog base address from the devicetree?