回复: [PATCH v1 07/12] arm: imx952: Add watchdog base address definitions

Alice Guo (OSS)
2026-02-09T10:24:39Z

> -----邮件原件-----
> 发件人: Fabio Estevam <festevam@gmail.com>
> 发送时间: 2026年2月6日 11:59
> 收件人: Alice Guo (OSS) <alice.guo@oss.nxp.com>
> 抄送: dl-uboot-imx <uboot-imx@nxp.com>; u-boot@lists.denx.de; Stefano
> Babic <sbabic@nabladev.com>; Tom Rini <trini@konsulko.com>; Peng Fan
> <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jindong Yue
> <jindong.yue@nxp.com>; Jacky Bai <ping.bai@nxp.com>; Marek Vasut
> <marek.vasut+renesas@mailbox.org>; Rasmus Villemoes <ravi@prevas.dk>;
> Ross, Fedor <fedor.ross@ifm.com>; João Paulo Gonçalves
> <joao.goncalves@toradex.com>; Patrice Chotard
> <patrice.chotard@foss.st.com>; Valentin Caron <valentin.caron@foss.st.com>;
> Vinh Nguyen <vinh.nguyen.xz@renesas.com>; Sam Protsenko
> <semen.protsenko@linaro.org>; Ranjani Vaidyanathan
> <ranjani.vaidyanathan@nxp.com>; Ji Luo <ji.luo@nxp.com>; Frank Li
> <frank.li@nxp.com>; Sumit Garg <sumit.garg@oss.qualcomm.com>; Adam
> Ford <aford173@gmail.com>; Frieder Schrempf
> <frieder.schrempf@kontron.de>; David Zang <davidzangcs@gmail.com>;
> Andrew Goodbody <andrew.goodbody@linaro.org>; Sumit Garg
> <sumit.garg@kernel.org>; Marek Vasut <marex@nabladev.com>; Joseph Guo
> <qijian.guo@nxp.com>; tharvey@gateworks.com; Alice Guo
> <alice.guo@nxp.com>
> 主题: Re: [PATCH v1 07/12] arm: imx952: Add watchdog base address
> definitions
>
> Hi Alice,
>
> On Thu, Feb 5, 2026 at 12:16 PM <alice.guo@oss.nxp.com> wrote:
> >
> > From: Alice Guo <alice.guo@nxp.com>
> >
> > Add WDG3, WDG4 and WDG5 base addresses for i.MX952.
> >
> > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > ---
> > arch/arm/include/asm/arch-imx9/imx-regs.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/include/asm/arch-imx9/imx-regs.h
> b/arch/arm/include/asm/arch-imx9/imx-regs.h
> > index 2d084e5227a..7c7a34f74af 100644
> > --- a/arch/arm/include/asm/arch-imx9/imx-regs.h
> > +++ b/arch/arm/include/asm/arch-imx9/imx-regs.h
> > @@ -17,6 +17,11 @@
> >
> > #define ANATOP_BASE_ADDR 0x44480000UL
> >
> > +#ifdef CONFIG_IMX952
> > +#define WDG3_BASE_ADDR 0x420b0000UL
> > +#define WDG4_BASE_ADDR 0x420c0000UL
> > +#define WDG5_BASE_ADDR 0x420d0000UL
> > +#else
> > #ifdef CONFIG_IMX94
> > #define WDG3_BASE_ADDR 0x49220000UL
> > #define WDG4_BASE_ADDR 0x49230000UL
> > @@ -25,6 +30,7 @@
> > #define WDG4_BASE_ADDR 0x424a0000UL
> > #endif
> > #define WDG5_BASE_ADDR 0x424b0000UL
> > +#endif
>
> Can we improve this and retrieve the watchdog base address from the
> devicetree?

Hi Fabio,

Thanks for the suggestion. Using the device tree would be cleaner, but this patch follows the existing i.MX9 imx-regs.h pattern. I suggest we merge this patch to keep consistency with the current codebase. Thoughts?

Best regards,
Alice Guo