From: Lukas Timmermann <linux@timmermann.space>
To: Minkyu Kang <mk7.kang@samsung.com>,
'Lukas Timmermann' <uboot@timmermann.space>,
u-boot@lists.denx.de
Cc: "'Alif Zakuan Yuslaimi'" <alif.zakuan.yuslaimi@altera.com>,
"'Arturs Artamonovs'" <arturs.artamonovs@analog.com>,
"'Eoin Dickson'" <eoin.dickson@microchip.com>,
"'Greg Malysa'" <malysagreg@gmail.com>,
"'Heiko Schocher'" <hs@nabladev.com>,
"'Henrik Grimler'" <henrik@grimler.se>,
"'Ian Roberts'" <ian.roberts@timesys.com>,
"'J. Neuschäfer'" <j.ne@posteo.net>,
"'Jerome Forissier'" <jerome.forissier@linaro.org>,
"'Kory Maincent (TI.com)'" <kory.maincent@bootlin.com>,
"'Marek Vasut'" <marek.vasut+renesas@mailbox.org>,
"'Mattijs Korpershoek'" <mkorpershoek@kernel.org>,
"'Nathan Barrett-Morrison'" <nathan.morrison@timesys.com>,
"'Neil Armstrong'" <neil.armstrong@linaro.org>,
"'Oliver Gaskell'" <Oliver.Gaskell@analog.com>,
"'Patrice Chotard'" <patrice.chotard@foss.st.com>,
"'Peng Fan'" <peng.fan@nxp.com>,
"'Philip Molloy'" <philip.molloy@analog.com>,
"'Simon Glass'" <sjg@chromium.org>,
"'Stefan Roese'" <stefan.roese@mailbox.org>,
"'Tom Rini'" <trini@konsulko.com>,
"'Utsav Agarwal'" <utsav.agarwal@analog.com>,
"'Vasileios Bimpikas'" <vasileios.bimpikas@analog.com>,
"'Yao Zi'" <ziyao@disroot.org>
Subject: Re: [PATCH v2 0/2] Modern pinctrl for Exynos5250 devices
Date: Mon, 9 Feb 2026 19:02:27 +0100 [thread overview]
Message-ID: <aYodQu98Sv3L06EU@archstation> (raw)
In-Reply-To: <0e2901dc941e$a80ac4c0$f8204e40$@samsung.com>
No worries. I'm still interested in upstreaming this patch and the
corresponding DT for my device into the linux kernel.
The error you've got would be expected if you didn't disable the pinctrl part of the
older S5P (see Patch v2 1/2). Please be sure to disable it in order for my suggested driver
to compile correctly. The older driver didn't support newer style DTs
pinctrl, which my device uses and will be upstreamed soon.
I acknowledge, that this is a less than optimal solution and I'm willing
to discuss alternatives. The issue appears because the older pinmux
driver did much more than the newer pinctrl driver I've written does.
Also I just noticed that I left behind "Copyright Linaro Ltd." in the header of
pinctrl-exynos5250.c so please don't merge this yet. A v3 is obligatory
at this point.
Best regards
Lukas Timmermann
On Mon, Feb 02, 2026 at 05:33:50PM +0900, Minkyu Kang wrote:
> Dear Timmermann,
>
> Sorry I missed this patch..
>
> I tested this patch but I've got compile errors.
> Could you please check?; tested with smdk5250.
>
> /opt/toolchain/gcc-arm-none-eabi-10.3-2021.10/bin/arm-none-eabi-ld: drivers/gpio/s5p_gpio.o: in function `gpio_set_pull':
> /home/work/git/u-boot-samsung/drivers/gpio/s5p_gpio.c:240: multiple definition of `gpio_set_pull'; arch/arm/mach-exynos/pinmux.o:pinmux.c:(.text.gpio_set_pull+0x0): first defined here
> /opt/toolchain/gcc-arm-none-eabi-10.3-2021.10/bin/arm-none-eabi-ld: drivers/gpio/s5p_gpio.o: in function `gpio_set_drv':
> /home/work/git/u-boot-samsung/drivers/gpio/s5p_gpio.c:246: multiple definition of `gpio_set_drv'; arch/arm/mach-exynos/pinmux.o:pinmux.c:(.text.gpio_set_drv+0x0): first defined here
> /opt/toolchain/gcc-arm-none-eabi-10.3-2021.10/bin/arm-none-eabi-ld: drivers/gpio/s5p_gpio.o: in function `gpio_cfg_pin':
> /home/work/git/u-boot-samsung/drivers/gpio/s5p_gpio.c:252: multiple definition of `gpio_cfg_pin'; arch/arm/mach-exynos/pinmux.o:/home/work/git/u-boot-samsung/arch/arm/mach-exynos/pinmux.c:952: first defined here
>
> Thanks,
> Minkyu Kang.
>
prev parent reply other threads:[~2026-02-09 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251103191515epcas1p209371cc60bfa83914a77194d3899619b@epcas1p2.samsung.com>
2025-11-03 19:10 ` [PATCH v2 0/2] Modern pinctrl for Exynos5250 devices Lukas Timmermann
2025-11-03 19:10 ` [PATCH v2 1/2] gpio: s5p_gpio: Add config option for s5p_gpio driver Lukas Timmermann
2025-11-03 19:10 ` [PATCH v2 2/2] pinctrl: exynos: Add exynos5250 driver Lukas Timmermann
2026-02-02 8:33 ` [PATCH v2 0/2] Modern pinctrl for Exynos5250 devices Minkyu Kang
2026-02-09 18:02 ` Lukas Timmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYodQu98Sv3L06EU@archstation \
--to=linux@timmermann.space \
--cc=Oliver.Gaskell@analog.com \
--cc=alif.zakuan.yuslaimi@altera.com \
--cc=arturs.artamonovs@analog.com \
--cc=eoin.dickson@microchip.com \
--cc=henrik@grimler.se \
--cc=hs@nabladev.com \
--cc=ian.roberts@timesys.com \
--cc=j.ne@posteo.net \
--cc=jerome.forissier@linaro.org \
--cc=kory.maincent@bootlin.com \
--cc=malysagreg@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mk7.kang@samsung.com \
--cc=mkorpershoek@kernel.org \
--cc=nathan.morrison@timesys.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=philip.molloy@analog.com \
--cc=sjg@chromium.org \
--cc=stefan.roese@mailbox.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot@timmermann.space \
--cc=utsav.agarwal@analog.com \
--cc=vasileios.bimpikas@analog.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox