Re: [PATCH] efi_loader: fix ecpt size computation

["Vincent Stehlé" <vincent.stehle@arm.com>]

On Wed, Feb 11, 2026 at 12:50:38PM +0100, Heinrich Schuchardt wrote:
> On 2/11/26 12:47, Vincent Stehlé wrote:
> > On Wed, Feb 11, 2026 at 10:56:30AM +0100, Heinrich Schuchardt wrote:
> > > On 2/11/26 10:33, Vincent Stehlé wrote:
(snip)
> > > > diff --git a/lib/efi_loader/efi_conformance.c b/lib/efi_loader/efi_conformance.c
> > > > index 2bae93a94bd..9768b5ae824 100644
> > > > --- a/lib/efi_loader/efi_conformance.c
> > > > +++ b/lib/efi_loader/efi_conformance.c
> > > > @@ -13,8 +13,12 @@
> > > >    #include <malloc.h>
> > > >    static const efi_guid_t efi_ecpt_guid = EFI_CONFORMANCE_PROFILES_TABLE_GUID;
> > > > -static const efi_guid_t efi_ebbr_2_1_guid =
> > > > -	EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID;
> > > > +
> > > > +static const efi_guid_t profiles[] = {
> > > 
> > > As profiles[] is not used outside efi_ecpt_register(), there is no need to
> > > make it a static variable.
> > 
> > I am not sure why a "global" symbol would be better than a static one, but if
> > you like this solution we could make the profiles[] array extern.
> 
> Sorry to not be clear. I wanted to suggest a local symbol.

Hi Heinrich,

The profiles[] array is "local" to the efi_conformance.c file already as it has
internal linkage, thanks to the static specifier. Is this the symbol name you
would like to prefix maybe?

	static const efi_guid_t efi_conformance_profiles[] = {
		...

Best regards,
Vincent.

> 
> Best regards
> 
> Heinrich