From: Sumit Garg <sumit.garg@kernel.org>
To: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
Cc: casey.connolly@linaro.org, u-boot@lists.denx.de,
u-boot-qcom@groups.io, trini@konsulko.com,
jh80.chung@samsung.com, peng.fan@nxp.com,
neil.armstrong@linaro.org, tien.fong.chee@altera.com,
miquel.raynal@bootlin.com, msp@baylibre.com,
alif.zakuan.yuslaimi@altera.com,
balaji.selvanathan@oss.qualcomm.com, w.egorov@phytec.de,
varadarajan.narayanan@oss.qualcomm.com, rui.silva@linaro.org,
ilias.apalodimas@linaro.org, me@samcday.com,
marek.vasut+renesas@mailbox.org
Subject: Re: [PATCH v8 2/4] power-domain: Add warning when power-domain driver is missing
Date: Fri, 20 Feb 2026 14:31:56 +0530 [thread overview]
Message-ID: <aZgjBLn0fiaXL6rY@sumit-xelite> (raw)
In-Reply-To: <20260213111009.1254360-3-aswin.murugan@oss.qualcomm.com>
On Fri, Feb 13, 2026 at 04:40:07PM +0530, Aswin Murugan wrote:
> Update dev_power_domain_ctrl() to log a warning if the power-domain
> driver is not found (-ENODEV). Return 0 in this case to allow continued
> execution, while preserving error handling for other failures.
>
> Reviewed-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
> Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
> ---
> Changes in v8:
> - No changes in v8
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
>
> Changes in v7:
> - Cleaned up the warning logic in drivers/power/domain/power-domain-uclass.c
> when power-domain driver is missing
>
> Changes in v6:
> - Newly added the change in drivers/power/domain/power-domain-uclass.c to give warning
> when power-domain driver is missing
> ---
> drivers/power/domain/power-domain-uclass.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/power/domain/power-domain-uclass.c b/drivers/power/domain/power-domain-uclass.c
> index d9fa8ad4bd2..52f56f57658 100644
> --- a/drivers/power/domain/power-domain-uclass.c
> +++ b/drivers/power/domain/power-domain-uclass.c
> @@ -10,6 +10,7 @@
> #include <malloc.h>
> #include <power-domain.h>
> #include <power-domain-uclass.h>
> +#include <dm/device_compat.h>
> #include <dm/device-internal.h>
>
> struct power_domain_priv {
> @@ -184,6 +185,12 @@ static int dev_power_domain_ctrl(struct udevice *dev, bool on)
> "#power-domain-cells", 0);
> for (i = 0; i < count; i++) {
> ret = power_domain_get_by_index(dev, &pd, i);
> +
> + if (ret == -ENODEV) {
> + dev_warn(dev, "power-domain driver not found\n");
> + return 0;
> + }
> +
> if (ret)
> return ret;
> if (on)
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-02-20 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 11:10 [PATCH v8 0/4] Add QCOM RPMH Power Domain Driver Support Aswin Murugan
2026-02-13 11:10 ` [PATCH v8 1/4] power-domain: " Aswin Murugan
2026-02-20 9:00 ` Sumit Garg
2026-02-13 11:10 ` [PATCH v8 2/4] power-domain: Add warning when power-domain driver is missing Aswin Murugan
2026-02-20 9:01 ` Sumit Garg [this message]
2026-02-13 11:10 ` [PATCH v8 3/4] mach-snapdragon: Remove RPMH power domain DT fixup code Aswin Murugan
2026-02-20 9:02 ` Sumit Garg
2026-02-13 11:10 ` [PATCH v8 4/4] qcom_defconfig: Add QCOM_RPMH_POWER_DOMAIN config Aswin Murugan
2026-02-20 9:03 ` Sumit Garg
2026-04-29 8:50 ` [PATCH v8 0/4] Add QCOM RPMH Power Domain Driver Support Casey Connolly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZgjBLn0fiaXL6rY@sumit-xelite \
--to=sumit.garg@kernel.org \
--cc=alif.zakuan.yuslaimi@altera.com \
--cc=aswin.murugan@oss.qualcomm.com \
--cc=balaji.selvanathan@oss.qualcomm.com \
--cc=casey.connolly@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=me@samcday.com \
--cc=miquel.raynal@bootlin.com \
--cc=msp@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=peng.fan@nxp.com \
--cc=rui.silva@linaro.org \
--cc=tien.fong.chee@altera.com \
--cc=trini@konsulko.com \
--cc=u-boot-qcom@groups.io \
--cc=u-boot@lists.denx.de \
--cc=varadarajan.narayanan@oss.qualcomm.com \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox