Re: [PATCH v3 0/9] Add DM support for atmel NAND driver

[<Eugen.Hristev@microchip.com>]

On 12/8/22 18:18, Michael Nazzareno Trimarchi wrote:
> Hi
> 
> On Thu, Dec 8, 2022 at 5:12 PM <Eugen.Hristev@microchip.com> wrote:
>>
>> On 10/25/22 13:51, Balamanikandan Gunasundar wrote:
>>> Change include:
>>>
>>> - Adapt GPIO descriptor apis for U-Boot. Use
>>>     gpio_request_by_name_nodev, dm_gpio_get_value etc.
>>> - Use U_BOOT_DRIVER instead of platform_driver.
>>> - Replace struct platform_device with struct udevice
>>> - Check the status of nfc exec operation by polling the status
>>>     register instead of interrupt based handling
>>> - DMA operations not supported. Remove it
>>> - Adapt DT parsing to U-Boot APIs
>>>
>>> Note:
>>>
>>> I need some advise or help in alligning the DT with Linux as per the
>>> discussion.
>>> https://lore.kernel.org/all/CABGWkvoLDez=yWzpXgO2s+gVs0aUDCEUAYSa8zo_+wGVf4LWAQ@mail.gmail.com/
>>>
>>> v3:
>>>
>>> - Do not check return values while requesting optional gpio pins
>>>     (cs-gpios and rb-gpios)
>>> - Commit message for adding SMC helper function reworded
>>> - The unwanted indentation in the DT is fixed. The changes are made on
>>>     top of "275943dba4 ARM: dts: at91: sam9x60ek: fix indentation for
>>>     pinctrl sub-nodes"
>>>
>>> v2:
>>>
>>> - Add linux reference version in the commit message from which the
>>>     driver is ported from
>>> - Reword the commit message to describe the changes clearly
>>>
>>> Balamanikandan Gunasundar (9):
>>>     nand: atmel: Add DM based NAND driver
>>>     nand: atmel: Add pmecc driver
>>>     mfd: syscon: Add atmel-matrix registers definition
>>>     memory: atmel-ebi: add Atmel EBI (External Bus Interface) driver
>>>     mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation
>>>     configs: at91: sam9x60ek: Enable DM based nand driver
>>>     ARM: dts: at91: sam9x60: Add nodes for EBI and NAND
>>>     ARM: dts: at91: sam9x60ek: Enable NAND support
>>>     board: sam9x60ek: remove nand init from board file
>>>
> 
> Was suppose to get pick on top on nand changes

Hi Michael,

The patches are assigned to me in patchwork. Do you feel they should go 
through the nand tree ?

Feel free to apply them to the nand tree if so and send a PR to next, 
and I will rebase on that if there are still patches left (DT or configs 
maybe)

Let me know

Eugen

> 
> Michael
> 
>>>    MAINTAINERS                                  |    1 +
>>>    arch/arm/dts/sam9x60.dtsi                    |   42 +
>>>    arch/arm/dts/sam9x60ek.dts                   |  103 +
>>>    board/atmel/sam9x60ek/sam9x60ek.c            |   59 -
>>>    configs/sam9x60ek_mmc_defconfig              |    9 +-
>>>    configs/sam9x60ek_nandflash_defconfig        |    9 +-
>>>    configs/sam9x60ek_qspiflash_defconfig        |    8 +-
>>>    drivers/Kconfig                              |    2 +
>>>    drivers/Makefile                             |    1 +
>>>    drivers/memory/Kconfig                       |    7 +
>>>    drivers/memory/Makefile                      |    1 +
>>>    drivers/memory/atmel_ebi.c                   |   37 +
>>>    drivers/mfd/Kconfig                          |    4 +
>>>    drivers/mfd/Makefile                         |    1 +
>>>    drivers/mfd/atmel-smc.c                      |  364 +++
>>>    drivers/mtd/nand/raw/Kconfig                 |    8 +
>>>    drivers/mtd/nand/raw/Makefile                |    1 +
>>>    drivers/mtd/nand/raw/atmel/Makefile          |    5 +
>>>    drivers/mtd/nand/raw/atmel/nand-controller.c | 2286 ++++++++++++++++++
>>>    drivers/mtd/nand/raw/atmel/pmecc.c           |  965 ++++++++
>>>    drivers/mtd/nand/raw/atmel/pmecc.h           |   94 +
>>>    include/configs/sam9x60ek.h                  |    5 -
>>>    include/linux/mfd/syscon/atmel-matrix.h      |  112 +
>>>    include/linux/mfd/syscon/atmel-smc.h         |  119 +
>>>    24 files changed, 4170 insertions(+), 73 deletions(-)
>>>    create mode 100644 drivers/memory/atmel_ebi.c
>>>    create mode 100644 drivers/mfd/Kconfig
>>>    create mode 100644 drivers/mfd/Makefile
>>>    create mode 100644 drivers/mfd/atmel-smc.c
>>>    create mode 100644 drivers/mtd/nand/raw/atmel/Makefile
>>>    create mode 100644 drivers/mtd/nand/raw/atmel/nand-controller.c
>>>    create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.c
>>>    create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.h
>>>    create mode 100644 include/linux/mfd/syscon/atmel-matrix.h
>>>    create mode 100644 include/linux/mfd/syscon/atmel-smc.h
>>>
>>
>>
>> Hi Bala,
>>
>> I have applied the series to u-boot-at91/next here :
>> https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/next
>>
>> Can you double check that everything is fine ? I have done some edits on
>> rebasing.
>>
>> Otherwise, the series will go as a PR to 2023.04 from the at91 tree once
>> the merge window opens.
>>
>> Thanks,
>> Eugen
> 
> 
> 
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
> 
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com