From: Johan Jonker <jbx6244@gmail.com>
To: dario.binacchi@amarulasolutions.com,
michael@amarulasolutions.com, sjg@chromium.org,
philipp.tomsich@vrull.eu, kever.yang@rock-chips.com
Cc: u-boot@lists.denx.de, yifeng.zhao@rock-chips.com
Subject: [PATCH v8 07/24] rockchip: adc: rockchip-saradc: use dev_read_addr_ptr
Date: Mon, 13 Mar 2023 01:29:35 +0100 [thread overview]
Message-ID: <aa278914-6d42-e67f-d0df-bbfefe96bf9d@gmail.com> (raw)
In-Reply-To: <be3c5f12-9df4-0a52-4858-c44d848e9147@gmail.com>
The fdt_addr_t and phys_addr_t size have been decoupled.
A 32bit CPU can expext 64-bit data from the device tree parser,
so use dev_read_addr_ptr in the rockchip-saradc.c file.
As we are there also streamline the error response to -EINVAL on return.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
---
Changed V6:
use -EINVAL on return
drop cast
---
drivers/adc/rockchip-saradc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
index 760f8fe6..809486eb 100644
--- a/drivers/adc/rockchip-saradc.c
+++ b/drivers/adc/rockchip-saradc.c
@@ -145,10 +145,10 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
struct rockchip_saradc_data *data;
data = (struct rockchip_saradc_data *)dev_get_driver_data(dev);
- priv->regs = (struct rockchip_saradc_regs *)dev_read_addr(dev);
- if (priv->regs == (struct rockchip_saradc_regs *)FDT_ADDR_T_NONE) {
+ priv->regs = dev_read_addr_ptr(dev);
+ if (!priv->regs) {
pr_err("Dev: %s - can't get address!", dev->name);
- return -ENODATA;
+ return -EINVAL;
}
priv->data = data;
--
2.20.1
next prev parent reply other threads:[~2023-03-13 0:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 0:23 [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1 Johan Jonker
2023-03-13 0:28 ` [PATCH v8 01/24] mtd: nand: raw: rockchip_nfc: use dev_read_addr_ptr Johan Jonker
2023-03-13 0:28 ` [PATCH v8 02/24] mtd: nand: raw: rockchip_nfc: remove the compatible string "rockchip,rk3308-nfc" Johan Jonker
2023-03-13 0:28 ` [PATCH v8 03/24] mtd: nand: raw: rockchip_nfc: add layout structure Johan Jonker
2023-03-13 0:28 ` [PATCH v8 04/24] mtd: nand: raw: rockchip_nfc: add flash_node to chip structure Johan Jonker
2023-03-13 0:29 ` [PATCH v8 05/24] mtd: nand: raw: rockchip_nfc: fix oobfree offset and description Johan Jonker
2023-03-13 0:29 ` [PATCH v8 06/24] mtd: nand: add support for the Sandisk SDTNQGAMA chip Johan Jonker
2023-03-13 0:29 ` Johan Jonker [this message]
2023-03-13 0:29 ` [PATCH v8 08/24] rockchip: timer: dw-apb-timer: use regs variable with uintptr_t size Johan Jonker
2023-03-13 3:10 ` Simon Glass
2023-03-13 0:30 ` [PATCH v8 09/24] rockchip: pwm: rk_pwm: use base " Johan Jonker
2023-03-13 3:10 ` Simon Glass
2023-03-13 0:30 ` [PATCH v8 10/24] rockchip: spi: rk_spi: " Johan Jonker
2023-03-13 3:10 ` Simon Glass
2023-03-13 0:30 ` [PATCH v8 11/24] include: dm: ofnode: fix headers Johan Jonker
2023-03-13 0:30 ` [PATCH v8 12/24] core: remap: fix regmap_init_mem_plat() reg size handeling Johan Jonker
2023-03-13 3:10 ` Simon Glass
2023-03-13 0:30 ` [PATCH v8 13/24] rockchip: rk3288: syscon_rk3288: store syscon platdata in regmap Johan Jonker
2023-03-13 3:10 ` Simon Glass
2023-03-13 12:15 ` Johan Jonker
2023-03-13 13:26 ` John Keeping
2023-03-13 16:53 ` Johan Jonker
2023-03-13 17:46 ` John Keeping
2023-03-13 21:09 ` Johan Jonker
2023-03-14 18:28 ` John Keeping
2023-03-13 0:31 ` [PATCH v8 14/24] core: fdtaddr: add devfdt_get_addr_size_index_ptr function Johan Jonker
2023-03-13 0:31 ` [PATCH v8 15/24] core: read: add dev_read_addr_index_ptr function Johan Jonker
2023-03-13 0:31 ` [PATCH v8 16/24] spi: spi-aspeed-smc: use devfdt_get_addr_index_ptr Johan Jonker
2023-03-13 0:31 ` [PATCH v8 17/24] drivers: use dev_read_addr_index_ptr when cast to pointer Johan Jonker
2023-03-13 3:10 ` Simon Glass
2023-03-13 0:32 ` [PATCH v8 18/24] drivers: use dev_read_addr_ptr " Johan Jonker
2023-03-13 0:32 ` [PATCH v8 19/24] drivers: use devfdt_get_addr_size_index_ptr " Johan Jonker
2023-03-13 0:32 ` [PATCH v8 20/24] drivers: use devfdt_get_addr_index_ptr " Johan Jonker
2023-03-13 0:32 ` [PATCH v8 21/24] drivers: use devfdt_get_addr_ptr " Johan Jonker
2023-03-13 0:32 ` [PATCH v8 22/24] drivers: fix debug string with fdt_addr_t input Johan Jonker
2023-03-13 0:33 ` [PATCH v8 23/24] arm: stm32mp: spl: fix function " Johan Jonker
2023-03-13 0:33 ` [PATCH v8 24/24] include: fdtdec: decouple fdt_addr_t and phys_addr_t size Johan Jonker
2023-04-21 3:15 ` [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1 Kever Yang
2023-04-21 15:33 ` [PATCH v9] core: fdtaddr: add devfdt_get_addr_size_index_ptr function Johan Jonker
2023-04-21 15:34 ` [PATCH v8 00/24] Fixes for Rockchip NFC driver part 1 Johan Jonker
2023-04-22 20:33 ` Johan Jonker
2023-04-23 1:51 ` Kever Yang
2023-04-23 9:24 ` Johan Jonker
2023-04-24 23:33 ` Simon Glass
2023-04-23 9:19 ` [PATCH v9] core: fdtaddr: use map_sysmem() as cast for the return Johan Jonker
2023-04-24 19:42 ` Simon Glass
2023-04-28 19:20 ` Simon Glass
2023-04-28 19:26 ` Simon Glass
2023-05-10 21:48 ` [PATCH v10] core: fdtaddr: use map_sysmem() as cast for the return (part 2) Johan Jonker
2023-05-11 7:12 ` Kever Yang
2023-05-11 8:03 ` Johan Jonker
2023-05-16 15:19 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa278914-6d42-e67f-d0df-bbfefe96bf9d@gmail.com \
--to=jbx6244@gmail.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=michael@amarulasolutions.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox