From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E61B4C6FD19 for ; Mon, 13 Mar 2023 00:29:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 102A3860FD; Mon, 13 Mar 2023 01:29:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="drNFQ09N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BFC24860FB; Mon, 13 Mar 2023 01:29:40 +0100 (CET) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 34E60860FD for ; Mon, 13 Mar 2023 01:29:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ed1-x535.google.com with SMTP id er25so14121042edb.5 for ; Sun, 12 Mar 2023 17:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678667377; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=70Wj7VfbLYY8+Qmy/sMxsLpuDOX100loTH6vmS4MFi0=; b=drNFQ09NgrrY6sBpOF4a/ZwdHbTmqT7hUOwuMmTUoVycaGo4XSSNxE6Bpcei7DvZxl d3jBIw7uVv3/LUlS5fa+9liVn8XORPassHHuMW34LJ++I1nJuwr7DC88lgoBiJ1FDdUA 0DUy1/ygJbh0Ym5NpUUgq2TmxtGD/wM/FJ+qgm0IAzXY5SmlJn3GwUeUWl2puDru9xQq unxlQJvEPR7XdgdYrUCrmTFabXL8yjan1jQHgvs4unGsYgIuBSMRILYIeGhfA0do5lnw m2zc9ITWTtCftJVYFDyYdfvBA6yllZCrqomXPuKkxbbVnkdqjwIdgoYKnScT4kD+9h6a lm+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678667377; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=70Wj7VfbLYY8+Qmy/sMxsLpuDOX100loTH6vmS4MFi0=; b=j1LUhOlWrjNDOOI+ggz3M7U0K/Z3QIUkFEFh3tNb9rCdLFyJv2qPJD1A2CQ182XGo2 UBntmFH7q3Dz7YC1rCCMRJySOdooDAtqIVRudQJzv3I363vaWXZ+UhYY2iH3p+vKqoUX TgeMUhSHf6tgn8+MlZRAS9kgCJ8iDj2n+EkvyXO8zXTZm9JuQeeG9NdUzNPT8LVdlkDN yduABzTyzC+s/MnYkbUShb5CuClhxZK/J5SM86STjt1hcIOsMPjbxFmmZBHCNvdJ2kjY a8ZLSGwoeIuOQbOR2SwG8elku38NYaCoCUz+WkdlAWDFbMyn1fM8b2znI2itJNs4Q3at k+8w== X-Gm-Message-State: AO0yUKWgIbEvZaLMD7iZpPeWJIHCqWH9UichPim3IhFOYXFdpi9GaXFZ 5apXAtzz2iONu4T7sMFDKgc= X-Google-Smtp-Source: AK7set9cHYxfok/pL6gYGOuCninnmoFiA1/vEN/DPB9Itc0VtnpAqnwLE88uSfRK46bLLZ2Cruo3SQ== X-Received: by 2002:a17:907:1c07:b0:920:307a:21d9 with SMTP id nc7-20020a1709071c0700b00920307a21d9mr7359495ejc.15.1678667376772; Sun, 12 Mar 2023 17:29:36 -0700 (PDT) Received: from [192.168.2.2] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id v10-20020a50954a000000b004c0239e41d8sm2641402eda.81.2023.03.12.17.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 17:29:36 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 01:29:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Johan Jonker Subject: [PATCH v8 07/24] rockchip: adc: rockchip-saradc: use dev_read_addr_ptr To: dario.binacchi@amarulasolutions.com, michael@amarulasolutions.com, sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com Cc: u-boot@lists.denx.de, yifeng.zhao@rock-chips.com References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The fdt_addr_t and phys_addr_t size have been decoupled. A 32bit CPU can expext 64-bit data from the device tree parser, so use dev_read_addr_ptr in the rockchip-saradc.c file. As we are there also streamline the error response to -EINVAL on return. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang --- Changed V6: use -EINVAL on return drop cast --- drivers/adc/rockchip-saradc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c index 760f8fe6..809486eb 100644 --- a/drivers/adc/rockchip-saradc.c +++ b/drivers/adc/rockchip-saradc.c @@ -145,10 +145,10 @@ int rockchip_saradc_of_to_plat(struct udevice *dev) struct rockchip_saradc_data *data; data = (struct rockchip_saradc_data *)dev_get_driver_data(dev); - priv->regs = (struct rockchip_saradc_regs *)dev_read_addr(dev); - if (priv->regs == (struct rockchip_saradc_regs *)FDT_ADDR_T_NONE) { + priv->regs = dev_read_addr_ptr(dev); + if (!priv->regs) { pr_err("Dev: %s - can't get address!", dev->name); - return -ENODATA; + return -EINVAL; } priv->data = data; -- 2.20.1