Re: [PATCH] serial: goldfish: Add DEBUG_UART support

Daniel Palmer
2026-03-09T09:55:07Z

Hi Kuan-Wei,

On Mon, 9 Mar 2026 at 18:10, Kuan-Wei Chiu <visitorckw@gmail.com> wrote:

> I think we should also call debug_uart_init() in qemu-m68k.c. This way,
> the <debug_uart> string will be properly printed when the
> CONFIG_DEBUG_UART_ANNOUNCE option is enabled.

I looked up the other callers to debug_uart_init() and it looks like a
lot of them are in the start.S for the arch.
Maybe it should be added to arch/m68k/cpu/m680x0/start.S?

> > + void *base = (void *)CONFIG_DEBUG_UART_BASE;
>
> It might be better to use CONFIG_VAL(DEBUG_UART_BASE) here to keep it
> robust for potential future SPL/TPL builds.
>
> Also, since this is a mmio register, I think casting to void __iomem *
> would be more appropriate.

Noted. I'll fix that up.

Cheers,

Daniel